Maniphest T301810

Cannot search on Vector 2022 skin (Error: Cannot require undefined file resources/skins.vector.search/fetch.js)
Closed, ResolvedPublic0 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

Focus search input and the search never loads. JavaScript exception Error: Cannot require undefined file resources/skins.vector.search/fetch.js is shown.

normalized_message

exception.trace

Impact

Notes

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Add fetch tests from WVUI"	mediawiki/skins/Vector	master	+55 -157

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	hashar	T300198 1.38.0-wmf.22 deployment blockers
		Resolved	PRODUCTION ERROR	Jdlrobson	T301810 Cannot search on Vector 2022 skin (Error: Cannot require undefined file resources/skins.vector.search/fetch.js)

Event Timeline

Jdlrobson removed hashar as the assignee of this task.Feb 15 2022, 6:11 PM

Jdlrobson triaged this task as Medium priority.

Jdlrobson raised the priority of this task from Medium to Unbreak Now!.

Jdlrobson created this task.

Jdlrobson created this object with edit policy "Custom Policy".

Jdlrobson added a subscriber: hashar.

Jdlrobson assigned this task to bwang.Feb 15 2022, 6:13 PM

Jdlrobson moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson changed the point value for this task from 5 to 0.

Broken on mediawiki.org

Jdlrobson mentioned this in T300198: 1.38.0-wmf.22 deployment blockers.Feb 15 2022, 6:23 PM

Introduced in this patch, I forgot to include fetch.js in the packageFiles in skin.json.

Here is the revert patch

Jdlrobson removed bwang as the assignee of this task.Feb 15 2022, 6:47 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson added a subscriber: bwang.

Change 762764 had a related patch set uploaded (by Jforrester; author: Bernard Wang):

[mediawiki/skins/Vector@master] Revert \"Add fetch tests from WVUI\"

https://gerrit.wikimedia.org/r/762764

gerritbot added a project: Patch-For-Review.Feb 15 2022, 6:47 PM

Jdlrobson mentioned this in T283388: packagefiles should accept wildcards.Feb 15 2022, 6:59 PM

Change 762764 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revert \"Add fetch tests from WVUI\"

https://gerrit.wikimedia.org/r/762764

Resolved?

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 15 2022, 8:00 PM

Confirmed as fixed. Thanks for the backport!

bwang mentioned this in T301924: Add tests to check that all modules using require have required module files listed in `packageFiles` .Feb 16 2022, 10:15 PM

Krinkle moved this task from Untriaged to Feb 2022 on the Wikimedia-production-error board.Mar 14 2022, 4:17 PM