Recent message fallback change breaks fundraising banners
Closed, ResolvedPublic
Actions

Description

The deployed solution to T300069 (showing the correct message title when viewing with qqx) has bad side-effects when the string '$/' exists in a banner. Fundraising banners that include regexes are throwing JS errors 'Unterminated regular expression literal'

For example:

https://en.wikipedia.org/wiki/Wikipedia?banner=B2122_0119_enWW_dsk_p1_lg_template&country=US

Could we revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/761486 or update it with a different delimiter that doesn't break regexes?

Note: It happens that Fundraising banners are not live right now. However, this also breaks FR banner previews, needed to test banners that are expected to go live shortly.

Details

Subject	Repo	Branch	Lines +/-
Use less-common placeholders for qqx formatting	mediawiki/core	master	+11 -9
Only apply transformations for &uselang=qqx when actually using it	mediawiki/core	master	+24 -18
Revert "Revert "Show message fallback keys when using &uselang=qqx""	mediawiki/core	wmf/1.38.0-wmf.23	+32 -2
Revert "Show message fallback keys when using &uselang=qqx"	mediawiki/core	master	+2 -32
Revert "Show message fallback keys when using &uselang=qqx"	mediawiki/core	wmf/1.38.0-wmf.23	+2 -32

Customize query in gerrit

Related Objects

Mentioned In: T300069: wfMessageFallback doesn't play well with qqx
T300199: 1.38.0-wmf.23 deployment blockers
Mentioned Here: T300069: wfMessageFallback doesn't play well with qqx

Event Timeline

Ejegg created this task.Feb 24 2022, 1:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2022, 1:12 AM

Ejegg triaged this task as Unbreak Now! priority.Feb 24 2022, 1:13 AM

Restricted Application added a subscriber: Pcoombe. · View Herald TranscriptFeb 24 2022, 1:13 AM

Ejegg added a subscriber: HNordeenWMF.Feb 24 2022, 1:15 AM

Change 765359 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/core@master] Use less-common placeholders for qqx formatting

https://gerrit.wikimedia.org/r/765359

gerritbot added a project: Patch-For-Review.Feb 24 2022, 1:38 AM

Ejegg added subscribers: Nikerabbit, matmarex.Feb 24 2022, 1:45 AM

Change 765360 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/core@master] Revert \"Show message fallback keys when using &uselang=qqx\"

https://gerrit.wikimedia.org/r/765360

Ejegg moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Feb 24 2022, 2:28 AM

Ejegg added a project: Fundraising Sprint Cheese String Theory.

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Cheese String Theory board.

Change 765360 merged by jenkins-bot:

[mediawiki/core@master] Revert \"Show message fallback keys when using &uselang=qqx\"

https://gerrit.wikimedia.org/r/765360

AndyRussG mentioned this in T300199: 1.38.0-wmf.23 deployment blockers.Feb 24 2022, 6:57 AM

AndyRussG moved this task from Doing to Pending Deployment on the Fundraising Sprint Cheese String Theory board.Feb 24 2022, 7:00 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 24 2022, 7:00 AM

Stealing to help get deployed.

RhinosF1 moved this task from Radar to Deployment on the User-RhinosF1 board.Feb 24 2022, 7:10 AM

Change 765369 had a related patch set uploaded (by RhinosF1; author: Ejegg):

[mediawiki/core@wmf/1.38.0-wmf.23] Revert \"Show message fallback keys when using &uselang=qqx\"

https://gerrit.wikimedia.org/r/765369

Change 765369 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.23] Revert \"Show message fallback keys when using &uselang=qqx\"

https://gerrit.wikimedia.org/r/765369

Deployment tests failed:

load.php?lang=en-gb&modules=ext.graph.vega2|jquery|jquery.ui&skin=vector&version=19zuz:747 Uncaught RangeError: Incorrect locale information provided
    at new NumberFormat (<anonymous>)
    at Object.frb.formatCurrency (<anonymous>:1645:25)
    at HTMLDocument.<anonymous> (<anonymous>:2179:25)
    at mightThrow (en.wikipedia.org/w/load.php?lang=en-gb&modules=ext.graph.vega2%7Cjquery%7Cjquery.ui&skin=vector&version=19zuz:744:881)
    at process (en.wikipedia.org/w/load.php?lang=en-gb&modules=ext.graph.vega2%7Cjquery%7Cjquery.ui&skin=vector&version=19zuz:745:544)
frb.formatCurrency @ VM1016:1645
(anonymous) @ VM1016:2179
mightThrow @ load.php?lang=en-gb&modules=ext.graph.vega2|jquery|jquery.ui&skin=vector&version=19zuz:744
process @ load.php?lang=en-gb&modules=ext.graph.vega2|jquery|jquery.ui&skin=vector&version=19zuz:745
load.php?lang=en-gb&modules=ext.graph.vega2|jquery|jquery.ui&skin=vector&version=19zuz:747 Uncaught RangeError: Incorrect locale information provided
    at new NumberFormat (<anonymous>)
    at Object.frb.formatCurrency (<anonymous>:1645:25)
    at HTMLInputElement.<anonymous> (<anonymous>:1975:34)
    at Function.each (en.wikipedia.org/w/load.php?lang=en-gb&modules=ext.graph.vega2%7Cjquery%7Cjquery.ui&skin=vector&version=19zuz:700:285)
    at jQuery.fn.init.each (en.wikipedia.org/w/load.php?lang=en-gb&modules=ext.graph.vega2%7Cjquery%7Cjquery.ui&skin=vector&version=19zuz:698:93)
    at Object.frb.localizeAmountOptions (<anonymous>:1965:41)
    at HTMLDocument.<anonymous> (<anonymous>:2288:9)
    at mightThrow (en.wikipedia.org/w/load.php?lang=en-gb&modules=ext.graph.vega2%7Cjquery%7Cjquery.ui&skin=vector&version=19zuz:744:881)
    at process (en.wikipedia.org/w/load.php?lang=en-gb&modules=ext.graph.vega2%7Cjquery%7Cjquery.ui&skin=vector&version=19zuz:745:544)

Change 765371 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.38.0-wmf.23] Revert \"Revert \"Show message fallback keys when using &uselang=qqx\"\"

https://gerrit.wikimedia.org/r/765371

Change 765371 merged by Urbanecm:

[mediawiki/core@wmf/1.38.0-wmf.23] Revert \"Revert \"Show message fallback keys when using &uselang=qqx\"\"

https://gerrit.wikimedia.org/r/765371

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.23; 2022-02-21); removed MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 24 2022, 9:00 AM

Ammarpad mentioned this in T300069: wfMessageFallback doesn't play well with qqx.Feb 24 2022, 11:30 AM

Thanks so much @Urbanecm @RhinosF1 @Ammarpad! We'll dig in later today to figure out what caused the deploy to fail.

Also note that it happens that Fundraising banners are not live right now. However, this does also break banner previews, needed to test banners that are expected to go live shortly.

AndyRussG updated the task description. (Show Details)Feb 24 2022, 3:30 PM

RhinosF1 removed RhinosF1 as the assignee of this task.Feb 24 2022, 3:31 PM

AndyRussG updated the task description. (Show Details)Feb 24 2022, 3:33 PM

Change 765601 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Only apply transformations for &uselang=qqx when actually using it

https://gerrit.wikimedia.org/r/765601

(This is my proposed fix for later, we just probably just revert for now)

@matmarex: see above. A revert didn't work.

Well, feel free to review and merge and backport my patch in that case, but I'm pretty sure it worked fine, and the error was unrelated; see T300069#7736271.

AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Cheese String Theory board.Feb 24 2022, 9:45 PM

The revert was deployed for real in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/765626 (which wasn't tagged with this task).

• DStrine closed this task as Resolved.Mar 1 2022, 8:05 PM

• DStrine set Final Story Points to 2.

Change 765601 merged by jenkins-bot:

[mediawiki/core@master] Only apply transformations for &uselang=qqx when actually using it

https://gerrit.wikimedia.org/r/765601

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.26; 2022-03-14); removed MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Mar 8 2022, 4:00 AM

Change 765359 abandoned by Ammarpad:

[mediawiki/core@master] Use less-common placeholders for qqx formatting

Reason:

The issue has been resolved with Ib0e282b3864caf345e42dd7af4a529f43ae7ba67