Page MenuHomePhabricator

Adjust placement of tabs for full-width pages
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

In Vector 2022 most page content has a max-width, however some page content does not (see T260091 for more context). In an effort to have more consistency between pages with max-width and pages without max-width, I made a decision that the tabs should remain in the same place on both kinds of pages. This was somewhat controversial (mainly because it looks kind of weird, see discussion here: T246420#6249759).

After living with the updated layout for some time, and re-evaluating the need for the tabs to always be in the same place (which I don't think is as great as I assumed originally...people aren't likely switching between tabs very rapidly), I've decided that we should remove the special tab placement code so that the tabs are always at the edges of the toolbar:

currentupdated
history current.png (852×1 px, 149 KB)
history updated.png (877×1 px, 147 KB)
rc current.png (829×1 px, 188 KB)
rc updated.png (800×1 px, 186 KB)

QA Results - Prod

ACStatusDetails
1T306353#7948673

Event Timeline

I've marked this as a subtask of T303484 and moved this to block since I'm overhauling how the layout works and this should be considered part of the specification for completing.

Change 787566 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Disable max width on article toolbar container

https://gerrit.wikimedia.org/r/787566

Will be unblocked by patch 1 of the grid change, which I've now added to the code review column (https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/787562)

Actually this can be done safely now without interfering with the existing grid system work.

This will also be automatically fixed by T303549 so I am wondering if we should just do that? To fix T303549 I have to undo the patch to fix this one.

LGoto set the point value for this task to 2.

Change 787566 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Disable max width on article toolbar container

https://gerrit.wikimedia.org/r/787566

This can be design reviewed on beta cluster. Move to sign off when happy or needs more work.

looks good to me. @ovasileva I think you mentioned a question you had during standup, maybe related to the live preview in the editor work?

Screen Shot 2022-05-05 at 3.02.59 PM.png (889×1 px, 392 KB)
Screen Shot 2022-05-05 at 3.03.33 PM.png (892×1 px, 176 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Tabs should be at the edges of the toolbar.

Screen Shot 2022-05-22 at 6.43.17 PM.png (218×712 px, 25 KB)

Screen Shot 2022-05-22 at 6.42.45 PM.png (273×1 px, 61 KB)

Screen Shot 2022-05-22 at 6.43.02 PM.png (311×1 px, 66 KB)

Screen Shot 2022-05-22 at 6.44.01 PM.png (312×1 px, 78 KB)

LGoto added a subscriber: Edtadros.
cjming reassigned this task from cjming to Jdlrobson.
cjming subscribed.