Mobile footer elements ("Read as wiki page" footer, last-modified bar icons) obfuscate mobile link card
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• iamjessklein
	May 7 2022, 9:14 PM

Description

This task involves the work of making it so the mobile footer elements do NOT obfuscate/appear "on top of" the mobile link card.

Behavior

On a mobile device, visit: https://patchdemo.wmflabs.org/wikis/916be355b2/w/index.php?title=Talk:Climate_change&mobileaction=toggle_view_mobile
Click a Reply button near the bottom of the page
Insert a link
Tap the link to reveal the link edit card

Actual

❗️ Notice the Read as wiki page footer, as well as icons from the last-modified bar, appear atop the link card, making it difficult to see and use the affordances:

Expected

✅ Notice the full contents and functionality within the link edit card are in view and usable

Background

On a usability test (Test A/UT-8), a tester tried to add a link and scroll up and down while using the mobile reply tool for Talk Page. When they scrolled, part of the interface moved up and down with the scroll in an unexpected way.
This issue is documented in T307840 and I'm including a clip to the recording.

UserTesting-4050570A-Clip1.mp4243 KBDownload

Details

Subject	Repo	Branch	Lines +/-
MobileArticleTarget: Avoid jittering while scrolling	mediawiki/extensions/VisualEditor	master	+6 -0
Update VE core submodule to master (595380444)	mediawiki/extensions/VisualEditor	master	+1 -1
ve.ui.Surface: Attach mobile context to global overlay	VisualEditor/VisualEditor	master	+13 -1
CommentTarget: Attach toolbar popups to surface global overlay	mediawiki/extensions/DiscussionTools	master	+15 -1
MobileArticleTarget: Attach toolbar popups to surface global overlay	mediawiki/extensions/VisualEditor	master	+3 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T278588 Mobile talk page improvements
Resolved		None	T298055 [RELEASE TICKET] Offer Mobile Usability Improvements and Topic Subscriptions at Partner Wikis
Resolved	BUG REPORT	matmarex	T307849 Mobile footer elements ("Read as wiki page" footer, last-modified bar icons) obfuscate mobile link card

Event Timeline

• iamjessklein created this task.May 7 2022, 9:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2022, 9:14 PM

• iamjessklein mentioned this in T307840: Run Test A (senior visits Junior's empty user talk) and synthesize feedback.May 7 2022, 9:15 PM

ppelberg renamed this task from Bug: Scrolling issues with mobile talk interface to Link edit card obfuscates mobile Reply Tool input.May 10 2022, 7:08 PM

ppelberg edited projects, added DiscussionTools; removed Talk Pages.

ppelberg merged a task: T294614: Mobile DiscussionTools' link inspector appears disconnected from the tools.

ppelberg added a parent task: T307840: Run Test A (senior visits Junior's empty user talk) and synthesize feedback.

ppelberg added subscribers: ppelberg, Amorymeltzer, AdHuikeshoven and 9 others.

Esanders removed subscribers: Smarti, DLynch, • LZaman and 9 others.May 11 2022, 4:44 PM

ppelberg renamed this task from Link edit card obfuscates mobile Reply Tool input to "Read as wiki page" footer obfuscates mobile link card.May 12 2022, 1:18 AM

ppelberg updated the task description. (Show Details)

ppelberg added projects: Editing-team (Kanban Board), Design.May 17 2022, 12:53 AM

ppelberg added a parent task: T282638: [RELEASE TICKET] Offer Mobile Reply and New Discussion Tools at Partner Wikis.

I noticed this in the new topic tool while working on another issue:

These icons are leaking through from the last-modified bar below the new topic tool:

This seems to be the same problem as the "Read as wiki page" footer, and I think this means we have to prioritize this fix.

matmarex renamed this task from "Read as wiki page" footer obfuscates mobile link card to Mobile footer elements ("Read as wiki page" footer, last-modified bar icons) obfuscate mobile link card.May 19 2022, 2:38 AM

matmarex updated the task description. (Show Details)

Change 793136 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] ve.ui.Surface: Attach mobile context to global overlay

https://gerrit.wikimedia.org/r/793136

gerritbot added a project: Patch-For-Review.May 19 2022, 2:54 AM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.May 19 2022, 3:00 AM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.May 19 2022, 3:18 PM

matmarex mentioned this in T293129: Edit cards overlap dialog elements on mobile in some cases.May 19 2022, 11:26 PM

Change 793562 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Attach toolbar popups to surface global overlay

https://gerrit.wikimedia.org/r/793562

Change 793138 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] CommentTarget: Attach toolbar popups to surface global overlay

https://gerrit.wikimedia.org/r/793138

Change 793562 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Attach toolbar popups to surface global overlay

Reason:

Not needed after all, https://gerrit.wikimedia.org/r/793136 makes these changes in VE core

https://gerrit.wikimedia.org/r/793562

Change 793138 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/DiscussionTools@master] CommentTarget: Attach toolbar popups to surface global overlay

Reason:

Not needed after all, https://gerrit.wikimedia.org/r/793136 makes these changes in VE core

https://gerrit.wikimedia.org/r/793138

Change 794117 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Avoid jittering while scrolling

https://gerrit.wikimedia.org/r/794117

Change 793136 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] ve.ui.Surface: Attach mobile context to global overlay

https://gerrit.wikimedia.org/r/793136

Change 794559 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (595380444)

https://gerrit.wikimedia.org/r/794559

Change 794559 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (595380444)

https://gerrit.wikimedia.org/r/794559

Change 794117 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Avoid jittering while scrolling

https://gerrit.wikimedia.org/r/794117

Maintenance_bot removed a project: Patch-For-Review.May 21 2022, 3:30 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.May 21 2022, 3:43 PM

matmarex added a project: Editing QA.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 21 2022, 4:00 PM

matmarex moved this task from Inbox to High Priority on the Editing QA board.May 23 2022, 5:33 PM

ppelberg edited parent tasks, added: T298055: [RELEASE TICKET] Offer Mobile Usability Improvements and Topic Subscriptions at Partner Wikis; removed: T282638: [RELEASE TICKET] Offer Mobile Reply and New Discussion Tools at Partner Wikis.May 26 2022, 11:52 PM

EAkinloose edited projects, added Verified; removed Editing QA.Jun 2 2022, 3:07 PM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

ppelberg closed this task as Resolved.Jun 3 2022, 6:10 PM

ppelberg removed a parent task: T307840: Run Test A (senior visits Junior's empty user talk) and synthesize feedback.Jun 10 2022, 10:59 PM

	F35111440: UserTesting-4050570A-Clip1.mp4
	May 7 2022, 9:14 PM

	F35152917: image.png
	May 19 2022, 2:33 AM

	F35152913: image.png
	May 19 2022, 2:33 AM

Mobile footer elements ("Read as wiki page" footer, last-modified bar icons) obfuscate mobile link cardClosed, ResolvedPublicBUG REPORTActions