Page MenuHomePhabricator

Switch from WikiLambda Dialog component to Codex Dialog component
Closed, ResolvedPublic

Description

Event Timeline

Change 863027 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] replace custom dialog with codex dialog

https://gerrit.wikimedia.org/r/863027

Currently, is not possible to add a subtitle inside a Codex dialog component. In the context of Wikifunctions, we might be able to use this potential subtitle to display the test result name in the metadata dialog. Here's a proposal that was put together by @bmartinezcalvo!

image.png (1×2 px, 755 KB)

While I was looking at Bárbara's proposal, I was wondering if it's necessary to display the test result name in the dialog at all. If a person clicks on the info icon of a specific test result, my assumption is that their action is strongly intentional, and backed up by technical knowledge. In that scenario, how necessary is to re-display the test result name? I'm asking because if we remove the name (aka subtitle) from the dialog, we might not need this patch from the Codex team.

image.png (702×1 px, 111 KB)

btw I would move the "Help" link to the bottom (or to other place in the dialog) in order to separate it more from the close button and prevent the user from clicking one of them by mistake.

Captura de Pantalla 2022-12-12 a las 15.56.52.png (762×1 px, 371 KB)

Change 863027 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] replace custom dialog with codex dialog

https://gerrit.wikimedia.org/r/863027

There's one instance left to replace, which is related to Metadata related work.
@dmartin @Jdforrester-WMF I'm leaving this unassigned for now.

AAlhazwani-WMF claimed this task.

There's one instance left to replace, which is related to Metadata related work.
@dmartin @Jdforrester-WMF I'm leaving this unassigned for now.

This looks done to me!

image.png (1×2 px, 585 KB)