Relevant Codex ticket: https://phabricator.wikimedia.org/T284838
Description
Details
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/extensions/WikiLambda | master | +172 -620 | replace custom dialog with codex dialog |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T325821 PublishDialog: Update dialog to use Codex dialog footer slots once it is ready | |||
Open | None | T308468 Switch from WikiLambda Dialog component to Codex Dialog component | |||
Resolved | Catrope | T284838 [EPIC] Add Dialog component to Codex | |||
Resolved | ldelench_wmf | T313773 Design and build initial Dialog component (MVP) | |||
Declined | egardner | T319026 Dialog MVP: Design fixes |
Event Timeline
Change 863027 had a related patch set uploaded (by Jkieserman; author: Jkieserman):
[mediawiki/extensions/WikiLambda@master] replace custom dialog with codex dialog
Currently, is not possible to add a subtitle inside a Codex dialog component. In the context of Wikifunctions, we might be able to use this potential subtitle to display the test result name in the metadata dialog. Here's a proposal that was put together by @bmartinezcalvo!
While I was looking at Bárbara's proposal, I was wondering if it's necessary to display the test result name in the dialog at all. If a person clicks on the info icon of a specific test result, my assumption is that their action is strongly intentional, and backed up by technical knowledge. In that scenario, how necessary is to re-display the test result name? I'm asking because if we remove the name (aka subtitle) from the dialog, we might not need this patch from the Codex team.
btw I would move the "Help" link to the bottom (or to other place in the dialog) in order to separate it more from the close button and prevent the user from clicking one of them by mistake.
Change 863027 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] replace custom dialog with codex dialog
There's one instance left to replace, which is related to Metadata related work.
@dmartin @Jdforrester-WMF I'm leaving this unassigned for now.