| Quiddity | |
| Sep 23 2022, 8:53 PM |
| F39538491: screenshot 167.png | |
| Oct 22 2023, 8:16 PM |
| F38817360: screenshot 134.png | |
| Oct 19 2023, 4:28 PM |
| F35531233: image.png | |
| Sep 23 2022, 8:53 PM |
| F35531230: image.png | |
| Sep 23 2022, 8:53 PM |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T318447#9265927 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T318447#9270928 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Vector sticky header dynamic edit icons order | mediawiki/skins/Vector | master | +26 -10 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | ovasileva | T317884 [EPIC] Vector 2022 post-deployment work | |||
| Resolved | BUG REPORT | ovasileva | T318447 Edit-links are shown in reverse order in sticky header from standard tabs in article |
Note that the order of these tabs is controlled by the config VisualEditorTabPosition, which can be before (default) or after. In WMF config it is set to after if wmgVisualEditorIsSecondaryEditor is set on a non-single-edit-tab wiki, which is the case on 2 wikis: eswiki and hewiki.
Adding the visual edit button should be done in the VisualEditor extension, so an API should be exposed from Vector to allow extensions to do this.
VE can then place the button in the correct order, depending on VisualEditorTabPosition.
Do we need to consult VisualEditorTabsPosition or could we work out the order of these buttons by inspecting the DOM and seeing the order of the links there ?
You probably could, but doing it properly is going to be more robust in the long term.
I think it's more important to let the code live in VE, at which point it becomes trivial to use the config.
Change 957817 had a related patch set uploaded (by Mabualruz; author: Mabualruz):
[mediawiki/skins/Vector@master] Vector sticky header dynamic edit icons order
Moving back to incoming since team didn't commit yet to finishing this during the sprint
Change 957817 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Vector sticky header dynamic edit icons order
Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
When using the Preference for "Show me both editor tabs"
✅ AC1: The edit | edit source links in Vector-2022's sticky header, are in the same order as the standard links.
Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
When using the Preference for "Show me both editor tabs"
✅ AC1: The edit | edit source links in Vector-2022's sticky header, are in the same order as the standard links.
