Maniphest T321963

NewImpact module: Implement unactivated state code from Impact.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Oct 29 2022, 12:34 AM

Description

Steps to reproduce:

On enwiki betalabs create a new account
A new user goes to Special:Homepage where the Impact module Last edited shows incorrect value

Screen Shot 2022-10-28 at 5.31.00 PM.png (1×2 px, 398 KB)

The Console will display the error:

TypeError: Cannot read properties of undefined (reading 'days')
at Proxy.bestStreakDaysLocalisedCount

Expected behaviour/design

Scenario	Desktop	Mobile	Mobile summary (no change)
Scenario A: Person has 0 edits, Suggested edits is enabled. – Use the existing empty state
Scenario B: Person has 0 edits, Suggested edits is disabled. – Use the empty state with references to Suggested edits removed	Replace footer text	Remove CTA button, replace footer text	Same empty state

Details

	Subject	Repo	Branch	Lines +/-
	User impact: add disabled and unactivated state	mediawiki/extensions/GrowthExperiments	master	+461 -186
	[WIP] User impact: add unactivated state	mediawiki/extensions/GrowthExperiments	master	+224 -17

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	KStoller-WMF	T248330 [EPIC] Growth: Positive reinforcement
Resolved	KStoller-WMF	T222310 [EPIC] Positive reinforcement: New Impact Module
Resolved	Sgs	T310665 Impact module: summary panel
Resolved	Sgs	T310661 Impact module: scorecards
Resolved	Sgs	T321963 NewImpact module: Implement unactivated state code from Impact.php
Resolved	Sgs	T322850 Add thanks and longest streak scorecards to the unactivated state
Resolved	Sgs	T329157 NewImpact: Make mobile CTA button use progressive primary blue

Event Timeline

Etonkovidova created this task.Oct 29 2022, 12:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2022, 12:34 AM

Etonkovidova added a parent task: T310661: Impact module: scorecards.Oct 29 2022, 12:37 AM

Once the impact module is complete, the empty state should display rather than an empty score card (with incorrect date).

@Sgs - thoughts on if this bug needs to be fixed, or if we can ignore the issue because it won't be noticeable once you've implemented the empty state?

In T321963#8355039, @KStoller-WMF wrote:

Once the impact module is complete, the empty state should display rather than an empty score card (with incorrect date).

@Sgs - thoughts on if this bug needs to be fixed, or if we can ignore the issue because it won't be noticeable once you've implemented the empty state?

We should fix this by copying over the logic from the older impact module to show the unactivated state. We don't need to worry about code duplication or copy/paste because we'll be removing Impact.php when this epic is wrapped up.

One change we'll want to make is to check $user->getTotalEditCount() instead of queryArticleEdits().

Etonkovidova renamed this task from Impact module: scorecards displays incorrect time for the Last edited to Impact module: scorecards display incorrect time for the Last edited.Nov 1 2022, 7:39 PM

kostajh renamed this task from Impact module: scorecards display incorrect time for the Last edited to NewImpact module: Implement unactivated state code from Impact.php.Nov 1 2022, 8:20 PM

Sgs claimed this task.Nov 4 2022, 5:08 PM

Sgs moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 853378 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] User impact: display empty state when user has no edits

https://gerrit.wikimedia.org/r/853378

gerritbot added a project: Patch-For-Review.Nov 4 2022, 5:09 PM

In T321963#8359159, @kostajh wrote:

We should fix this by copying over the logic from the older impact module to show the unactivated state. We don't need to worry about code duplication or copy/paste because we'll be removing Impact.php when this epic is wrapped up.

Do you mean to reuse also the OOUI client side code that implements the intermediate step of showing the "About suggested edits" dialog?

Screenshot 2022-11-07 at 16.41.13.png (1×2 px, 330 KB)

One change we'll want to make is to check $user->getTotalEditCount() instead of queryArticleEdits().

Alright, I will copy the logic from Impact->getArticleEditCount(). Do you think we should build the unactivated state markup in the server or the client? Since the total count is already avaialble when the Javascript loads it could make sense to not have to maintain server html generation at the cost of render time. But I'm fine with both approaches.

Sgs moved this task from In Progress to Blocked / Needs work on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 7 2022, 4:55 PM

Change 854048 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] User impact: add unactivated state

https://gerrit.wikimedia.org/r/854048

Change 854048 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] [WIP] User impact: add unactivated state

Reason:

Squashed in Id3c6064979b678ac24a1a3e32f55467f6ac72f3f

https://gerrit.wikimedia.org/r/854048

Sgs changed the task status from Open to In Progress.Nov 7 2022, 7:12 PM

Sgs moved this task from Blocked / Needs work to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

While developing this issue we've come across the views for the "suggested edits disabled" state, see screenshots per view:

State/View	Desktop	Summary	Overlay
Suggested edits disabled
Suggested edits enabled, 0 edits to articles

Are the suggested edits disabled state views correct or we want to have some new display for these? @RHo

In T321963#8382596, @Sgs wrote:

While developing this issue we've come across the views for the "suggested edits disabled" state, see screenshots per view:

State/View Desktop Summary Overlay

Suggested edits disabled

Suggested edits enabled, 0 edits to articles

Are the suggested edits disabled state views correct or we want to have some new display for these? @RHo

Thanks for noticing this @Sgs - I think we should use the same "0 edits to articles" empty state of the impact module when Suggested edits is enabled, but remove the CTA on the mobile view to see suggested edits, and use the generic Once you start editing, you’ll see here how many people are viewing the articles you’ve edited. text string that is used on the mobile summary empty state. I'll update the task description as well to make this clear.

RHo updated the task description. (Show Details)Nov 9 2022, 2:49 PM

Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 9 2022, 3:57 PM

Etonkovidova mentioned this in T310666: Impact Module: Recent Editing Activity.Nov 10 2022, 1:39 AM

Sgs moved this task from Code Review to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 10 2022, 9:50 AM

kostajh triaged this task as Medium priority.Nov 10 2022, 11:45 AM

RHo renamed this task from NewImpact module: Implement unactivated state code from Impact.php to NewImpact module: Implement unactivated state code from Impact.php with additional Summary scorecards added.Nov 10 2022, 12:19 PM

RHo updated the task description. (Show Details)

Hi @Sgs - I've added the intended new empty state of the Impact module which should have a couple of the scorecards present. Is this easily achieveable? If not, I can move adding this section as a new task for follow-up work for v2.

In T321963#8386257, @RHo wrote:

Hi @Sgs - I've added the intended new empty state of the Impact module which should have a couple of the scorecards present. Is this easily achieveable? If not, I can move adding this section as a new task for follow-up work for v2.

I have split the addition of scorecards in the subtask T322850. Not sure if we'll be able to fit it in the first release or v2 since we have a significant queue of tasks for v1.

In T321963#8386512, @Sgs wrote:

In T321963#8386257, @RHo wrote:

Hi @Sgs - I've added the intended new empty state of the Impact module which should have a couple of the scorecards present. Is this easily achieveable? If not, I can move adding this section as a new task for follow-up work for v2.

I have split the addition of scorecards in the subtask T322850. Not sure if we'll be able to fit it in the first release or v2 since we have a significant queue of tasks for v1.

Super, thanks for doing that! I will update this one with the previous mocks.

RHo renamed this task from NewImpact module: Implement unactivated state code from Impact.php with additional Summary scorecards added to NewImpact module: Implement unactivated state code from Impact.php .Nov 10 2022, 1:57 PM

RHo updated the task description. (Show Details)

Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 10 2022, 5:55 PM

Change 853378 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: add disabled and unactivated state

https://gerrit.wikimedia.org/r/853378

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 15 2022, 2:00 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 18 2022, 9:34 AM

MShilova_WMF mentioned this in T222310: [EPIC] Positive reinforcement: New Impact Module.Nov 18 2022, 3:10 PM

kostajh added a project: GrowthExperiments-ImpactModule.Nov 21 2022, 4:48 PM

Checked in wmf.12 - looks according to the specs (new-impact=1 url parameter was used) . The Suggested edits disabled state was checked on frwikitionary.

Suggested edits enabled	Suggested edits disabled
Mobile

Sgs changed the status of subtask T322850: Add thanks and longest streak scorecards to the unactivated state from Open to In Progress.Jan 19 2023, 2:38 AM

kostajh closed subtask T322850: Add thanks and longest streak scorecards to the unactivated state as Resolved.Feb 8 2023, 11:25 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2023, 11:31 AM

Urbanecm_WMF mentioned this in T329192: When Suggested edits are unavailable, new Impact module stays in unactivated state.Feb 21 2023, 9:46 PM

	F35827662: Screen Shot 2022-12-01 at 4.39.15 PM.png
	Dec 2 2022, 1:06 AM

	F35827660: Screen Shot 2022-12-01 at 4.38.55 PM.png
	Dec 2 2022, 1:06 AM

	F35827658: Screen Shot 2022-12-01 at 5.04.42 PM.png
	Dec 2 2022, 1:06 AM

	F35827650: Screen Shot 2022-12-01 at 4.41.24 PM.png
	Dec 2 2022, 1:06 AM

	F35827654: Screen Shot 2022-12-01 at 4.59.20 PM.png
	Dec 2 2022, 1:06 AM

	F35827648: Screen Shot 2022-12-01 at 4.38.30 PM.png
	Dec 2 2022, 1:06 AM

	F35741382: image.png
	Nov 10 2022, 12:19 PM

	F35741369: image.png
	Nov 10 2022, 12:19 PM

NewImpact module: Implement unactivated state code from Impact.php Closed, ResolvedPublicActions