Page MenuHomePhabricator
Create Task
Maniphest T323083

Drop temporary feature flag SpecialContributeSkinsEnabled
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
Jdlrobson
Nov 15 2022, 12:26 AM
Tags
Referenced Files
F35778901: Screen Shot 2022-11-14 at 4.21.56 PM.png
Nov 15 2022, 12:26 AM
F35778908: Screen Shot 2022-11-14 at 4.24.31 PM.png
Nov 15 2022, 12:26 AM
Subscribers
Aklapper
alistair3149
Jdlrobson
• Mabualruz
Masumrezarock100
matmarex
Pginer-WMF
santhosh

Description

During 1.39 we have added the SpecialContributeSkinsDisabled feature flag (later renamed to SpecialContributeSkinsEnabled) as a temporary stopgap that controls whether the tabs are shown at the top of the Special:Contributions page. We would like to remove this prior to the 1.40 release so that we do not have to support it in future MediaWiki releases.

At time of writing this flag is enabled on the beta cluster for Minerva skin:
https://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson

Screen Shot 2022-11-14 at 4.24.31 PM.png (1×2 px, 225 KB)

Screen Shot 2022-11-14 at 4.21.56 PM.png (832×1 px, 147 KB)

Without the feature flag, the menu will automatically show up on Vector 2022 and Minerva skins (as well as any third party skins which make use of this special menu for special pages).

Background: T319327#8376355

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT322740 Contribute entry point
 OpenNoneT323083 Drop temporary feature flag SpecialContributeSkinsEnabled

Event Timeline

Jdlrobson created this task.Nov 15 2022, 12:26 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptNov 15 2022, 12:26 AM
Jdlrobson added a comment.Nov 15 2022, 12:27 AM

@Pginer-WMF:

  1. What task is unconditionally showing the tabs on Special:Contributions page blocked on?
  2. Would showing this menu in the Vector 2022 skin cause any problems for the language team?
Jdlrobson mentioned this in T319327: [S] Make Special:Contribute the default entry point in the menu.Nov 15 2022, 12:28 AM
santhosh subscribed.Nov 15 2022, 5:12 AM
santhosh added a comment.Nov 15 2022, 5:22 AM

The translate card in Special:Contribute does not make sense in wikis when accessed in mobile and when mobile mode of CX(also known as section translation) is not available. But in T319306: Adjust visibility for the option to translate in the Persistent Contribution entry point we made sure that Translate option card will be shown only when it is a valid option in a mobile/desktop mode in a specific wiki. So that part is covered.

The remaining issue is not directly related to language team, but ageneral issue.

Other than the 'Translate' option, the only other entrypoint there is "New article" card. Currently we are discussing T321379: Special:Contribute should give the possibility to prevent specific cards from being displayed or change the link target how to improve it and we see that there are some wikis where this card won't have any meaningful entrypoint. For example, a wiki that does not have Wikipedia:RequestedPages page. Depending on that a wiki may end up with blank Special:Contribute? I think that is the only issue we need to consider before having this feature enabled everywhere by default.

Jdlrobson added a comment.Nov 15 2022, 8:49 PM

Perhaps when there are zero options Special:Contribute should redirect and the tabs should not display.

In T321379 if we go with the message to configure which page to use we could also check if the message is disabled to allow wiki to disable that page.

Pginer-WMF added a parent task: T322740: Contribute entry point.Nov 21 2022, 11:09 AM
Pginer-WMF edited projects, added Language-Team (Language-2022-October-December); removed Language-Team.
Pginer-WMF added a comment.Nov 28 2022, 12:04 PM
In T323083#8397733, @Jdlrobson wrote:

Perhaps when there are zero options Special:Contribute should redirect and the tabs should not display.

If this is technically viable, I think it could work quite well. If there are no options the user gets the list of their contributions (the Contributions page).
This case is expected to become more and more rare as more options are added to the list.

Jdlrobson added a comment.Nov 29 2022, 12:35 AM

^ @matmarex @Mabualruz would hiding tabs when zero options be viable? I guess we'd need to redirect Special:Contribute to Special:Contributions in this case (so that we can retain the menu item to contribute as a static link?)

Jdlrobson moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Dec 16 2022, 1:55 AM
matmarex added a comment.Feb 17 2023, 1:24 AM

MediaWiki 1.40 branching has been announced for 13 March 2023 (https://lists.wikimedia.org/hyperkitty/list/mediawiki-l@lists.wikimedia.org/thread/BVQPPSTYUCYAQDLRBK6GDXDYB5UDPWVN/). This task should probably be resolved before that time. Is anyone working on this?

Jdlrobson added a comment.Feb 24 2023, 7:12 PM

@santhosh how close is the language team to being able to display the tabs? What are the blockers to doing this?

Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.40-release board.Mar 2 2023, 1:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits