Page MenuHomePhabricator

Vector 2022 search handles text overflow inconsistently
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

I feel like this is partly a regression, but I am not sure.

Steps to replicate the issue:

Search for a long page name on Wikipedia through the Vector 2022 typeahead search bar, e.g. Kategorie:Wikipedia:Vorlagenfehler/Vorlage:Navigationsleiste Musik/Tabelle on dewiki.

What happens?:
The search results in the drop-down are handled with overflow:hidden, so long names will be cut off (even in the middle, whenever there are spaces). Meanwhile, the search footer will cause overflow.

Screenshot Vector Search 2023-03-24.jpg (711×1 px, 205 KB)

What should have happened instead?:
Search results/recommendations and the search footer need to show a consistent behaviour. Ideally, it would use hyphens:auto and word-wrap: break-word (which seems to have been implemented for the search results, but without any effect, as the overflow:hidden cuts them off), so no overflow would be caused and the search term will not be cut in the middle of the word. Alternatively (or additionally), overflow:hidden can be used.

QA steps

Expected: The footer text should not overflow the search suggestions container.

QA Results - Prod

ACStatusDetails
1T333030#8878510

Event Timeline

ovasileva moved this task from Incoming to Current Quarter on the Web-Team-Backlog board.
LGoto set the point value for this task to 3.Mar 27 2023, 5:31 PM
ovasileva lowered the priority of this task from High to Medium.Apr 10 2023, 5:29 PM

Change 919049 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Vector 2022 search handles text overflow inconsistently

https://gerrit.wikimedia.org/r/919049

Change 919049 abandoned by Bernard Wang:

[mediawiki/skins/Vector@master] Vector 2022 search handles text overflow inconsistently

Reason:

jan taking over this one, and doing a new patch in codex

https://gerrit.wikimedia.org/r/919049

Change 920783 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[design/codex@main] [Typeahead search] Use menu item classes for the search footer

https://gerrit.wikimedia.org/r/920783

Change 920783 merged by jenkins-bot:

[design/codex@main] TypeaheadSearch: Use menu item classes for the search footer

https://gerrit.wikimedia.org/r/920783

The task is merged but wont be able to be QAed until the change is released in Codex, moving to Blocked for that reason

Edit: it might be possible to QA on the updated Codex documentation site?

Codex should have a release tmr, so we should be able to test this in beta cluster after then

Jdrewniak updated the task description. (Show Details)
Jdrewniak updated Other Assignee, removed: Jdrewniak.
Jdrewniak subscribed.

Change 922610 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v0.10.0 to v0.11.0

https://gerrit.wikimedia.org/r/922610

Change 922610 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.10.0 to v0.11.0

https://gerrit.wikimedia.org/r/922610

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Reduce width to around 720px
visit https://en.wikipedia.org/?useskin=vector-2022
Search for Category:Ssssssssssssssssssssssssssssssssssssssssssssssssssss
✅ AC1: The footer text should not overflow the search suggestions container.

Screen Recording 2023-05-24 at 3.11.24 PM.mov.gif (718×686 px, 865 KB)

Jdlrobson claimed this task.
Jdlrobson added a project: Verified.

Thanks @Edtadros for verifying it!