Thanks for describing the possible error messages @Tchanders. I think for the first four which would happen because of bugs (or cases when things changed after the page has loaded, user got blocked etc) we could just show 'error' how we show 'unavailable'.

Too many revisions were sent in the API request - not a software bug; user was on a long page

I think for this one (and others like it if there are any) we should tell the user what is happening. Preferably in a dialog (OOUI/Codex) if we have that available, or at least in the text.

Change 924969 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/CheckUser@master] Show error message when clicking on an IP reveal button results in an API error

https://gerrit.wikimedia.org/r/924969

Change 924969 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Show error message when clicking on an IP reveal button results in an API error

https://gerrit.wikimedia.org/r/924969

@TThoabala Do we need to do this for Show IP on Special:Block? Should I create a separate task?

@dom_walden I think we should create a separate task for that.

@Tchanders should we create a ticket for Too many revisions were sent in the API request - not a software bug; user was on a long page?

@TThoabala So the first two seem to be working as designed since they do not display ShowIP.

"The specified username ($1) is invalid" - which indicates a bug in building the request UR- when the username is deleted, it just shows "username removed". Is that fine for that?

Various bad parameter messages - which indicate a bug in building the request URL- IP was deleted from the DB but it still shows "unavailable" besides "error"

The last two are different errors that I came across in Special:Block. Please let me know if you want separate tasks for them or however, you want me to proceed. Thanks!

OS: macOS 13.3
Browser: Chrome 113
Environment: Local

Testing IP reveal on:

• Revision history
• Special:Contributions
• Special:Log
• Special:Block
• Special:RecentChanges
• Special:Watchlist
• Diff
• Page information

You do not have permission to perform the action- WAD; Removed checkuser-temporary-account

"You do not have permission to perform the action because your account is blocked- WAD; Blocked Testusertwo

The specified username ($1) is invalid- WAD?; Deleted *Unregistered 31

Various bad parameter messages -WAD?; IP removed from the DB

Different Special:Block Errors
On the username invalid screenshot, I deleted *Unregistered 31. When I was checking out various pages to see if it has the same outcome, it has except on Special:Block. All the other pages it shows deleted but on Special:Block it still shows the IP address of the deleted user

Also on Special:Block when you do a partial with a selected page like in the example I used for "Dog". Show IP did not show up on all the other pages too when it was supposed to be just on the "Dog" page.

In T333190#8905809, @TThoabala wrote:

@dom_walden I think we should create a separate task for that.

I created T338620.

Thanks at @GMikesell-WMF, I think all other bits look good besides the special block stuff. Some of these will be covered by the ticket @dom_walden created, but could we please create another ticket for partial block use case above.

Sounds good @TThoabala ! I will move this to Done as I created T338645: Special:Block- Partial block page blocks all pages for ShowIP and added my other error in T338620: Show IP: Handle API errors on Special:Block