Page MenuHomePhabricator
Create Task
Maniphest T340256

Popups: Use Codex markup for buttons instead of mediawiki.ui markup
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

After switching to Codex for our buttons, Popups is now loading redundant CSS for buttons and icons on page load. We should update the markup in Popups ASAP to use the Codex CSS button component.

See example for ULS @ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/932470

QA

  • Go in an incognito window
  • Display a page preview
  • A settings cog should appear in the bottom right and look like other icons in the page
  • Clicking the settings cog should open a dialog with a close icon and button. Both should look normal

QA Results - Beta

ACStatusDetails
1✅T340256#9007508
2✅T340256#9007508

QA Results - Prod

ACStatusDetails
1✅T340256#9020539
2✅T340256#9020539

Details

SubjectRepoBranchLines +/-
Update popups to use codex buttons over mediawiki.ui.buttonsmediawiki/extensions/Popupsmaster+108 -69
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jun 23 2023, 8:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2023, 8:46 PM
Jdlrobson triaged this task as High priority.Jun 23 2023, 8:46 PM
Jdlrobson added a parent task: T182050: Remove all mediawiki.ui components and libraries in favor of Codex.Jun 23 2023, 8:50 PM
Jdlrobson added a parent task: T235937: Remove 'mediawiki.ui.icon' .Jun 23 2023, 8:54 PM
Jdlrobson mentioned this in T340263: Deprecate mediawiki.ui.button. Use Codex markup instead..Jun 23 2023, 9:21 PM
LGoto set the point value for this task to 2.Jun 29 2023, 5:29 PM
Jdlrobson lowered the priority of this task from High to Medium.Jun 29 2023, 5:51 PM
Jdlrobson raised the priority of this task from Medium to High.
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.
bwang claimed this task.Jul 6 2023, 4:34 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.
gerritbot added a comment.Jul 10 2023, 7:40 PM

Change 936323 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Popups@master] Update popups to use codex buttons over mediawiki.ui.buttons

https://gerrit.wikimedia.org/r/936323

gerritbot added a project: Patch-For-Review.Jul 10 2023, 7:40 PM
bwang removed bwang as the assignee of this task.Jul 10 2023, 7:40 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.
bwang subscribed.
gerritbot added a comment.Jul 10 2023, 9:39 PM

Change 936323 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Update popups to use codex buttons over mediawiki.ui.buttons

https://gerrit.wikimedia.org/r/936323

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 10 2023, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 10 2023, 10:11 PM
Jdlrobson assigned this task to Edtadros.Jul 11 2023, 12:22 AM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.
Jdlrobson updated the task description. (Show Details)Jul 11 2023, 4:39 PM
Edtadros removed Edtadros as the assignee of this task.Jul 12 2023, 2:02 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go in an incognito window
Display a page preview
✅ AC1: A settings cog should appear in the bottom right and look like other icons in the page
✅ AC2: Clicking the settings cog should open a dialog with a close icon and button. Both should look normal

Screen Recording 2023-07-11 at 6.55.51 PM.mov.gif (1×1 px, 865 KB)

Edtadros updated the task description. (Show Details)Jul 12 2023, 2:04 AM
Mabualruz claimed this task.Jul 13 2023, 4:39 PM
Jdlrobson renamed this task from Popups: Use Codex markup instead of mediawiki.ui markup to Popups: Use Codex markup for buttons instead of mediawiki.ui markup.Jul 14 2023, 6:11 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson reassigned this task from Mabualruz to Edtadros.Jul 14 2023, 6:14 PM
Jdlrobson moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.
Jdlrobson added a subscriber: Mabualruz.

No matches for Popups for the styles:

There was a slight misunderstanding around the scope of the ticket however so I'm was seeing mw-ui-icon markup. I've created T341899 to handle that and modified this ticket to be about only the buttons.

Passing to Edward for one last round of QA.

Edtadros closed this task as Resolved.Jul 17 2023, 4:26 PM
Edtadros removed Edtadros as the assignee of this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go in an incognito window
Display a page preview
✅ AC1: A settings cog should appear in the bottom right and look like other icons in the page
✅ AC2: Clicking the settings cog should open a dialog with a close icon and button. Both should look normal

Screen Recording 2023-07-17 at 9.22.59 AM.mov.gif (944×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Jul 17 2023, 4:27 PM
gerritbot added a comment.Sep 7 2023, 3:50 PM

Change 955777 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Fix settings button not working on reference previews

https://gerrit.wikimedia.org/r/955777

gerritbot added a project: Patch-For-Review.Sep 7 2023, 3:50 PM
thiemowmde mentioned this in T352179: Reference previews broken for references with % in the name.Nov 28 2023, 2:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL