[IP Masking] Expire temporary accounts in 1 year
Closed, ResolvedPublic4 Estimated Story Points
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Aug 22 2023, 1:21 PM

Description

Temporary accounts should expire in 1 year from their first edit. Since there is no way to login into a temporary account, expiration can be implemented by logging the temporary account out. Account expiration can be implemented via a maintenance script, which would be regularly executed via a systemd timer.

See implementation notes at T300271#9106396.

Acceptance Criteria

A user's temporary account name expires after one year (365 days) since their first edit and the username is unassigned from the account.
- A returning user will no longer see the temp account name in the personal bar.
- Account expiration is implemented by logging the temporary account off.

Details

Subject	Repo	Branch	Lines +/-
[beta] Temporary accounts: Set expiry to 1 year	operations/mediawiki-config	master	+2 -3
IP Masking: Set expiryAfterDays to a year	operations/mediawiki-config	master	+1 -3
IP Masking: Expire temporary accounts in 1 year	mediawiki/core	master	+245 -1
mediawiki: Add missing frequency param to the purge_temporary_accounts job	operations/puppet	production	+1 -1
IP Masking temp account expiry: Fix a typo	operations/mediawiki-config	master	+1 -1
mediawiki: Run expireTemporaryAccounts.php daily	operations/puppet	production	+10 -0
IP Masking: Expire temporary accounts in 1 year	mediawiki/core	wmf/1.42.0-wmf.4	+245 -1
IP Masking: Add expireTemporaryAccounts.php	mediawiki/extensions/CentralAuth	wmf/1.42.0-wmf.4	+136 -11
IP Masking: Set expiryAfterDays to 1 day	operations/mediawiki-config	master	+3 -0
IP Masking: Add expireTemporaryAccounts.php	mediawiki/extensions/CentralAuth	master	+136 -11

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	• Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for IP Masking
Open	KStoller-WMF	T326877 [Epic] Update Growth Team-owned products that may be affected by IP Masking
Resolved	lbowmaker	T262321 IP Masking
Resolved	Urbanecm_WMF	T300271 [IP Masking] Temporary Account Expiration
Resolved	Urbanecm_WMF	T344695 [IP Masking] Expire temporary accounts in 1 year

Event Timeline

Urbanecm_WMF created this task.Aug 22 2023, 1:21 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 22 2023, 1:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Urbanecm_WMF mentioned this in T344694: [IP Masking] Alert temporary accounts 10 days before expiration.Aug 22 2023, 1:22 PM

Urbanecm_WMF added a parent task: T300271: [IP Masking] Temporary Account Expiration.

Urbanecm_WMF mentioned this in T300271: [IP Masking] Temporary Account Expiration.

Urbanecm_WMF triaged this task as Medium priority.Aug 22 2023, 1:25 PM

Urbanecm_WMF moved this task from Inbox to Sprint 0 (Growth Team) on the Growth-Team board.

Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

Urbanecm_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

KStoller-WMF subscribed.Aug 22 2023, 3:07 PM

Tgr subscribed.Aug 23 2023, 11:56 AM

Change 951967 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] [WIP] IP Masking: Expire temporary accounts in 1 year

https://gerrit.wikimedia.org/r/951967

gerritbot added a project: Patch-For-Review.Aug 23 2023, 4:24 PM

Change 952396 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] Add User::getGlobalRegistration

https://gerrit.wikimedia.org/r/952396

Change 952397 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@master] Implement UserGetGlobalRegistrationHook

https://gerrit.wikimedia.org/r/952397

Urbanecm_WMF claimed this task.Aug 25 2023, 12:49 PM

Change 952487 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@master] IP Masking: Add expireTemporaryAccounts.php

https://gerrit.wikimedia.org/r/952487

Urbanecm_WMF changed the task status from Open to In Progress.Sep 15 2023, 12:01 PM

Urbanecm_WMF moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Urbanecm_WMF edited projects, added Growth-Team (Sprint 1 (Growth Team)); removed Growth-Team (Sprint 0 (Growth Team)).Oct 25 2023, 9:56 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 1 (Growth Team)) board.Oct 25 2023, 9:56 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 2 (Growth Team)); removed Growth-Team (Sprint 1 (Growth Team)).Oct 30 2023, 6:58 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 2 (Growth Team)) board.Oct 30 2023, 7:48 PM

cc @Tchanders @TAdeleye_WMF, I got a ping requesting code review for this, maybe we can fit it into the next sprint?

Tchanders added a project: Trust and Safety Product Sprint.Nov 1 2023, 8:26 PM

Change 973167 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/puppet@production] mediawiki: Run expireTemporaryAccounts.php daily

https://gerrit.wikimedia.org/r/973167

Change 951967 merged by jenkins-bot:

[mediawiki/core@master] IP Masking: Expire temporary accounts in 1 year

https://gerrit.wikimedia.org/r/951967

Change 952487 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] IP Masking: Add expireTemporaryAccounts.php

https://gerrit.wikimedia.org/r/952487

Change 973172 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] IP Masking: Set expiryAfterDays to 10 days

https://gerrit.wikimedia.org/r/973172

This now needs to wait for wmf.5 to be live on the production cluster. Then, we can ask SREs to merge and deploy https://gerrit.wikimedia.org/r/973167 and then, we can move this to QA. Moving to Blocked in the meantime.

Urbanecm_WMF changed the task status from In Progress to Stalled.Nov 9 2023, 2:48 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 9 2023, 3:00 PM

Change 973881 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] IP Masking: Set expiryAfterDays to a year

https://gerrit.wikimedia.org/r/973881

Change 973172 merged by jenkins-bot:

[operations/mediawiki-config@master] IP Masking: Set expiryAfterDays to 1 day

https://gerrit.wikimedia.org/r/973172

Change 974143 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.42.0-wmf.4] IP Masking: Expire temporary accounts in 1 year

https://gerrit.wikimedia.org/r/974143

Change 974144 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@wmf/1.42.0-wmf.4] IP Masking: Add expireTemporaryAccounts.php

https://gerrit.wikimedia.org/r/974144

Change 974143 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.4] IP Masking: Expire temporary accounts in 1 year

https://gerrit.wikimedia.org/r/974143

Change 974144 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.42.0-wmf.4] IP Masking: Add expireTemporaryAccounts.php

https://gerrit.wikimedia.org/r/974144

Mentioned in SAL (#wikimedia-operations) [2023-11-14T14:25:14Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:974143|IP Masking: Expire temporary accounts in 1 year (T344695)]], [[gerrit:974191|TempUser: Fix unchecked array access for optional key]], [[gerrit:974144|IP Masking: Add expireTemporaryAccounts.php (T344695)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-14T14:26:39Z] <urbanecm@deploy2002> urbanecm: Backport for [[gerrit:974143|IP Masking: Expire temporary accounts in 1 year (T344695)]], [[gerrit:974191|TempUser: Fix unchecked array access for optional key]], [[gerrit:974144|IP Masking: Add expireTemporaryAccounts.php (T344695)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-14T14:32:17Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:974143|IP Masking: Expire temporary accounts in 1 year (T344695)]], [[gerrit:974191|TempUser: Fix unchecked array access for optional key]], [[gerrit:974144|IP Masking: Add expireTemporaryAccounts.php (T344695)]] (duration: 07m 03s)

KStoller-WMF edited projects, added Growth-Team (Sprint 3 (Growth Team)); removed Growth-Team (Sprint 2 (Growth Team)).Nov 14 2023, 2:44 PM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.4; 2023-11-07); removed MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 14 2023, 3:00 PM

I ended up backporting the code, so that we can test this in the wild sooner. I've scheduled the puppet patch for deployment later today, and then we can move this to QA.

Change 973167 merged by Jbond:

[operations/puppet@production] mediawiki: Run expireTemporaryAccounts.php daily

https://gerrit.wikimedia.org/r/973167

Urbanecm_WMF moved this task from Doing to QA on the Growth-Team (Sprint 3 (Growth Team)) board.Nov 14 2023, 10:44 PM

@Etonkovidova This is now testable at beta wikis where IP Masking is enabled. I set the expiry to 1 day as requested. Please let me know what you think and whether it is OK to increase the expiry to a year, as requested. For now, moving to QA. The other part (T344694) is still in CR.

Urbanecm_WMF set the point value for this task to 4.Nov 14 2023, 11:34 PM

Change 974726 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/puppet@production] mediawiki: Add missing frequency param to the purge_temporary_accounts job

https://gerrit.wikimedia.org/r/974726

Change 974728 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] IP Masking temp account expiry: Fix a typo

https://gerrit.wikimedia.org/r/974728

Change 974728 merged by jenkins-bot:

[operations/mediawiki-config@master] IP Masking temp account expiry: Fix a typo

https://gerrit.wikimedia.org/r/974728

Change 974726 merged by RLazarus:

[operations/puppet@production] mediawiki: Add missing frequency param to the purge_temporary_accounts job

https://gerrit.wikimedia.org/r/974726

Etonkovidova updated the task description. (Show Details)Nov 18 2023, 5:13 PM

In T344695#9332627, @Urbanecm_WMF wrote:

@Etonkovidova This is now testable at beta wikis where IP Masking is enabled. I set the expiry to 1 day as requested. Please let me know what you think and whether it is OK to increase the expiry to a year, as requested. For now, moving to QA. The other part (T344694) is still in CR.

Checked with Special:Contributions/*Unregistered_41470; there was a slight extension of the expiration period (1 day): a user was able to make an edit after two hours after 24-hour period:

Screen Shot 2023-11-18 at 9.20.45 AM.png (1×2 px, 248 KB)

Thanks @Etonkovidova for the tests. I think this is caused by the fact that the expiry logic runs daily at a specific time (14:27 UTC, to be precise), which means the account expires once it is at least a day old at 14:27 UTC. I personally don't think this is a problem (there'd be at most a day delay over a year) though. If @KStoller-WMF thinks this is problematic behaviour, we can certainly revisit.

In T344695#9344433, @Urbanecm_WMF wrote:

Thanks @Etonkovidova for the tests. I think this is caused by the fact that the expiry logic runs daily at a specific time (14:27 UTC, to be precise), which means the account expires once it is at least a day old at 14:27 UTC. I personally don't think this is a problem (there'd be at most a day delay over a year) though. If @KStoller-WMF thinks this is problematic behaviour, we can certainly revisit.

I don't see the problem with expiration being slightly off, especially if the expiration will happen after a year.

I re-tested it (e.g. Special:Contributions for *Unregistered 10454 for the purposes of 1) having more testing data 2) see how from a temp user point of view the transition happens after the temp user session gets expired.
The results:

the edits spanned from 18. 11. 2023, 18:22 to 20. 11. 2023, 06:57
when temp user account is expired, and a temp user attempts to edits, a temp user will see the initial warning (for the first edit). Upon publishing an edit, a new temp user name will be assigned.

{F41523270}
https://phabricator.wikimedia.org/T300271#9106396 (notifying a user 10 days before expiration date) will mitigate it. Preferably, it'd be great a specific warning when a expired temp user will attempt to edit or to visibly sign out (the tool bar will display the fact that a temp user was signed out), but it's probably quite problematic.

Change 973881 abandoned by Urbanecm:

[operations/mediawiki-config@master] IP Masking: Set expiryAfterDays to a year

Reason:

https://gerrit.wikimedia.org/r/973881

Change 990248 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] [beta] Temporary accounts: Set expiry to 1 year

https://gerrit.wikimedia.org/r/990248

Change 990248 merged by jenkins-bot: