Page MenuHomePhabricator
Create Task
Maniphest T344835

Activity pane on front page no longer shows New Tasks by default after Phorge migration
Closed, ResolvedPublicBUG REPORT
Actions

Description

From IRC:

<Dreamy_Jazz> 	One thing that might be different is the Activity pane doesn't seem expanded by default. I can't remember 100% whether it was expanded by default before, but the empty space looks odd.
<marostegui> 	Dreamy_Jazz: It was expanded by default before, yeah
<marostegui> 	At least it'd show stuff
<Dreamy_Jazz> 	It does still show stuff if you click on one of the tabs
<marostegui> 	yeah
<jynus> 	I expect minor inconveniences to show up, it always happens on upgrade
<Dreamy_Jazz> 	^
<jynus> 	but as long as it is that, it is not a big issue
<Dreamy_Jazz> 	No problem with it being like this. Just wanted to report it.
<brennen> 	thanks, noted. we think this is an upstream issue that should be fixed with future updates.

Just creating this task since I couldn’t find an existing one (no upstream issue either), and I also use the New Tasks pane regularly and am looking forward to it coming back. (But it’s probably not the top priority 🙂)

Related file(s):

Recent related changes:

Problematic Panels

https://phabricator.wikimedia.org/W6

Activity

Upstream Task in Phorge:

https://we.phorge.it/T15651

Details

Other Assignee
brennen

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Aug 23 2023, 4:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2023, 4:16 PM
Aklapper removed a parent task: T333885: Migrate phabricator.wikimedia.org to Phorge as upstream.Aug 23 2023, 4:18 PM
Aklapper removed projects: Release-Engineering-Team (Escape Goats🐐), collaboration-services.Aug 23 2023, 4:22 PM
Aklapper removed subscribers: jcrespo, Marostegui.

Workaround: Clicking one of the tabs shows the content.

Peachey88 updated the task description. (Show Details)Aug 23 2023, 8:22 PM
Peachey88 subscribed.
Mainframe98 subscribed.Aug 24 2023, 6:24 AM
Daimona subscribed.Aug 26 2023, 1:15 AM
valerio.bozzolan subscribed.Aug 29 2023, 12:03 PM
valerio.bozzolan updated the task description. (Show Details)Aug 29 2023, 12:10 PM
valerio.bozzolan added a comment.Aug 29 2023, 12:17 PM

Uhm. I see. At the moment I cannot reproduce with the upstream code of Phorge so I wonder if this is just something related to Wikimedia Phorge.

I see that downstream is not completely up to date with the stable branch of Phorge. For example this patch is missing at least AFAIK: https://we.phorge.it/D25308 but that seems to me an un-relevant change.

valerio.bozzolan added a comment.Aug 29 2023, 12:33 PM

I'm not able to reproduce this problem locally with upstream Phorge at https://we.phorge.it/source/phorge

But, even more interestingly, I've done a checkout of the branch wmf/stable from https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/tree/wmf/stable

And I get the same result. It seems to work in both cases. Same screenshot:

Test Dashboard.png (916×1 px, 225 KB)

valerio.bozzolan added a subscriber: Dylsss.Aug 29 2023, 1:06 PM

Maybe @Dylsss would like to give an eye on this

valerio.bozzolan added a comment.Aug 29 2023, 1:24 PM

Don't tell anyone that I would like to put this in production and collect its logs when visiting with ?asd=1

diff --git a/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php b/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
index 831229bab1..0598057419 100644
--- a/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
+++ b/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
@@ -112,6 +112,11 @@ final class PhabricatorDashboardTabsPanelType
       }

       $is_selected = (string)$idx === (string)$selected;
+      if(isset($_GET['asd'])) {
+        phlog("Tab view $name");
+        phlog($idx);
+        phlog($selected);
+      }

       $tab_view = id(new PHUIListItemView())
         ->setHref('#')
@@ -283,6 +288,11 @@ final class PhabricatorDashboardTabsPanelType
       }

       $is_selected = (string)$idx === (string)$selected;
+      if(isset($_GET['asd'])) {
+        phlog("Panel entry $panel_id");
+        phlog($idx);
+        phlog($selected);
+      }

       $content_id = celerity_generate_unique_node_id();
valerio.bozzolan added a parent task: T333885: Migrate phabricator.wikimedia.org to Phorge as upstream.Aug 29 2023, 3:45 PM
valerio.bozzolan added a comment.Aug 29 2023, 3:47 PM

Unsure if this should be a Sub-task of the migration (even if the parent is resolved) or just a mention. Feel free to disconnect.

valerio.bozzolan changed the subtype of this task from "Task" to "Bug Report".Aug 29 2023, 3:47 PM
Aklapper removed a parent task: T333885: Migrate phabricator.wikimedia.org to Phorge as upstream.Aug 31 2023, 7:09 PM
MarcoAurelio subscribed.Sep 6 2023, 4:42 PM
stjn subscribed.Sep 7 2023, 4:29 PM
Rexogamer subscribed.Sep 8 2023, 9:44 PM
Ammarpad merged a task: T346169: The content of the "Activity" column on Phabricator's homepage is incorrectly set to display none..Sep 12 2023, 4:31 PM
Ammarpad added a subscriber: SunAfterRain.
valerio.bozzolan added a comment.Sep 19 2023, 7:31 AM

I've examined 100+ Wikimedia Dashboards and... I also cannot reproduce here in production ._.

For example, this super-nice Dashboard from the SRE team has so many tab panels and it works perfectly:

https://phabricator.wikimedia.org/dashboard/view/653/

complex Dashboard that still works.png (920×1 px, 268 KB)

I wouldn't be surprised if the workaround is: re-create the Dashboard.

valerio.bozzolan updated the task description. (Show Details)Sep 19 2023, 7:32 AM

OK interesting, I've limited the scope to just W6

valerio.bozzolan added a comment.Sep 19 2023, 7:45 AM

Since I'm totally not a virus but I'm a dolphin, maybe a lovely person may want to bless the user @valerio.bozzolan to be allowed to edit W6 (I say edit, but I mean inspect with my big eyes, without saving anything)

CodeReviewBot added a project: Patch-For-Review.Oct 3 2023, 10:03 AM

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/19

Add temporary debug output for T344835

CodeReviewBot added a comment.Oct 3 2023, 2:00 PM

brennen merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/19

Add temporary debug output for T344835

Maintenance_bot removed a project: Patch-For-Review.Oct 3 2023, 2:10 PM
brennen mentioned this in T348007: Deploy Phabricator/Phorge 2023-10-03.Oct 3 2023, 2:17 PM
CodeReviewBot added a project: Patch-For-Review.Oct 3 2023, 2:17 PM

brennen opened https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/20

Phabricator release 2023-10-03

Aklapper removed a project: Patch-For-Review.Oct 3 2023, 3:24 PM
Aklapper added a comment.Oct 4 2023, 9:21 PM
In T344835#9126783, @valerio.bozzolan wrote:

Don't tell anyone that I would like to put this in production and collect its logs when visiting with ?asd=1

@valerio.bozzolan: After going to https://phabricator.wikimedia.org/W6?T344835 :

'Tab view name: New Tasks' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:117]
'idx: dlvotftew3ju' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:118]
'selected: 0' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:119]

'Tab view name: Closed Tasks' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:117]
'idx: 1' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:118]
'selected: 0' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:119]

'Tab view name: Latest Projects' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:117]
'idx: 3' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:118]
'selected: 0' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:119]

'Tab view name: Good first newcomer tasks' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:117]
'idx: 6eyn2xscrxdr' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:118]
'selected: 0' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:119]

'Panel entry id: 2475' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:294]
'idx: dlvotftew3ju' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:295]
'selected: 0' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:296]

'Panel entry id: 5' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:294]
'idx: 1' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:295]
'selected: 0' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:296]

'Panel entry id: 8' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:294]
'idx: 3' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:295]
'selected: 0' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:296]

'Panel entry id: 2917' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:294]
'idx: 6eyn2xscrxdr' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:295]
'selected: 0' at [/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:296]
valerio.bozzolan edited projects, added Phabricator (Upstream), Upstream; removed Phabricator.Oct 5 2023, 6:48 AM
valerio.bozzolan moved this task from Backlog to Reported Upstream on the Upstream board.

Thanks! Very interesting legacy heritage. Sometime the Tab Panels had 2+ tabs opened. Now you have zero tabs opened. That is the very same bug.

Filed upstream in Phorge. Editing the description.

valerio.bozzolan updated the task description. (Show Details)Oct 5 2023, 6:48 AM
Aklapper moved this task from Backlog to Upstreamed on the Phabricator (Upstream) board.Oct 5 2023, 7:01 AM
Aklapper triaged this task as Low priority.Oct 8 2023, 12:08 PM
valerio.bozzolan added a comment.EditedOct 12 2023, 1:20 PM

I'm quite sure that this will do the thing:

commit a90b3b78db8122355b9dc6529e6da3a76fb6bb8c
Author: Valerio Bozzolan <nsa+gitspam@succhia.cz>
Date:   Thu Oct 12 15:06:40 2023 +0200

    Dashboard Panel: fix first tab sometime not opened by default
    
    This change assures that - as default - the first ID is selected.
    
    Note that sometime these IDs are numerics, sometime they are strings,
    so we rely on NULL as "no value".

diff --git a/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php b/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
index 3cf73b539e..dc72fc818d 100644
--- a/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
+++ b/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
@@ -85,10 +85,12 @@ final class PhabricatorDashboardTabsPanelType
     $rename_uri = id(new PhutilURI($rename_uri))
       ->replaceQueryParam('contextPHID', $context_phid);
 
-    $selected = 0;
-
     $key_list = array_keys($config);
 
+    // In the future we may persist which panel was selected.
+    // At the moment we have always selected the first one.
+    $selected = (string)head($key_list);
+
     $next_keys = array();
     $prev_keys = array();
     for ($ii = 0; $ii < count($key_list); $ii++) {
@@ -111,7 +113,7 @@ final class PhabricatorDashboardTabsPanelType
         $name = pht('Unnamed Tab');
       }
 
-      $is_selected = (string)$idx === (string)$selected;
+      $is_selected = (string)$idx === $selected;
 
       $tab_view = id(new PHUIListItemView())
         ->setHref('#')
@@ -282,7 +284,7 @@ final class PhabricatorDashboardTabsPanelType
         $panel_content = pht('(Invalid Panel)');
       }
 
-      $is_selected = (string)$idx === (string)$selected;
+      $is_selected = (string)$idx === $selected;
 
       $content_id = celerity_generate_unique_node_id();

I'm blindly proposing that upstream

valerio.bozzolan added a comment.Oct 12 2023, 1:40 PM

https://we.phorge.it/D25447

valerio.bozzolan added a comment.Oct 16 2023, 7:04 AM

Just to report that we received review upstream and they landed the change (indeed not already promoted in the release candidate).

Feel free to cherry-pick this one to give useful feedback, before the release candidate:

https://we.phorge.it/rP2d635fb76e9b20cce53ed68fe1dfd4daa79aa8c2

valerio.bozzolan moved this task from Reported Upstream to Patch merged upstream on the Upstream board.Oct 16 2023, 7:04 AM
valerio.bozzolan moved this task from Upstreamed to Solved upstream on the Phabricator (Upstream) board.

(You may really want a trigger on the "Phabricator (upstream)" column to automatically set the "Solved upstream" Tag)

CodeReviewBot added a project: Patch-For-Review.Oct 16 2023, 7:03 PM

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/20

Revert " Add temporary debug output for T344835"

CodeReviewBot added a comment.Oct 16 2023, 8:42 PM

brennen merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/20

Revert " Add temporary debug output for T344835"

brennen mentioned this in rPHDEPfa9edfe2b211: update phabricator for temporary debugging.Oct 28 2023, 10:19 AM
Dzahn subscribed.EditedNov 2 2023, 4:05 PM

Are we expecting the upstream fix to be deployed at WMF (in the next window? later?).

Aklapper added a comment.Nov 3 2023, 11:20 AM

In general at some point when we pull and deploy a new upstream version

Keyacom subscribed.Nov 19 2023, 2:17 PM
valerio.bozzolan added a comment.Jan 30 2024, 3:36 PM

This change is now in branch stable and under tag 2023.49:

https://we.phorge.it/D25447

Maybe time to try an update soon

brennen mentioned this in T358610: Update wmf/stable to Phorge upstream's 2023.49 stable release.Feb 27 2024, 7:15 PM
valerio.bozzolan added a subtask: T358610: Update wmf/stable to Phorge upstream's 2023.49 stable release.Feb 28 2024, 1:45 PM
valerio.bozzolan closed this task as Resolved.Mar 21 2024, 3:17 PM
valerio.bozzolan claimed this task.
valerio.bozzolan updated Other Assignee, added: brennen.

Uh! Nice homepage! This means the patch is online and worked \o/ https://we.phorge.it/D25447

Thanks @brennen for the upgrade

stjn awarded a token.Mar 21 2024, 4:33 PM
Aklapper closed subtask T358610: Update wmf/stable to Phorge upstream's 2023.49 stable release as Resolved.Mar 21 2024, 8:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits