Page MenuHomePhabricator
Create Task
Maniphest T347931

Move code to mark page for translation from PageTranslationSpecialPage to a service
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

The logic to mark translatable pages for translation lives in the PageTranslationSpecialPage. This makes it difficult for it to be used from elsewhere such as a command line script or API.

Move this code to a separate service.

Details

Other Assignee
Tacsipacsi
SubjectRepoBranchLines +/-
Create TranslatablePageMarker servicemediawiki/extensions/Translatemaster+882 -431
TranslatablePageMarker: Some more tweaksmediawiki/extensions/Translatemaster+53 -37
Add tests for TranslatablePageMarkermediawiki/extensions/Translatemaster+209 -0
Introduce TranslatablePageSettingsmediawiki/extensions/Translatemaster+94 -77
TranslatablePageStore: Move title cache invalidation into storemediawiki/extensions/Translatemaster+1 -1
TranslatablePageMarker: Refactor method to save section markersmediawiki/extensions/Translatemaster+28 -29
TranslatablePageMarker: Move method to handle priority languagesmediawiki/extensions/Translatemaster+44 -40
TranslatablePageMarker: Move method to mark page for translationmediawiki/extensions/Translatemaster+188 -155
TranslatablePageMarkOperation: Add priority language informationmediawiki/extensions/Translatemaster+102 -50
TranslatablePageMarker: Extract code to a add log entry methodmediawiki/extensions/Translatemaster+35 -22
TranslatablePageMarker: Add method to identify translation unitsmediawiki/extensions/Translatemaster+146 -105
TranslatablePageMarker: Move method to validate unit namesmediawiki/extensions/Translatemaster+127 -92
Introduce TranslatablePageMarkOperationmediawiki/extensions/Translatemaster+90 -20
Add TranslatablePageMarker servicemediawiki/extensions/Translatemaster+103 -50
TranslatablePageMarker: Move prepareTranslationUnits to servicemediawiki/extensions/Translatemaster+53 -55
TransaltablePageMarker: Move validateUnitIds to servicemediawiki/extensions/Translatemaster+69 -72
Add service TranslatablePageMarkermediawiki/extensions/Translatemaster+272 -221
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Oct 3 2023, 6:48 AM
gerritbot added a comment.Oct 3 2023, 6:48 AM

Change 960183 had a related patch set uploaded (by Abijeet Patro; author: Tacsipacsi):

[mediawiki/extensions/Translate@master] Create TranslatablePageMarker service

https://gerrit.wikimedia.org/r/960183

gerritbot added a project: Patch-For-Review.Oct 3 2023, 6:48 AM
gerritbot added a comment.Oct 3 2023, 10:18 AM

Change 963017 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add service TranslatablePageMarker

https://gerrit.wikimedia.org/r/963017

gerritbot added a comment.Oct 9 2023, 7:19 AM

Change 964413 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TransaltablePageMarker: Move validateUnitIds to service

https://gerrit.wikimedia.org/r/964413

gerritbot added a comment.Oct 9 2023, 7:19 AM

Change 964414 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Move prepareTranslationUnits to service

https://gerrit.wikimedia.org/r/964414

gerritbot added a comment.Oct 9 2023, 9:34 AM

Change 964423 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add TranslatablePageMarker service

https://gerrit.wikimedia.org/r/964423

gerritbot added a comment.Oct 9 2023, 9:50 AM

Change 963017 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] Add service TranslatablePageMarker

Reason:

Went in the wrong direction.

https://gerrit.wikimedia.org/r/963017

gerritbot added a comment.Oct 9 2023, 9:53 AM

Change 964413 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] TransaltablePageMarker: Move validateUnitIds to service

Reason:

Went in the wrong direction.

https://gerrit.wikimedia.org/r/964413

gerritbot added a comment.Oct 9 2023, 9:53 AM

Change 964414 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Move prepareTranslationUnits to service

Reason:

Went in the wrong direction.

https://gerrit.wikimedia.org/r/964414

Nikerabbit assigned this task to abi_.Oct 10 2023, 10:52 AM
Nikerabbit set the point value for this task to 8.
Nikerabbit added projects: Language-Team (Language-2023-October-December), Localization Infrastructure FY2023-24.
Nikerabbit updated Other Assignee, added: Tacsipacsi.
gerritbot added a comment.Oct 10 2023, 11:04 AM

Change 964884 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Introduce TranslatablePageMarkOperation

https://gerrit.wikimedia.org/r/964884

Nikerabbit changed the task status from Open to In Progress.Oct 10 2023, 11:17 AM
Nikerabbit triaged this task as Low priority.
Nikerabbit moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2023-October-December) board.
Nikerabbit moved this task from Backlog to Translatable pages (LH1) on the Localization Infrastructure FY2023-24 board.Oct 10 2023, 11:21 AM
Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Oct 10 2023, 11:35 AM
gerritbot added a comment.Oct 10 2023, 2:33 PM

Change 964922 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarkOperation: Add method to identify translation units

https://gerrit.wikimedia.org/r/964922

gerritbot added a comment.Oct 10 2023, 7:12 PM

Change 964967 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarkOperation: Move method to validate unit names

https://gerrit.wikimedia.org/r/964967

gerritbot added a comment.Oct 13 2023, 10:54 AM

Change 965710 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarkOperation: Add priority language information

https://gerrit.wikimedia.org/r/965710

gerritbot added a comment.Oct 13 2023, 1:32 PM

Change 965738 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Move method to handle priority languages

https://gerrit.wikimedia.org/r/965738

gerritbot added a comment.Oct 14 2023, 3:24 PM

Change 965859 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Move method to mark page for translation

https://gerrit.wikimedia.org/r/965859

gerritbot added a comment.Oct 14 2023, 4:38 PM

Change 965864 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Extract code to a add log entry method

https://gerrit.wikimedia.org/r/965864

gerritbot added a comment.Oct 16 2023, 8:51 AM

Change 966128 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Refactor method to save section markers

https://gerrit.wikimedia.org/r/966128

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2023-October-December) board.Oct 16 2023, 1:02 PM
gerritbot added a comment.Oct 26 2023, 10:01 AM

Change 969072 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageStore: Move title cache invalidation into store

https://gerrit.wikimedia.org/r/969072

gerritbot added a comment.Oct 31 2023, 12:59 PM

Change 964423 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add TranslatablePageMarker service

https://gerrit.wikimedia.org/r/964423

gerritbot added a comment.Oct 31 2023, 1:18 PM

Change 964884 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Introduce TranslatablePageMarkOperation

https://gerrit.wikimedia.org/r/964884

gerritbot added a comment.Oct 31 2023, 2:18 PM

Change 964922 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Add method to identify translation units

https://gerrit.wikimedia.org/r/964922

gerritbot added a comment.Oct 31 2023, 2:18 PM

Change 964967 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Move method to validate unit names

https://gerrit.wikimedia.org/r/964967

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Oct 31 2023, 3:00 PM
gerritbot added a comment.Nov 1 2023, 7:35 AM

Change 970651 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Introduce TranslatablePageSettings

https://gerrit.wikimedia.org/r/970651

gerritbot added a comment.Nov 1 2023, 7:47 AM

Change 965864 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Extract code to a add log entry method

Reason:

Makes code more difficult to follow.

https://gerrit.wikimedia.org/r/965864

gerritbot added a comment.Nov 2 2023, 7:01 AM

Change 965710 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageMarkOperation: Add priority language information

https://gerrit.wikimedia.org/r/965710

gerritbot added a comment.Nov 2 2023, 7:03 AM

Change 965738 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Move method to handle priority languages

https://gerrit.wikimedia.org/r/965738

gerritbot added a comment.Nov 2 2023, 7:04 AM

Change 965859 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Move method to mark page for translation

https://gerrit.wikimedia.org/r/965859

gerritbot added a comment.Nov 2 2023, 7:37 AM

Change 970911 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add tests for TranslatablePageMarker

https://gerrit.wikimedia.org/r/970911

gerritbot added a comment.Nov 2 2023, 10:10 AM

Change 966128 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Refactor method to save section markers

https://gerrit.wikimedia.org/r/966128

gerritbot added a comment.Nov 2 2023, 10:11 AM

Change 969072 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageStore: Move title cache invalidation into store

https://gerrit.wikimedia.org/r/969072

gerritbot added a comment.Nov 2 2023, 1:51 PM

Change 971193 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Some more tweaks

https://gerrit.wikimedia.org/r/971193

gerritbot added a comment.Nov 7 2023, 11:50 AM

Change 970651 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Introduce TranslatablePageSettings

https://gerrit.wikimedia.org/r/970651

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.5; 2023-11-14); removed MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Nov 7 2023, 1:00 PM
gerritbot added a comment.Nov 7 2023, 1:14 PM

Change 970911 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add tests for TranslatablePageMarker

https://gerrit.wikimedia.org/r/970911

gerritbot added a comment.Nov 7 2023, 1:14 PM

Change 971193 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageMarker: Some more tweaks

https://gerrit.wikimedia.org/r/971193

abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2023-October-December) board.Nov 7 2023, 1:15 PM
abi_ added a comment.Nov 9 2023, 10:22 AM

The refactored code has been deployed on translatewiki.net. I tested by marking a page for translation with priority languages, and various other options. It appears to work as expected.

Thanks to @Tacsipacsi for initiating work on this.

Leaving it open until the patches ride the train next week.

abi_ mentioned this in T351273: Revisions for unit markers addition are not longer autopatrolled.Nov 15 2023, 6:55 AM
abi_ added a subtask: T351273: Revisions for unit markers addition are not longer autopatrolled.
Pginer-WMF added a parent task: T351374: Improve Translatable Pages based on research input.Nov 16 2023, 9:36 AM
abi_ closed subtask T351273: Revisions for unit markers addition are not longer autopatrolled as Resolved.Nov 17 2023, 3:27 AM
abi_ closed this task as Resolved.Nov 17 2023, 1:49 PM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2023-October-December) board.

There was one issue identified as part of this refactoring which has been fixed. Now marking this as resolved.

gerritbot added a comment.Dec 13 2023, 9:19 AM

Change 960183 abandoned by Nikerabbit:

[mediawiki/extensions/Translate@master] Create TranslatablePageMarker service

Reason:

https://gerrit.wikimedia.org/r/960183

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2023, 9:30 AM
Tacsipacsi merged a task: T40964: Refactor page translation code.Feb 2 2024, 10:01 PM
Tacsipacsi added a parent task: T235397: Add API module to "mark a page for translation".
Tacsipacsi added subscribers: Nikerabbit, Pols12, siebrand.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL