Page MenuHomePhabricator
Create Task
Maniphest T348253

Create MediaWiki\ParserOutputTransform\DefaultOutputTransform
Closed, ResolvedPublic
Actions

Description

See https://www.mediawiki.org/wiki/Parsoid/OutputTransform for a discussion. This is step 2 of the "Initial Proposal":

Hollow out ParserOutput::getText() so that all it does is:

return MediaWiki\ParserOutputTransform\DefaultOutputTransform::transform($this, $options)->getHtmlHolder()->getText();

Details

SubjectRepoBranchLines +/-
Refactor DefaultOutputTransform into a pipeline of transformsmediawiki/coremaster+1 K -765
Return a copy of the ParserOutput rather than mutating itmediawiki/coremaster+25 -41
Rename PostCacheTransformHookRunnermediawiki/coremaster+12 -12
Extract EDITSECTION_REGEX and renderDebugInfo to DefaultOutputTransformmediawiki/coremaster+100 -96
Refactor ParserOutput::getText into DefaultOutputTransform servicemediawiki/coremaster+559 -163
Extract methods in DefaultOutputTransformmediawiki/coremaster+162 -91
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Oct 5 2023, 1:54 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 5 2023, 1:54 PM
cscott added a parent task: T348255: Parser cache infrastructure for OutputTransform.Oct 5 2023, 2:02 PM
cscott added a subtask: T348254: Add ParserOutput::getHtmlHolder().Oct 5 2023, 2:07 PM
cscott updated the task description. (Show Details)
ihurbain claimed this task.Oct 10 2023, 2:36 PM

(reassigned to myself 'cuz i have a patch almost ready on drive)

ihurbain moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Oct 10 2023, 2:37 PM
gerritbot added a comment.Oct 10 2023, 4:27 PM

Change 964948 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Refactor ParserOutput::getText into DefaultOutputTransform

https://gerrit.wikimedia.org/r/964948

gerritbot added a project: Patch-For-Review.Oct 10 2023, 4:27 PM
gerritbot added a comment.Oct 12 2023, 1:22 PM

Change 965513 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Extract methods in DefaultOutputTransform

https://gerrit.wikimedia.org/r/965513

MSantos moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Oct 12 2023, 2:43 PM
ihurbain added a subtask: T348853: Deprecate null skin on DefaultOutputTransform.Oct 13 2023, 12:07 PM
cscott moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.Oct 16 2023, 3:17 PM
gerritbot added a comment.Oct 16 2023, 5:22 PM

Change 964948 merged by jenkins-bot:

[mediawiki/core@master] Refactor ParserOutput::getText into DefaultOutputTransform service

https://gerrit.wikimedia.org/r/964948

gerritbot added a comment.Oct 16 2023, 5:33 PM

Change 965513 merged by jenkins-bot:

[mediawiki/core@master] Extract methods in DefaultOutputTransform

https://gerrit.wikimedia.org/r/965513

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 16 2023, 6:00 PM
gerritbot added a comment.Oct 17 2023, 11:48 AM

Change 966518 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Extract EDITSECTION_REGEX and renderDebugInfo to DefaultOutputTransform

https://gerrit.wikimedia.org/r/966518

gerritbot added a comment.Oct 19 2023, 1:27 PM

Change 967216 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Return a copy of the ParserOutput rather than mutating it

https://gerrit.wikimedia.org/r/967216

gerritbot added a comment.Oct 20 2023, 1:24 PM

Change 967449 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Refactor DefaulteOutputTransform into a pipeline of transforms

https://gerrit.wikimedia.org/r/967449

gerritbot added a comment.Nov 8 2023, 4:30 PM

Change 966518 merged by jenkins-bot:

[mediawiki/core@master] Extract EDITSECTION_REGEX and renderDebugInfo to DefaultOutputTransform

https://gerrit.wikimedia.org/r/966518

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.5; 2023-11-14); removed MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Nov 8 2023, 5:00 PM
• ssastry moved this task from Backlog to Code Review on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.Dec 6 2023, 10:12 PM
gerritbot added a comment.Dec 8 2023, 11:43 PM

Change 967449 merged by jenkins-bot:

[mediawiki/core@master] Refactor DefaultOutputTransform into a pipeline of transforms

https://gerrit.wikimedia.org/r/967449

ihurbain closed this task as Resolved.Dec 18 2023, 4:12 PM
gerritbot added a comment.Jan 4 2024, 2:05 PM

Change 987775 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Rename PostCacheTransformHookRunner and fix namespaces in tests

https://gerrit.wikimedia.org/r/987775

gerritbot added a comment.Feb 7 2024, 6:48 PM

Change 987775 merged by jenkins-bot:

[mediawiki/core@master] Rename PostCacheTransformHookRunner

https://gerrit.wikimedia.org/r/987775

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.18; 2024-02-13); removed MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Feb 7 2024, 10:01 PM
gerritbot added a comment.Feb 15 2024, 10:31 AM

Change 967216 abandoned by Isabelle Hurbain-Palatin:

[mediawiki/core@master] Return a copy of the ParserOutput rather than mutating it

Reason:

In favor of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/982424 that has more granularity

https://gerrit.wikimedia.org/r/967216

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits