Change 968650 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] mw.notify: Limit width of overlay to max-width-page-container

https://gerrit.wikimedia.org/r/968650

Demo: https://patchdemo.wmflabs.org/wikis/fd311f2936/wiki/Talk:DiscussionTools#Where_to_post_SQL_requests

(If you have arrived here from an on-wiki comment about AddThis gadget, the link should've pointed here: T230124)

@JScherer-WMF does the proposal in the task description (see also demo link) look good to you?

In T349622#9288596, @Jdlrobson wrote:

@JScherer-WMF does the proposal in the task description (see also demo link) look good to you?

Looks good! Thanks.

Change 968650 merged by jenkins-bot:

[mediawiki/skins/Vector@master] mw.notify: Limit width of overlay to max-width-page-container

https://gerrit.wikimedia.org/r/968650

I like this change, it makes sense and looks good. But: The placement is a bit awkward when you use Vector-2022 in full-screen mode . Could that be taken into account?

In T349622#9341533, @Jdlrobson wrote:

@Esanders it looks like your patch to https://gerrit.wikimedia.org/r/c/968650 didn't work as expected (see comment from @jhsoby and @Edtadros )
@ovasileva not sure if this constitutes a regression in your perspective. Should we revert the patch or do you see this as an overall improvement?

If possible, I'd say let's revert until we can get it to look slightly better. I agree that the current positioning feels a bit awkward. @JScherer-WMF - wondering what you think as well.

In T349622#9341573, @ovasileva wrote:

In T349622#9341533, @Jdlrobson wrote:

@Esanders it looks like your patch to https://gerrit.wikimedia.org/r/c/968650 didn't work as expected (see comment from @jhsoby and @Edtadros )
@ovasileva not sure if this constitutes a regression in your perspective. Should we revert the patch or do you see this as an overall improvement?

If possible, I'd say let's revert until we can get it to look slightly better. I agree that the current positioning feels a bit awkward. @JScherer-WMF - wondering what you think as well.

I agree. Sorry I didn't have a closer look at various viewport widths with the initial query. Thanks for flagging it @jhsoby !

Somewhere above the title probably makes more sense, but just for due diligence, could someone outline the steps a user has to complete to get this notification?

No worries, these things happen. :-)

The easiest way to trigger a notification via the normal UI is probably to make an edit, and it should notify you that the edit was saved successfully. But if you're testing its appearance, it would probably be even easier to just enter mw.notify( 'Random text here' ); in the browser console. :-)

Change 975042 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/skins/Vector@master] Revert "mw.notify: Limit width of overlay to max-width-page-container"

https://gerrit.wikimedia.org/r/975042

Change 975042 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revert "mw.notify: Limit width of overlay to max-width-page-container"

https://gerrit.wikimedia.org/r/975042

Change 975366 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.42.0-wmf.5] Revert "mw.notify: Limit width of overlay to max-width-page-container"

https://gerrit.wikimedia.org/r/975366

@Jdrewniak When you're finished reverting this, please assign to me, and I'll work out a design that doesn't break at smaller viewports.

Change 975366 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.42.0-wmf.5] Revert "mw.notify: Limit width of overlay to max-width-page-container"

https://gerrit.wikimedia.org/r/975366

Mentioned in SAL (#wikimedia-operations) [2023-11-20T21:58:00Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:975366|Revert "mw.notify: Limit width of overlay to max-width-page-container" (T349622)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-20T21:59:22Z] <catrope@deploy2002> jdlrobson and catrope: Backport for [[gerrit:975366|Revert "mw.notify: Limit width of overlay to max-width-page-container" (T349622)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-20T22:15:41Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:975366|Revert "mw.notify: Limit width of overlay to max-width-page-container" (T349622)]] (duration: 17m 40s)

Presumably just limiting the patch to fixed width Vector 2022, and leaving as-is in other situations, would be fine (an improvement on the status quo)?

Change 977617 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Reapply "mw.notify: Limit width of overlay to max-width-page-container"

https://gerrit.wikimedia.org/r/977617

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/51c3e7d64a/wiki/Talk:DiscussionTools#c-notfound

@JScherer-WMF what do you think of the behaviour in https://patchdemo.wmflabs.org/wikis/51c3e7d64a/wiki/Talk:DiscussionTools#c-notfound ?

@JScherer-WMF will comment on the ticket today and create a new ticket around usability problems with the notification widget.

I think the patch solves the initial bug, even though it's not ideal for the notification to overlap the content below it.

Change 977617 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Reapply "mw.notify: Limit width of overlay to max-width-page-container"

https://gerrit.wikimedia.org/r/977617

This looks like the correct behaviour. I needed to zoom out on my MBP to make my screen "wide enough" to demo this. Thanks for checking @Edtadros .

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/51c3e7d64a/w/