Page MenuHomePhabricator

Figure out how Parsoid will work with MCR slots to support both reading and editing clients
Open, Needs TriagePublic

Description

While addressing T332931: Read views HTML and Edit views HTML for a page should come from the same ParserCache entry, we broke visual editing for pages with multiple MCR slots (see T351026: VisualEditor adding nonsense code to file pages ).

To address T351026, we are currently deploying a hack where we always return the 'main' slot output for Parsoid HTML requests. This will however now break Parsoid read view for these pages since we will only be returning the main slot output.

We should figure out a strategy (internal and external API fixes) that lets editing and reading clients get the appropriate output for pages that have multiple MCR slots filled up.

Event Timeline

Change 973823 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] Parsoid-VE-MCR hack: Always return main slot output if useParsoid is set

https://gerrit.wikimedia.org/r/973823

Change 973797 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@wmf/1.42.0-wmf.4] Parsoid-VE-MCR hack: Always return main slot output if useParsoid is set

https://gerrit.wikimedia.org/r/973797

Change 973823 merged by jenkins-bot:

[mediawiki/core@master] Parsoid-VE-MCR hack: Always return main slot output if useParsoid is set

https://gerrit.wikimedia.org/r/973823

Change 973797 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.4] Parsoid-VE-MCR hack: Always return main slot output if useParsoid is set

https://gerrit.wikimedia.org/r/973797

Mentioned in SAL (#wikimedia-operations) [2023-11-13T21:35:59Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:969401|mobile: Add MobileUrlCallback (T257852)]], [[gerrit:973797|Parsoid-VE-MCR hack: Always return main slot output if useParsoid is set (T351026 T351113)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-13T21:37:17Z] <urbanecm@deploy2002> urbanecm and ssastry and tgr: Backport for [[gerrit:969401|mobile: Add MobileUrlCallback (T257852)]], [[gerrit:973797|Parsoid-VE-MCR hack: Always return main slot output if useParsoid is set (T351026 T351113)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-13T21:54:33Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:969401|mobile: Add MobileUrlCallback (T257852)]], [[gerrit:973797|Parsoid-VE-MCR hack: Always return main slot output if useParsoid is set (T351026 T351113)]] (duration: 18m 34s)