Page MenuHomePhabricator

Citoid: Move 'insert' button to inspector header when only one result is presented
Closed, ResolvedPublic

Event Timeline

See also T173437 which suggests removing the 'Insert' step entirely.

Change 989795 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/Citoid@master] VE: Move 'Insert' button to header when only one result shown

https://gerrit.wikimedia.org/r/989795

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/97c4358d77/w

Change 989795 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] VE: Move 'Insert' button to header when only one result shown

https://gerrit.wikimedia.org/r/989795

EAkinloose subscribed.

✅The button is placed as expected

Screenshot 2024-02-22 at 00.14.25.png (622×1 px, 94 KB)

However, the title remains "Add a citation". This doesn't align with the figma design and the proposed solution in the description of the task. @Esanders , checking that this is expected.

I'd be inclined to just leave the heading as-is -- "insert the citation" sounds awkward.

Hello @Esanders,
For Tech News - What wording would you suggest as the content, and can it be included in the recent Tech news in the "Changes later this week" section?

I'm not sure this needs a tech news announcement, but if you want:
Usability improvements to the "Add a citation" workflow: Moved the "Insert" button to the popup header.

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/97c4358d77/w/