Page MenuHomePhabricator
Create Task
Maniphest T355377

Update MediaWiki Platform team owned products for IP masking
Open, Needs TriagePublic
Actions

Description

IP Masking will affect lots of our products, features, tools, gadgets, etc. This task is for tracking work to update those that are owned by MediaWiki-Platform-Team, ahead of IP Masking being enabled on WMF sites.

See T326816: Update features for temporary accounts, particularly What will be affected.

Per the maintainers page:

Details

SubjectRepoBranchLines +/-
Disable global user script/style module for temp usersmediawiki/extensions/GlobalCssJsmaster+3 -1
resourceloader: Do not load user scripts/styles for temp usersmediawiki/coremaster+4 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tgr created this task.Jan 19 2024, 12:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2024, 12:32 AM
Tgr added a comment.Jan 19 2024, 12:34 AM

(AHT created these tasks for each team in the summer, e.g. https://phabricator.wikimedia.org/T326880, but MW Platform didn't sufficiently exist back then and wasn't included, so making one now.)

Tgr added a parent task: T326816: Update features for temporary accounts.Jan 19 2024, 12:34 AM
Tgr added a subtask: T355378: Prepare OAuth extension for IP Masking.Jan 19 2024, 12:39 AM
Tgr updated the task description. (Show Details)
Tgr added a subscriber: Krinkle.Jan 19 2024, 12:44 AM

@Krinkle any thoughts about ResourceLoader (the UserModule and UserOptionsModule, specifically)?

The only thing I can think of is whether we might want to disallow user CSS/JS for temp users just to make life simpler.

Tgr added subtasks: T326937: Prepare CentralAuth extension for IP Masking, T326925: Prepare OATHAuth and WebAuthn extensions for IP Masking.Jan 19 2024, 12:44 AM
larissagaulia subscribed.Jan 19 2024, 10:51 AM
larissagaulia moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.Jan 22 2024, 4:14 PM
Tgr closed subtask T326925: Prepare OATHAuth and WebAuthn extensions for IP Masking as Resolved.Jan 26 2024, 3:43 AM
Krinkle added a comment.Feb 7 2024, 2:07 PM
In T355377#9471455, @Tgr wrote:

@Krinkle any thoughts about ResourceLoader (the UserModule and UserOptionsModule, specifically)?

The only thing I can think of is whether we might want to disallow user CSS/JS for temp users just to make life simpler.

Indeed, in frontend code and RL specifically, I think we should treat temps as anons.

kostajh added subscribers: Tchanders, kostajh.Feb 7 2024, 2:16 PM
In T355377#9471455, @Tgr wrote:

The only thing I can think of is whether we might want to disallow user CSS/JS for temp users just to make life simpler.

That makes sense to me. cc @Tchanders

Tchanders added a comment.Feb 7 2024, 5:43 PM
In T355377#9521034, @kostajh wrote:
In T355377#9471455, @Tgr wrote:

The only thing I can think of is whether we might want to disallow user CSS/JS for temp users just to make life simpler.

That makes sense to me. cc @Tchanders

I agree. We don't have a need to provide these features for temp accounts.

Tgr closed subtask T355378: Prepare OAuth extension for IP Masking as Resolved.Feb 21 2024, 6:29 PM
gerritbot added a comment.Feb 29 2024, 1:49 PM

Change 1007615 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] resourceloader: Do not load user scripts/styles for temp users

https://gerrit.wikimedia.org/r/1007615

gerritbot added a project: Patch-For-Review.Feb 29 2024, 1:49 PM
gerritbot added a comment.Mar 1 2024, 1:56 AM

Change 1007615 merged by jenkins-bot:

[mediawiki/core@master] resourceloader: Do not load user scripts/styles for temp users

https://gerrit.wikimedia.org/r/1007615

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 1 2024, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2024, 2:30 AM
gerritbot added a comment.Mar 11 2024, 11:01 PM

Change 1008507 had a related patch set uploaded (by Krinkle; author: 沈澄心):

[mediawiki/extensions/GlobalCssJs@master] Disable global user script/style module for temp users

https://gerrit.wikimedia.org/r/1008507

gerritbot added a project: Patch-For-Review.Mar 11 2024, 11:01 PM
gerritbot added a comment.Mar 11 2024, 11:24 PM

Change 1008507 merged by jenkins-bot:

[mediawiki/extensions/GlobalCssJs@master] Disable global user script/style module for temp users

https://gerrit.wikimedia.org/r/1008507

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2024, 11:30 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.22; 2024-03-12); removed MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 12 2024, 1:00 AM
Tgr updated the task description. (Show Details)Apr 8 2024, 2:42 PM
Tchanders moved this task from Backlog to Needs Other Product Teams on the Temporary accounts board.Tue, Jun 4, 3:17 PM
larissagaulia moved this task from Current Sprint to Radar on the MediaWiki-Platform-Team board.Tue, Jun 25, 3:30 PM
larissagaulia edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL