Page MenuHomePhabricator

Temp account creations do not appear in Special:Log
Closed, ResolvedPublic1 Estimated Story Points

Description

There are at least three issues:

  • Making an edit as an anonymous user on a wiki with temp accounts enabled, there is no entry in Special:Log show the temp account creation
  • Once you are logged-in as a temp account user, and you navigate to another wiki with temp accounts enabled, there is no log entry in Special:Log showing the temp account creation on the second wiki
  • The "Type of account creation" menu should have an entry for temp accounts

image.png (548×1 px, 76 KB)

Event Timeline

kostajh renamed this task from Temp accounts don't appear consistently in Special:Log to Non-autocreated temp accounts creations do not appear in Special:Log.Feb 14 2024, 9:04 AM
Tgr added subscribers: Bugreporter, Tgr.

Are you planning to work on this? Or do you want someone else to work on it? (AuthManager is owned by MediaWiki Platform, temporary users are owned by AHT and the account creation experience is owned by Growth so the ownership of tasks like this one is a bit unclear.)

a user account created by a temp account ( 15:40, 12 February 2024 User account Drw1234 talk contribs was created by ~2024-600 talk contribs)

As @Bugreporter pointed out on the other task, this is a privacy leak (or would be if the feature were in production).

Looking at https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Logbuch?type=newusers&user=&page=&wpdate=&tagfilter=&wpfilters[]=newusers&wpFormIdentifier=logeventslist&uselang=en, I would expect to see the temp account I created.

Instead, I only see:

  • an autocreated temp account (21:17, 12 February 2024 User account *Unregistered 35214 talk contribs was created automatically )

This part seems to be working as expected. Or is that a different temp account?

Looking at https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Logbuch?type=newusers&user=&page=&wpdate=&tagfilter=&wpfilters[]=newusers&wpFormIdentifier=logeventslist&uselang=en, I would expect to see the temp account I created.

Instead, I only see:

  • an autocreated temp account (21:17, 12 February 2024 User account *Unregistered 35214 talk contribs was created automatically )

This part seems to be working as expected. Or is that a different temp account?

That part (autocreated temp account) does work as expected.

Are you planning to work on this? Or do you want someone else to work on it? (AuthManager is owned by MediaWiki Platform, temporary users are owned by AHT and the account creation experience is owned by Growth so the ownership of tasks like this one is a bit unclear.)

a user account created by a temp account ( 15:40, 12 February 2024 User account Drw1234 talk contribs was created by ~2024-600 talk contribs)

As @Bugreporter pointed out on the other task, this is a privacy leak (or would be if the feature were in production).

If you want to work on it, we'd welcome your support (cc @Tchanders).

@kostajh @Tgr I believe this is covered by this Growth-Team task: T328718

Do not show the unregistered account that created the new account in Special:Log&page=&tagfilter=&type=newusers

@RHo Have I got that right?

kostajh renamed this task from Non-autocreated temp accounts creations do not appear in Special:Log to Temp account creations do not appear in Special:Log.Jun 20 2024, 11:38 AM
kostajh updated the task description. (Show Details)

On the beta wikis, there is a entry showing the temporary account on wikis other than that used to make the first edit. For example, when I make an edit on cswiki and then open dewiki there is a log entry as follows:

image.png (29×626 px, 5 KB)

The "Type of account creation" menu should have an entry for temp accounts

@kostajh I am not sure what the need for a separate option in this dropdown menu, and which of the logs should go there.

I ask this because, as shown in T357498#9926151 if a user logged in to a temporary account visits a different wiki then this appears in the Automatic creation list. As such, some of these logs are already in that section and so would deliberately need to be moved.

My suggestion would be to keep all temporary account creation logs in the Automatic creation section, considering that the banner describes a temporary account will be created for you which suggests to me that this is an automated process separate to the user making an edit.

On the beta wikis, there is a entry showing the temporary account on wikis other than that used to make the first edit. For example, when I make an edit on cswiki and then open dewiki there is a log entry as follows:

image.png (29×626 px, 5 KB)

This is what we call CentralAuth (SUL) autocreation. Autocreation has multiple meanings, this is one, creating a temporary account on first edit may be one, and another kind is autocreation via external auth extension (such as what Wikitech currently does).

On the beta wikis, there is a entry showing the temporary account on wikis other than that used to make the first edit. For example, when I make an edit on cswiki and then open dewiki there is a log entry as follows:

image.png (29×626 px, 5 KB)

This is what we call CentralAuth (SUL) autocreation. Autocreation has multiple meanings, this is one, creating a temporary account on first edit may be one, and another kind is autocreation via external auth extension (such as what Wikitech currently does).

Sure. I think maybe at some point this log did not work for temporary accounts based on the task description, but it is at least now working.

For the time being I will reject the idea of creating a separate dropdown option for temporary account creations, and instead ensure they are visible when selecting the Automatic creation menu option (or also the All option).

Change #1049923 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Create a autocreate log when a temporary account is created on edit

https://gerrit.wikimedia.org/r/1049923

Dreamy_Jazz set the point value for this task to 1.Jun 26 2024, 1:19 PM

Suggested QA steps for when this is QA'd which can be tested via patch demo, beta wikis, or local wiki:

  1. If using patch demo, make sure to enable temporary accounts on the wiki
  2. Create a temporary account by making an edit while logged out, noting down the username
  3. Open Special:Log and filter for User creation log logs
  4. Verify that the log with the text User account <temporary account username> was created automatically is present, where the <temporary account username> is the username from step 2
  5. Use the Type of account creation: dropdown menu and select Automatic creation, then press Submit
  6. Verify that the log checked in step 4 still appears in the logs list

The "Type of account creation" menu should have an entry for temp accounts

@kostajh I am not sure what the need for a separate option in this dropdown menu, and which of the logs should go there.

I had in mind that it would be nice to have a separate listing of temporary account creations, in case someone wanted to see only those (and not all autocreations, which could include named users). But you can use the prefix search in Special:Log easily to get a listing of accounts starting with e.g. ~202 so that will work fine, if someone wants to see just temporary account autocreations.

Change #1049923 merged by jenkins-bot:

[mediawiki/core@master] Create an autocreate log when a temporary account is created on edit

https://gerrit.wikimedia.org/r/1049923

Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected.

image.png (834×1 px, 218 KB)

image.png (774×1 px, 156 KB)