Clean up block_target migration code
Closed, ResolvedPublic
Actions

Description

Now that $wgBlockTargetMigrationStage is set to SCHEMA_COMPAT_NEW on WMF wikis, we can remove the relevant schema-independent migration code and unconditionally use the new schema.

Details

Subject	Repo	Branch	Lines +/-
Stop using $wgBlockTargetMigrationStage	mediawiki/extensions/PageTriage	master	+10 -27
Stop using $wgBlockTargetMigrationStage	mediawiki/extensions/GrowthExperiments	master	+15 -48
block: Deprecate and stop using $wgBlockTargetMigrationStage	mediawiki/core	master	+573 -1 K

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T204903 Epic ⚡️ unprioritized Partial Blocks features
Open	BUG REPORT	None	T25310 Global suppression does not work properly when the target has already been locally blocked
Open		None	T366388 Multiblocks: Edit and Remove a block
Open		None	T349689 Admins should be able to edit an active block without needing to delete it first
Open		None	T194697 Multiblocks — Allow for multiple, simultaneous blocks with different expiration dates
Resolved	Aug 21 2018	dbarratt	T201692 Prepare a technical plan for Multi-blocks
Declined		None	T202572 Create Migration Plan from current schema to Multi-block schema
Open		None	T202673 RFC: Multiblocks - let admins create multiple, overlapping blocks on a single user
Resolved		tstarling	T345683 Review of MediaWiki block-related code
Resolved		tstarling	T346293 ipblocks schema redesign for multiblocks
Resolved		tstarling	T362133 Clean up block_target migration code
Resolved		tstarling	T349883 Multiblocks support in ApiBlockInfoTrait and ApiQueryBlockInfoTrait
Open		None	T351508 Decide the limit of multiblocks
Open		None	T351511 How to deal with redundant block

Event Timeline

tstarling created this task.Apr 9 2024, 3:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2024, 3:06 AM

Change #1023166 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] block: Deprecate and stop using $wgBlockTargetMigrationStage

https://gerrit.wikimedia.org/r/1023166

gerritbot added a project: Patch-For-Review.Apr 23 2024, 6:11 AM

tstarling moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Apr 30 2024, 2:06 AM

Change #1023166 merged by jenkins-bot:

[mediawiki/core@master] block: Deprecate and stop using $wgBlockTargetMigrationStage

https://gerrit.wikimedia.org/r/1023166

Maintenance_bot removed a project: Patch-For-Review.May 11 2024, 1:31 AM

JWheeler-WMF triaged this task as High priority.May 17 2024, 5:01 PM

JWheeler-WMF moved this task from Backlog to In Development on the Multiblocks board.May 23 2024, 9:14 PM

Some usages of $wgBlockTargetMigrationStage remain in WMF-maintained extensions.

tstarling moved this task from Review/Feedback 💬 to Ready 🎬 on the Community-Tech (CommTech-Kanban) board.May 29 2024, 10:19 AM

JWheeler-WMF edited projects, added Community-Tech (June 3-14 2024 Arctic Fox); removed Community-Tech (CommTech-Kanban).Jun 3 2024, 6:57 PM

Restricted Application edited projects, added Community-Tech; removed Community-Tech (June 3-14 2024 Arctic Fox). · View Herald TranscriptJun 3 2024, 6:57 PM

JWheeler-WMF moved this task from New & TBD Tickets to June 3-14 2024 Arctic Fox on the Community-Tech board.Jun 3 2024, 8:59 PM

JWheeler-WMF edited projects, added Community-Tech (June 3-14 2024 Arctic Fox); removed Community-Tech.

JWheeler-WMF edited projects, added Community-Tech (June 17-28 2024 Bat-Eared Fox); removed Community-Tech (June 3-14 2024 Arctic Fox).Jun 17 2024, 2:08 PM

Change #1046796 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/GrowthExperiments@master] Stop using $wgBlockTargetMigrationStage

https://gerrit.wikimedia.org/r/1046796

gerritbot added a project: Patch-For-Review.Jun 17 2024, 11:48 PM

Change #1046798 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/PageTriage@master] Stop using $wgBlockTargetMigrationStage

https://gerrit.wikimedia.org/r/1046798

tstarling moved this task from Ready for dev to Feedback and review on the Community-Tech (June 17-28 2024 Bat-Eared Fox) board.Jun 18 2024, 12:30 AM

Change #1046796 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Stop using $wgBlockTargetMigrationStage

https://gerrit.wikimedia.org/r/1046796

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 18 2024, 9:00 AM

Change #1046798 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Stop using $wgBlockTargetMigrationStage

https://gerrit.wikimedia.org/r/1046798

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2024, 11:30 PM

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.12; 2024-07-02); removed MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 26 2024, 12:00 AM

MusikAnimal edited projects, added Community-Tech (July 1-12 2024 (Corsac Fox)); removed Community-Tech (June 17-28 2024 Bat-Eared Fox).Jul 1 2024, 9:37 PM

MusikAnimal moved this task from Ready for dev to Feedback and review on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.

@tstarling this task has been in review since June 17. I wanted to confirm if it still needs review. Is there a specific person you need feedback from?

JWheeler-WMF edited projects, added Community-Tech (Darwin's Fox (July 15-26, 2024)); removed Community-Tech (July 1-12 2024 (Corsac Fox)).Jul 15 2024, 3:34 PM

JWheeler-WMF moved this task from Backlog to Feedback and review on the Community-Tech (Darwin's Fox (July 15-26, 2024)) board.

JWheeler-WMF edited projects, added Community-Tech (Ezo Red Fox (July 29 - Aug 9, 2024)); removed Community-Tech (Darwin's Fox (July 15-26, 2024)).Jul 30 2024, 1:52 AM

JWheeler-WMF moved this task from Ready for dev to Goals and epics on the Community-Tech (Ezo Red Fox (July 29 - Aug 9, 2024)) board.

MusikAnimal moved this task from Goals and epics to In development on the Community-Tech (Ezo Red Fox (July 29 - Aug 9, 2024)) board.Jul 30 2024, 1:53 AM

MusikAnimal edited projects, added Community-Tech (Fennec Fox (Aug 12-23, 2024)); removed Community-Tech (Ezo Red Fox (July 29 - Aug 9, 2024)).Aug 12 2024, 9:05 PM

MusikAnimal moved this task from Ready for dev to In development on the Community-Tech (Fennec Fox (Aug 12-23, 2024)) board.

JWheeler-WMF edited projects, added Community-Tech (Gray Fox (Aug 26 - Sept 6)); removed Community-Tech (Fennec Fox (Aug 12-23, 2024)).Aug 26 2024, 3:23 PM

JWheeler-WMF moved this task from Ready for dev to In development on the Community-Tech (Gray Fox (Aug 26 - Sept 6)) board.

MusikAnimal edited projects, added Community-Tech (Island Fox (Sept 9 - 20)); removed Community-Tech (Gray Fox (Aug 26 - Sept 6)).Sep 9 2024, 6:18 PM

MusikAnimal moved this task from Ready for dev to In development on the Community-Tech (Island Fox (Sept 9 - 20)) board.

JWheeler-WMF moved this task from In development to Done on the Community-Tech (Island Fox (Sept 9 - 20)) board.Sep 10 2024, 1:35 AM