Page MenuHomePhabricator

Vector 2022 talk page tab is a blue link even if the talk doesn't exist, should be a red link (but it turns red when clicked)
Closed, ResolvedPublic

Assigned To
Authored By
matmarex
Wed, Jun 19, 2:42 PM
Referenced Files
F56336429: 2024-07-10_10-53-21.mp4.gif
Wed, Jul 10, 6:01 PM
F56336542: 2024-07-10_10-57-05.mp4.gif
Wed, Jul 10, 6:01 PM
F56181096: 2024-07-02_13-50-48.png
Tue, Jul 2, 8:57 PM
F56181094: 2024-07-02_13-50-00.png
Tue, Jul 2, 8:57 PM
F56181080: 2024-07-02_13-51-52.png
Tue, Jul 2, 8:57 PM
F56181074: 2024-07-02_13-52-08.png
Tue, Jul 2, 8:57 PM
F55470908: image.png
Wed, Jun 19, 2:42 PM
F55470821: image.png
Wed, Jun 19, 2:42 PM
Tokens
"The World Burns" token, awarded by Sjoerddebruin.

Description

Vector 2022 talk page tab is a blue link even if the talk doesn't exist, should be a red link (but it turns red when clicked).

Steps to reproduce:

  1. Visit a page that doesn't have a talk page in a private/incognito window, e.g. https://www.mediawiki.org/wiki/MediaWiki_Platform_Team
  2. Observe a blue "Discussion" link
    image.png (2×3 px, 1 MB)

When using a non-private/incognito window, the link turns red after clicking it and returning to the original page. This isn't a part of the bug, I'm just mentioning it because it makes reproducing the issue tricky.

image.png (2×3 px, 1 MB)

QA Results - Beta

ACStatusDetails
1T367982#9947229

QA Results - PROD

ACStatusDetails
1T367982#9970776

Event Timeline

I've noticed this a couple of times in Timeless, too, so it's not limited to Vector.

I've noticed this a couple of times in Timeless, too, so it's not limited to Vector.

I can't reproduce the problem on Timeless. Can you share more details about where you see that, and a screenshot?

The problem is present in MediaWiki 1.43/wmf.11 as well. I noticed the problem in de.Wikipedia, where it present for vector-2022, but not for vector-2010 or timeless:
https://de.wikipedia.org/wiki/Wladyslaw_Buchow?useskin=vector-2022
https://de.wikipedia.org/wiki/Wladyslaw_Buchow?useskin=vector
https://de.wikipedia.org/wiki/Wladyslaw_Buchow?useskin=timesless

Any idea when this regression would be fixed? I keep hearing people complaining about this issue on other platforms.

Change #1051183 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] The "new" class should be added to the link as well as the LI element

https://gerrit.wikimedia.org/r/1051183

Change #1051183 merged by jenkins-bot:

[mediawiki/core@master] The "new" class should be added to the link as well as the LI element

https://gerrit.wikimedia.org/r/1051183

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Visit a page that doesn't have a talk page in a private/incognito window, e.g. https://www.mediawiki.org/wiki/Development_statistics
  2. Observe a blue "Discussion" link
Incognito-BlueNon-Incognito-Blue
2024-07-02_13-52-08.png (471×3 px, 142 KB)
2024-07-02_13-51-52.png (494×3 px, 147 KB)
  1. When using a non-private/incognito window, the link turns red after clicking it and returning to the original page. This isn't a part of the bug, I'm just mentioning it because it makes reproducing the issue tricky. e.g. https://www.mediawiki.org/wiki/Analytics/Archive/Logging_infrastructure/status
Incognito-RedNon-Incognito-Red
2024-07-02_13-50-00.png (637×3 px, 207 KB)
2024-07-02_13-50-48.png (476×3 px, 186 KB)
GMikesell-WMF assigned this task to ovasileva.
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF subscribed.

Adding User-notice since there was significant interest in this bug (judging by the number of subscribers).

@Jdlrobson Please review below. Are the colors supposed to be opposite to the "Discussion" link?

UPDATE: per T367982#9971037

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Visit a page that doesn't have a talk page in a private/incognito window, e.g. https://www.mediawiki.org/wiki/Zest
  2. Observe a blue "Discussion" link
✅ Incognito-Blue
2024-07-10_10-57-05.mp4.gif (470×2 px, 416 KB)
  1. When using a non-private/incognito window, the link turns red after clicking it and returning to the original page. This isn't a part of the bug, I'm just mentioning it because it makes reproducing the issue tricky. e.g. https://www.mediawiki.org/wiki/BlueSpice
✅ Non-Incognito-Red
2024-07-10_10-53-21.mp4.gif (464×1 px, 454 KB)

Observe a blue "Discussion" link

This is a pass. Blue is the fail state. Red is the pass state.

When using a non-private/incognito window, the link turns red after clicking it and returning to the original page

I'm not sure I understand - I dont' see any red in the gif? It looks like it is working as expected here? What am I missing?

The bug was about a bluelink for non-existing talk pages, so https://www.mediawiki.org/wiki/BlueSpice is not a correct example, because the talk page exists.

To my knowledge the bug has been fixed. The talk page link is blue for existing talk pages and red for non-existing ones.

@Jdlrobson @Kallichore Everything makes sense on what you said, I was just going based on the description. I will move this to Pass.

Observe a blue "Discussion" link

This is a pass. Blue is the fail state. Red is the pass state.

I was going what the description said to reproduce

  1. Visit a page that doesn't have a talk page in a private/incognito window, e.g. https://www.mediawiki.org/wiki/MediaWiki_Platform_Team
  2. Observe a blue "Discussion" link

It says to observe a blue "Discussion" link so I was looking for a Blue.

When using a non-private/incognito window, the link turns red after clicking it and returning to the original page

I'm not sure I understand - I dont' see any red in the gif? It looks like it is working as expected here? What am I missing?

As for this one, it says it's looking for a red link but it didn't say also find one that doesn't have a talk page like the first one, so I assumed I was looking for one that did.

As for this one, it says it's looking for a red link but it didn't say also find one that doesn't have a talk page like the first one, so I assumed I was looking for one that did.

Got it! Thanks! This task didn't use the bug template so I can see why it was confusing! Sorry about that!