Page MenuHomePhabricator

[VISUAL CHANGE] Visited links are not accessible in dark mode
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Overview:
We have slightly changed some of the link colors to improve accessibility. Specifically:

  • The hover state of links has changed from #36c to #447FF5.
  • The active state of links has changed from #FAA700 to #2A4B8D
  • The visited color of links has changed from #795CB2 to #6B4BA1
NOTE: this change also changes hover and active states for links in desktop site standard theme.

Old task description:

Steps to replicate the issue (include links if applicable):

  • Go to any page in dark mode on Vector.
  • Click a link
  • Go back to the source page and inspect the computed colour.

What happens?:

Visited links are #795cb2

Screenshot 2024-06-03 at 11.55.37 AM.png (274×988 px, 56 KB)

What should have happened instead?:
They should be #977DBD

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Weirdly, it looks like the variable is right but this is being overwritten for some reason.

Screenshot 2024-06-03 at 11.47.25 AM.png (312×592 px, 84 KB)

QA Results - Beta

ACStatusDetails
1T366515#9904658

Event Timeline

This is true of Minerva, too, it seems T357988.

Jdlrobson subscribed.

It looks like Vector 2022 defines various link colors inside resources/mediawiki.less/vector-2022/mediawiki.skin.variables.less
https://github.com/wikimedia/mediawiki-skins-Vector/blob/master/resources/mediawiki.less/vector-2022/mediawiki.skin.variables.less#L39

These do not appear to be defined in Codex but are defined in mediawiki.skin.defaults.less
In Vector 2022 we use color-progressive for the link color?
What should we use for visited and active colors? https://doc.wikimedia.org/codex/latest/design-tokens/color.html has no guidance...

It looks like Vector 2022 defines various link colors inside resources/mediawiki.less/vector-2022/mediawiki.skin.variables.less
https://github.com/wikimedia/mediawiki-skins-Vector/blob/master/resources/mediawiki.less/vector-2022/mediawiki.skin.variables.less#L39

These do not appear to be defined in Codex but are defined in mediawiki.skin.defaults.less
In Vector 2022 we use color-progressive for the link color?
What should we use for visited and active colors? https://doc.wikimedia.org/codex/latest/design-tokens/color.html has no guidance...

Thanks, Jon. This an example of variables that are ready but haven't made it into Codex yet. cc @CCiufo-WMF @DTorsani-WMF

Here are the dark mode link colours:
progressive: #6D8AF2
progressive-hover: #AFB6E9
progressive-active: #C2D1F0
progressive-focus: #3366CC
destructive: #FF4242
destructive-hover: #EF8174
destructive-active: #F8A397
visited: #977DBD
destructive-visited: #B97876
disabled: #72777D

Change #1039774 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Define visited color in dark theme

https://gerrit.wikimedia.org/r/1039774

Jdlrobson added a subscriber: ovasileva.

@ovasileva this is a blocker for the roll out next week. Can we estimate this and swap it out for the low priority 2 pointer in Ready for dev?

ovasileva set the point value for this task to 1.Jun 13 2024, 5:15 PM
bwang removed bwang as the assignee of this task.Jun 14 2024, 6:45 PM
bwang subscribed.

Change #1039774 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use codex link styles in Vector, remove old link color variables

https://gerrit.wikimedia.org/r/1039774

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

✅ AC1: background colors should disappear when compared with

  1. Go to any page in dark mode on Vector.
  2. Click a link (ex. https://en.wikipedia.beta.wmflabs.org/wiki/Polar_bear)
  3. Go back to the source page and inspect the computed colour.

2024-06-18_11-25-23.mp4.gif (962×1 px, 2 MB)

Jdlrobson renamed this task from Visited links are not accessible in dark mode to [VISUAL CHANGE] Visited links are not accessible in dark mode.Tue, Jun 18, 7:25 PM
Jdlrobson assigned this task to ovasileva.
Jdlrobson updated the task description. (Show Details)

Please note associated visual changes and please create a user notice "heads up" if you think this merits one.

No need for user notice given change is only for dark mode. Looks good on beta cluster!

We have slightly changed some of the link colors to improve accessibility. Specifically:

  • The hover state of links has changed from #36c to #447FF5.
  • The active state of links has changed from #FAA700 to #2A4B8D
  • The visited color of links has changed from #795CB2 to #6B4BA1

Please confirm if this is an accurate and suitable draft for Tech News, or if anything needs to be changed or added. (e.g. Are there any links to add to the text, or perhaps an example before/after image for the top of the Description here). It will be frozen for translation in ~24hours:

The colors used for visited-links, hovered-links, and active links, was slightly changed last week to improve their accessibility.

Confirmed with @Quiddity. Resolving this one.