Dark Mode: Suggested Edits & Structured Tasks
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	KStoller-WMF
	Jul 9 2024, 3:55 AM

Description

Background

The Web team is releasing dark mode more widely. To prepare for this, some Growth maintained features need improvements.

User story

As a new editor who uses dark mode, I want the ability to use dark mode on the newcomer homepage and when completing Suggested Edits, so that I do not have an inconsistent experience

Suggested Edits & Structured Tasks

✅ DONE add link - the highlighted word is not visible		`wmf.24`
✅ DONE add image - "View image details" contrast issue	compare with Light mode:	`cswiki beta`
✅ DONE add image - the dismiss button (X button) in Media viewer contrast issue		`cswiki beta`
✅ DONE homepage on mobile Minerva - the suggested edits module		`cswiki beta`
✅ DONE post-edit dialog displays light text on light background

Acceptance Criteria:

Given I'm Completing a Suggested Edit or Structured Task,
When I'm viewing in dark mode,
Then all elements are readable and pass WCAG AA contrast requirements

Details

Subject	Repo	Branch	Lines +/-
fix(StructuredTask/addimage): update colors to fix contrast issues	mediawiki/extensions/GrowthExperiments	master	+4 -2
FiltersDialog/MobileOverlay: remove unnecessary notheme skin-invert classes	mediawiki/extensions/GrowthExperiments	master	+2 -4
fix(Homepage.styles): use Codex color for module background in mobile summary	mediawiki/extensions/GrowthExperiments	master	+2 -3
DarkMode: Fix close button icon to be visible in dark mode	mediawiki/extensions/GrowthExperiments	master	+6 -1
DarkMode: Fix "View image details" contrast issue	mediawiki/extensions/GrowthExperiments	master	+1 -1
Dark Mode: Suggested Edits & Structured Tasks	mediawiki/extensions/GrowthExperiments	master	+1 -1
fix(styles): darkmode: make add a link suggestions readable	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved		ovasileva	T341632 [EPIC] Palette customizations and dark mode
Open		None	T366760 [EPIC] Dark mode for Growth team maintained features
Resolved		Etonkovidova	T367058 QA Growth-related OOUI updates (mobile + desktop)
Resolved		Cyndymediawiksim	T369588 Dark Mode: Suggested Edits & Structured Tasks
Resolved	BUG REPORT	Sgs	T371146 Structured Tasks: structured tasks onboarding elements not readable in Dark Mode
Resolved		JFernandez-WMF	T371901 Provide Add a link on-boarding assets without embedded background colors
Resolved	BUG REPORT	Sgs	T371564 Suggested Edits: unstructured tasks onboarding elements not readable in Dark Mode
Duplicate		Sgs	T378592 Contrast issues in StartEditing and SuggestedEdits modules

Event Timeline

KStoller-WMF created this task.Jul 9 2024, 3:55 AM

KStoller-WMF triaged this task as High priority.Jul 9 2024, 4:08 AM

KStoller-WMF moved this task from Inbox to Up Next on the Growth-Team board.

Jdlrobson moved this task from Backlog to Web (MediaWiki) on the dark-mode board.Jul 11 2024, 7:56 PM

Etonkovidova attached a referenced file: F55632764: Screen Shot 2024-06-22 at 4.30.30 PM.png. (Show Details)Jul 16 2024, 6:49 PM

Etonkovidova attached a referenced file: F55632673: Screen Shot 2024-06-22 at 4.30.14 PM.png. (Show Details)

Etonkovidova attached a referenced file: F55632449: Screen Shot 2024-06-22 at 4.27.09 PM.png. (Show Details)

Etonkovidova updated the task description. (Show Details)Jul 16 2024, 6:56 PM

A note that @JScherer-WMF brought up: the "Try a Suggested Edit" panel also displays light on light:

KStoller-WMF updated the task description. (Show Details)Jul 22 2024, 10:36 PM

KStoller-WMF updated the task description. (Show Details)Jul 22 2024, 10:38 PM

Breaking this task into subtasks:
T371146: Structured Tasks: structured tasks onboarding elements not readable in Dark Mode

KStoller-WMF moved this task from Up Next to Needs Discussion on the Growth-Team board.Jul 31 2024, 2:25 PM

Change #1066877 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(styles): darkmode: make add a link suggestions readable

https://gerrit.wikimedia.org/r/1066877

gerritbot added a project: Patch-For-Review.Aug 26 2024, 8:39 PM

Change #1066877 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(styles): darkmode: make add a link suggestions readable

https://gerrit.wikimedia.org/r/1066877

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Aug 28 2024, 10:00 AM

KStoller-WMF mentioned this in T372064: Issues with Growth home page experience in dark mode.Sep 13 2024, 10:05 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 13 2024, 10:30 PM

KStoller-WMF moved this task from Needs Discussion to Up Next on the Growth-Team board.Sep 18 2024, 8:57 PM

Etonkovidova closed subtask T371564: Suggested Edits: unstructured tasks onboarding elements not readable in Dark Mode as Resolved.Sep 20 2024, 12:23 AM

Etonkovidova closed subtask T371146: Structured Tasks: structured tasks onboarding elements not readable in Dark Mode as Resolved.Sep 23 2024, 10:46 PM

Etonkovidova updated the task description. (Show Details)Oct 1 2024, 7:32 PM

Sgs moved this task from Up Next to Backlog on the Growth-Team board.Oct 15 2024, 3:56 PM

Sgs moved this task from Backlog to Up Next on the Growth-Team board.Nov 12 2024, 3:25 PM

KStoller-WMF set the point value for this task to 2.Nov 12 2024, 5:10 PM

KStoller-WMF moved this task from Up Next to Current Sprint on the Growth-Team board.Nov 12 2024, 5:58 PM

KStoller-WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.

Change #1093357 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Dark Mode: Suggested Edits & Structured Tasks

https://gerrit.wikimedia.org/r/1093357

gerritbot added a project: Patch-For-Review.Nov 20 2024, 2:53 PM

Cyndymediawiksim subscribed.Nov 20 2024, 2:58 PM

Change #1093357 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Dark Mode: Suggested Edits & Structured Tasks

https://gerrit.wikimedia.org/r/1093357

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Nov 22 2024, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2024, 5:30 PM

Cyndymediawiksim updated the task description. (Show Details)Nov 25 2024, 9:09 AM

Cyndymediawiksim claimed this task.Nov 25 2024, 9:42 AM

Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.

Change #1097379 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] DarkMode: Fix "View image details" contrast issue

https://gerrit.wikimedia.org/r/1097379

gerritbot added a project: Patch-For-Review.Nov 25 2024, 1:37 PM

Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Nov 25 2024, 4:40 PM

Change #1098496 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] fix: Ensure close button icon is visible in dark mode

https://gerrit.wikimedia.org/r/1098496

Change #1097379 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] DarkMode: Fix "View image details" contrast issue

https://gerrit.wikimedia.org/r/1097379

Change #1100148 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(StructuredTask/addimage): update colors to fix contrast issues

https://gerrit.wikimedia.org/r/1100148

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.8; 2024-12-17); removed MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Tue, Dec 3, 5:00 PM

Change #1098496 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] DarkMode: Fix close button icon to be visible in dark mode

https://gerrit.wikimedia.org/r/1098496

Sgs updated the task description. (Show Details)Tue, Dec 3, 6:59 PM

Change #1100183 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(Homepage.styles): use Codex color for module background in mobile summary

https://gerrit.wikimedia.org/r/1100183

Change #1100184 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] FiltersDialog/MobileOverlay: remove unnecessary notheme skin-invert classes

https://gerrit.wikimedia.org/r/1100184

Change #1100183 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(Homepage.styles): use Codex color for module background in mobile summary

https://gerrit.wikimedia.org/r/1100183

Change #1100184 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] FiltersDialog/MobileOverlay: remove unnecessary notheme skin-invert classes

https://gerrit.wikimedia.org/r/1100184

Change #1100148 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(StructuredTask/addimage): update colors to fix contrast issues

https://gerrit.wikimedia.org/r/1100148

Maintenance_bot removed a project: Patch-For-Review.Mon, Dec 9, 2:31 PM

Sgs moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Wed, Dec 11, 5:19 PM

Checked in beta with WCAG Contrast checker - no contrast issues are found; added screenshots to the task description and marked all items there as Done.

KStoller-WMF awarded a token.Wed, Dec 11, 11:45 PM

	F57800271: Screen Shot 2024-12-11 at 11.04.15 AM.png
	Wed, Dec 11, 7:07 PM

	F57800265: Screen Shot 2024-12-11 at 10.59.39 AM.png
	Wed, Dec 11, 7:07 PM

	F57800261: Screen Shot 2024-12-11 at 10.55.27 AM.png
	Wed, Dec 11, 7:07 PM

	F57775813: Screenshot 2024-12-03 at 19.57.15.png
	Tue, Dec 3, 6:59 PM

	F57579257: Screen Shot 2024-10-01 at 12.26.30 PM.png
	Oct 1 2024, 7:32 PM

	F56466130: Screen Shot 2024-07-15 at 3.05.35 PM.png
	Jul 16 2024, 6:56 PM

	F56601867: image.png
	Jul 22 2024, 6:57 PM

Dark Mode: Suggested Edits & Structured TasksClosed, ResolvedPublic2 Estimated Story PointsActions