Page MenuHomePhabricator

Align the styles and interactive states of Progressive and Destructive elements to be consistent, accessible, and uniform
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

The refined, expanded color palette is meant to find more consistent alignment and uniformity across values and hues, as mentioned in T360494. For example, all text which uses color other than gray should be the 700 value in light mode and the 400 value in dark mode. From here, in light mode the hover and active states should then become darker values, and in dark mode they should become lighter. This ensures sufficient color contrast on all potential backgrounds in both modes. Since the same values across hues have even brightness and saturation, this system also finds more visual alignment with different colors displayed in similar ways.

An example of this would be the interactive colors, which for text, currently use blue700 for progressive then blue600 for progressive--hover then blue900 for progressive--active and red600 for destructive then red500 for destructive--hover then red800 for destructive--active. This means that the brightness and saturation of these application tokens, while applied to similar elements of different intents, come across visually different.

Goal

Revisit interactive application tokens to find more numerical/visual alignment, which will result in more visually aligned color applications, along with improving accessibility across all states. Some interactive tokens may need to be added to achieve similar styles as defined in T377977.

This scope includes elements which use progressive and destructive interactive tokens such as Buttons, Links, and binary inputs.

Expected changes

Application.json

Token namenew, update, or remove?beforeafteradditional notes
color-progressive--hoverupdateblue600blue800
color-destructive--hoverupdatered500red800
color-destructive--activeupdatered800red900
color-visited--hovernew-purple800
color-visited--activenew-purple900
color-destructive--visited--hovernew-maroon800
color-destructive--visited--activenew-maroon900
background-color-progressive--hoverupdateblue600blue800
background-color-destructive--hoverupdatered500red800
background-color-destructive--activeupdatered800red900
border-color-progressive--hoverupdateblue600blue800
border-color-destructive--hoverupdatered500red800
border-color-destructive--activeupdatered800red900

Components.json

Token namenew, update, or remove?beforeafteradditional notes
link-red--visited--hovernew-color.destructive--visited--hover
link-red--visited--activenew-color.destructive--visited--active

Dark.json

Token namenew, update, or remove?beforeafteradditional notes
color-visited--hovernew-purple300
color-visited--activenew-purple200
color-destructive--visited--hovernew-maroon300
color-destructive--visited--activenew-maroon200

Acceptance criteria

  • Make updates to tokens and styles in code
  • Make updates to tokens and styles in Figma

Event Timeline

DTorsani-WMF renamed this task from Align the values in interactive tokens to be consistent with each other to Align the styles and interactive states of Buttons and Links to be consistent, accessible, and uniform.Mon, Oct 28, 7:19 PM
DTorsani-WMF claimed this task.
DTorsani-WMF updated the task description. (Show Details)
DTorsani-WMF set the point value for this task to 1.

Change #1084151 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Add new tokens for more interactive link styles

https://gerrit.wikimedia.org/r/1084151

Change #1084191 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Adjust hover and active states for progresive and destructive

https://gerrit.wikimedia.org/r/1084191

DTorsani-WMF raised the priority of this task from Low to Needs Triage.Tue, Oct 29, 6:34 PM
DTorsani-WMF updated the task description. (Show Details)

Stylistic updates to quiet and normal buttons will be included in T303384.

DTorsani-WMF renamed this task from Align the styles and interactive states of Buttons and Links to be consistent, accessible, and uniform to Align the styles and interactive states of Progressive and Destructive to be consistent, accessible, and uniform.Tue, Oct 29, 6:50 PM
DTorsani-WMF updated the task description. (Show Details)
DTorsani-WMF updated the task description. (Show Details)
CCiufo-WMF renamed this task from Align the styles and interactive states of Progressive and Destructive to be consistent, accessible, and uniform to Align the styles and interactive states of Progressive and Destructive elements to be consistent, accessible, and uniform.Tue, Oct 29, 7:04 PM

Change #1084151 merged by jenkins-bot:

[design/codex@main] tokens: Add new tokens for more interactive link styles

https://gerrit.wikimedia.org/r/1084151

Change #1084191 merged by jenkins-bot:

[design/codex@main] tokens: Adjust hover and active states for progressive and destructive

https://gerrit.wikimedia.org/r/1084191

Change #1090947 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v1.15.0 to v1.16.0

https://gerrit.wikimedia.org/r/1090947

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/a2a0917c1b/w/

Change #1090947 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.15.0 to v1.16.0

https://gerrit.wikimedia.org/r/1090947

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/a2a0917c1b/w/