Page MenuHomePhabricator

Hiding file upload log entry should also hide the contents of the "Summary" box on file pages
Open, LowPublic

Description

The default behaviour of many of our upload tools, scripts, and the UploadWizard is to insert the data from the upload process into the upload log description entry -- for example, see a random file uploaded with UploadWizard https://commons.wikimedia.org/w/index.php?title=Special:Log&page=File%3AWiki+Loves+Monuments+2011+calendar+%28design+file%29.pdf.

However, hiding the upload log entry containing inappropriate information does not completely remove the data from the wiki, for it is still visible in the "Summary" box visible on the file description page -- in this example, here https://commons.wikimedia.org/wiki/File:Wiki_Loves_Monuments_2011_calendar_%28design_file%29.pdf#filehistory.

To remove the data from the box, one needs to re-upload a file again, and suppress the edit summary -- please have a look at a real life example at https://commons.wikimedia.org/wiki/File:DuchyofFlorence1548.png.

As both the edit summary and the upload log entry contain the very same data, it would be nice to have the ability to hide the edit summary while hiding the upload entry log (and the other way round).


Version: unspecified
Severity: minor

Details

Reference
bz36497

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:21 AM
bzimport set Reference to bz36497.
bzimport added a subscriber: Unknown Object (MLST).
tomasz created this task.May 3 2012, 8:48 PM
aaron added a comment.May 4 2012, 2:23 AM

You don't have to re-upload, just make a new edit and suppress the old one.

I just tested the bug on testwiki per request from Odder, it appears indeed that revision deletion / suppression of the edit summary has no effects on the "summary" box, which in practice leaks the suppressed info. See https://test.wikipedia.org/wiki/File:Vietato.svg -

Aaron, unless I'm misunderstanding something here, making a new edit doesn't fix it, because it's the file log, not the edits on the page.

aaron added a comment.May 15 2012, 8:33 AM

(In reply to comment #3)

Aaron, unless I'm misunderstanding something here, making a new edit doesn't
fix it, because it's the file log, not the edits on the page.

You mean the "file history" (image+oldimage table)? Yes, that would require reverting to an old version or a dummy upload (if there was none), since you can't hide anything in the current versions. I don't recall why that is, since regular page "revision history" does not have this limitation (the only limitation is that you can't hide the text, just the user/comment).

Probably the file code could be refactored to allow hiding the img_description field/user by itself.

tomasz added a comment.Nov 3 2012, 9:34 PM

This is just to mention that the current behaviour is seriously annoying when dealing with mass suppression requests, because one needs to (1) re-upload every single file that leaks certain information and then (2) suppress the contents of the "Summary" box.

I've had to do this ever since becoming an oversighter on Commons, and can tell that it considerably slows down the whole suppression process.

As the "Summary" box contains the very same data that is visible in the description of the upload log, not having to suppress/rev-delete it on its own would be highly appreciated, and especially time-saving.

Scott added a comment.Jan 31 2013, 1:20 PM

Additionally, the file history table is visible on file description pages on any given Wikipedia. This means that even if someone has performed a Wikimedia-wide rename for privacy purposes, such file summaries will leak private information outside of Commons in multiple locations. I'm changing this bug from "Enhancement" to "Normal" for that reason; this issue needs to be addressed.

pierre-selim.huard wrote:

As a fresh oversighter, I can tell you that this bug is already a nightmare for me.

As a product owner myself, I know this kind of bugs can get stuck in the backlog however it is quite essential for privacy protection (I already have a list of 46 files to upload one by one ...).

Thank you for reading my plea ^_^

Marking as schema change. image table doesn't have img_deleted.

pierre-selim.huard wrote:

Is there any plan in fixing this bug and making oversighter life a little less hard ?

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2015, 4:58 PM
tomasz removed a subscriber: tomasz.Mar 18 2016, 5:58 PM
Restricted Application added a subscriber: JEumerus. · View Herald TranscriptMar 18 2016, 5:58 PM

Have over 100 files to re-upload to suppress personal information in the original version, however, I cannot re-upload due to the duplication warning that cannot be bypassed.