Page MenuHomePhabricator

Evaluate which resource loader modules really need position => top
Closed, ResolvedPublic


Evaluate which resource loader modules really need position => top and remove it from others.

Version: unspecified
Severity: normal
Whiteboard: code-quality
See Also:



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:26 AM
bzimport set Reference to bz47075.

I assume this was meant for ULS, hence correcting component.

Added Roan and Timo on CC. Just in case they are interested.

The evaluation was done and implemented in November.

If someone actually did this, I am not aware of it.

Are there any notes from this available, or any commits made as a result?

This is the only blocker currently left for bug 56292, can it be prioritised?

Santhosh, can you please explain how you made the decisions about this?

This is bit old, anyway, there were lot of refactoring around the RL modules of ULS. I am listing a set of bug reports and patches, that addressed this in direct and indirect way. The commit message and bug report discussions will provide history

The main idea was to keep only RLs with position top that affects the page flicker if not top loaded- mainly the ones that affect the page rendering. Following are the top loaded modules in master code right now:

  1. ext.uls.nojs
  2. ext.uls.init
  3. ext.uls.inteface

Closing the bug, assuming details given above are sufficient.