Page MenuHomePhabricator
Create Task
Maniphest T55479

Notification emails should embed icons as data URIs
Closed, DeclinedPublic
Actions

Description

The 'talk' icon in Echo talk-page notification emails is loaded via HTTP:

<img src="http://bits.wikimedia.org/static-1.22wmf13/extensions/Echo/modules/icons/Talk.png" alt="" height="30" width="30"></td>

Because the image is loaded remotely, many mail readers (including Gmail) won't show it by default, and it'll trigger a prompt to display remote images which must be clicked on before you can see the icon.

I would recommend embedding the icons as data URIs if possible, so they don't have to be loaded remotely. (Hopefully this isn't a compat issue...)

Version: unspecified
Severity: normal

Details

Reference
bz53479
SubjectRepoBranchLines +/-
Email: embed icons as data urimediawiki/extensions/Echomaster+143 -69
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:58 AM
• bzimport added a project: Notifications.
• bzimport set Reference to bz53479.
• bzimport added a subscriber: Unknown Object (MLST).
• brion created this task.Aug 28 2013, 2:45 PM
• bzimport added a comment.Sep 4 2013, 6:54 PM

bsitu wrote:

Thanks Brion, that's a good idea, but it looks like Gmail and Hotmail do not support data uri, it shows the text 'inline image' instead of an image

• brion added a comment.Sep 4 2013, 7:07 PM

Dangit!

Is there an alternate way to bundle images with the email, or shall I just close this out as WONTFIX?

• bzimport added a comment.Sep 6 2013, 8:26 PM

bsitu wrote:

We could include the images as attachment, the drawback is that some clients list all of the attached files inside the email, this would give user a bad UI experience. I will see if there is any other alternatives.

• Spage added a comment.Sep 23 2013, 8:47 PM

Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/238

• werdna unsubscribed.Dec 10 2014, 5:14 PM
• Mattflaschen-WMF triaged this task as Low priority.Dec 14 2014, 7:24 AM
• Mattflaschen-WMF subscribed.
Legoktm subscribed.Aug 7 2015, 9:17 PM

Hardcoded HTTP was fixed as T104835: Echo email icons are hardcoded HTTP/rECHOb12efddf3031: Use PROTO_CANONICAL for icon links in emails.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 7 2015, 9:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope added a subtask: T107823: Rewrite EchoNotificationFormatter.Aug 21 2015, 11:09 PM
Catrope closed subtask T107823: Rewrite EchoNotificationFormatter as Resolved.Nov 22 2015, 10:50 PM
Catrope subscribed.Apr 18 2017, 6:37 PM

GMail now does display our notification icons. We did have to use PNGs instead of SVGs to make that happen, but we did that a while ago.

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 28 2018, 1:07 PM
JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Sep 9 2018, 7:47 AM
SBisson changed the subtype of this task from "Task" to "Feature Request".Oct 16 2018, 1:06 PM
SBisson changed the subtype of this task from "Feature Request" to "Task".Oct 16 2018, 6:41 PM
Catrope moved this task from Needs Discussion to Q2 2019-20 on the Growth-Team board.Nov 1 2018, 6:01 PM
Liuxinyu970226 removed a project: Collaboration-Team-Triage.Nov 18 2018, 12:52 PM
Liuxinyu970226 removed a subscriber: • wikibugs-l-list.
Catrope mentioned this in T203507: Remote image loaded in Echo's HTML user talk email notifications.Jan 8 2019, 7:04 AM
JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Feb 5 2019, 6:59 PM
JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a project: Technical-Debt.Feb 13 2019, 5:52 PM
JTannerWMF moved this task from Ready for Development to Incoming on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 13 2019, 5:52 PM
JTannerWMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).Feb 13 2019, 6:28 PM
JTannerWMF moved this task from Q2 2019-20 to Upcoming Work on the Growth-Team board.
JTannerWMF moved this task from Upcoming Work to Sprint 0 (Growth Team) on the Growth-Team board.Mar 20 2019, 6:03 PM
JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 20 2019, 11:34 PM
SBisson claimed this task.Apr 2 2019, 5:12 PM
SBisson moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Apr 5 2019, 5:55 PM

Change 501651 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Echo@master] Email: embed icons as data uri

https://gerrit.wikimedia.org/r/501651

gerritbot added a project: Patch-For-Review.Apr 5 2019, 5:55 PM
SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 5 2019, 5:56 PM
Esanders updated the task description. (Show Details)Apr 9 2019, 12:13 PM
gerritbot added a comment.Apr 10 2019, 6:41 PM

Change 501651 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Email: embed icons as data uri

https://gerrit.wikimedia.org/r/501651

SBisson moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 10 2019, 6:47 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.1; 2019-04-16).Apr 10 2019, 7:00 PM
SBisson merged a task: T203507: Remote image loaded in Echo's HTML user talk email notifications.Apr 16 2019, 2:56 PM
SBisson added a subscriber: Nemo_bis.
SBisson mentioned this in W2269 Echo Tasks.Apr 17 2019, 3:31 PM
SBisson moved this task from QA to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 20 2019, 2:59 PM
SBisson removed projects: MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review.
SBisson closed this task as Declined.May 8 2019, 1:59 PM

We've tried embedding SVGs as data-uri, both in text and base64. The markup is sane and works in browsers but gmail doesn't render them.

We're tried including the actual SVG instead of <img src="..."> and again, the markup is correct but gmail doesn't render it.

I'm going to decline this task because of technical limitations with gmail, which is the most popular email client.

Please re-open if I'm missing something or another idea comes to mind.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL