Page MenuHomePhabricator

Search suggestions misplaced in Vector if there is window overflow (horizontal scrollbar)
Closed, ResolvedPublic

Description

Screenshot

On [[de:Wikipedia:Fragen zur Wikipedia]] in Vector skin (and as far as I can see: only on this page) the search suggestions are misplaced and moved to the left (see screenshot). I have no idea what's going wrong, nor has anyone else yet.


Version: 1.22.0
Severity: normal
URL: https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia

Attached:

Details

Reference
bz54091

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:13 AM
bzimport set Reference to bz54091.
Schnark created this task.Sep 13 2013, 8:03 AM

Experiments suggest that this has something to do with the CSS to move tabs on the right to a second line on small windows ([1]): When I start with a width where they are moved down the suggestions are positioned correctly, even if the tabs are collapsed afterwards to fit in one line again, and even if I increase the width of the window (without reloading).

Some users have this problem on other pages, too. On [2] there is an ongoing discussion (in German) about this bug.

[1] https://git.wikimedia.org/commitdiff/mediawiki%2Fcore.git/3d2abae2d493eee5ada56e8dad3a90b44d9aefd2
[2] https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#Suchvorschl.C3.A4ge_auf_dieser_Seite

This is a side-effect of me fixing bug 20234. I don't see a way to get both bugs fixed simultaneously without somehow completely redoing how Vector tabs work :/

Reading the comments on en's [1] and de's [2] village pumps I think most users prefer the old behaviour (overlapping tabs) anyway.

[1] [[Wikipedia:Village_pump_(technical)#Misplaced_tabs_when_zoomed_in]]
[2] [[de:Wikipedia:Fragen_zur_Wikipedia/Archiv/2013/Woche_34#Merkw.C3.BCrdige_Anzeige_bei_Netbook]]

Now that I see your change to the title: No, the screenshot was taken without resizing the window (just a maximized window on my screen with innerWidth === 1280). On the contrary, resizing the window as described in comment 1 fixes the position of the suggestions (at least for me).

Sorry, I must have misunderstood. Please fix the title so that it's correct (and a little more elaborate than the original one :) ), I don't want to mess something up again.

Created attachment 14101
Screecast of the broken search suggestions

Attached:

Change 130425 had a related patch set uploaded by Gerrit Patch Uploader:
jquery.suggestions.js: Use body width instead of document width

https://gerrit.wikimedia.org/r/130425

  • Bug 64613 has been marked as a duplicate of this bug. ***
  • Bug 65392 has been marked as a duplicate of this bug. ***

Change 130425 merged by jenkins-bot:
jquery.suggestions: Use body width instead of full document width

https://gerrit.wikimedia.org/r/130425