@Aklapper made a patch to fix a Bugzilla XML-RPC API issue that works for comments but breaks attachments. We need to apply it, migrate comments, revert it, and migrate attachments.
When we tried to export some Bugzilla tickets via Bugzilla's XML RPC API we ran into an upstream Bugzilla bug. Certain characters in bug report text comments create invalid XML provided by the API. This breaks our custom script to export data from Bugzilla (to import it into Phabricator later).
That API issue was tracked in https://bugzilla.wikimedia.org/show_bug.cgi?id=69747 . The corresponding (unresolved) upstream ticket is https://bugzilla.mozilla.org/show_bug.cgi?id=839023.
We locally applied the hack described in https://bugzilla.mozilla.org/show_bug.cgi?id=839023#c10 in https://gerrit.wikimedia.org/r/#/c/156100/ . It just drops specific problematic characters/bytes from the output, as a quick'n'dirty workaround.
This worked around the problem for text in Bugzilla comments, but as that Perl hack is applied to any output, the hack also drops those certain bytes from binary attachment content, breaking certain attachments containing this bytes. Hence we reverted that hack in https://gerrit.wikimedia.org/r/#/c/168200/ again.
Somebody with Perl skills (who?) could improve the hack to only drop certain characters from Bugzilla text comment content provided via Bugzilla's XML RPC API, but not to apply that hack on any other content such as attachments.
Original summary of this task:
I swear this worked, maybe that fix put in to strip characters for funky comments caused weirdness here?
the patch indeed caused it. reverted to fix attachments. We need a new patch.