[Story] Allow simultaneous editing of mainsnak and references
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Tobi_WMDE_SW
	Jan 28 2015, 1:12 PM

Referenced Files

	F1910537: pasted_file
	Aug 20 2015, 9:07 AM

	F1910542: pasted_file
	Aug 20 2015, 9:07 AM

	F1910539: pasted_file
	Aug 20 2015, 9:07 AM

Subscribers

View All 9 Subscribers

Description

Use cases

[add] When I am adding a new statement, it should be possible to add an arbitrary number of new references by clicking the "add reference" button. Newly added references get saved when the "save" button for the statement is clicked.
[edit] When I am editing an existing statement, I want to be able to edit all related references as well. All changes made to the references will be saved when the "save" button for the statement is clicked.
[remove] When I am editing an existing statement that has references I want to be able to remove an arbitrary number of existing references from this statement by clicking an "remove" button which is placed in the heading of each reference. Removing individual reference snaks from a particular reference is done by clicking the "remove" button just beside the snak as it is working right now. All changes made to the references will only be saved once the "save" button for the statement is clicked.
[error handling] Changes to the statement will only be saved successful when all data including the references is valid. Otherwise an error is shown just as it works right now for invalid qualifiers or main snaks.

NOTE: Add Reference button should always be visible.

Details

Subject	Repo	Branch	Lines +/-
[DNM] Edit References along with Statement	mediawiki/extensions/Wikibase	master	+153 -57
Make referencesChanger optional in the referenceview widget	mediawiki/extensions/Wikibase	master	+83 -16
Add missing listview dependencies to toolbar controllers	mediawiki/extensions/Wikibase	master	+5 -0
Add combined statementview-referenceview remove toolbar	mediawiki/extensions/Wikibase	master	+106 -0
Include references in statementview.isInitialValue()	mediawiki/extensions/Wikibase	master	+17 -1
Add destroyReferencesListview method to statementview	mediawiki/extensions/Wikibase	master	+14 -0
Declare variables at begin of scope in snaklistview	mediawiki/extensions/Wikibase	master	+19 -14
Add missing fail-safe to counter calculation in statementview	mediawiki/extensions/Wikibase	master	+6 -1
Allow switching to edit mode with "null" references in statementview	mediawiki/extensions/Wikibase	master	+9 -10
Rename wrong private method name in statementview	mediawiki/extensions/Wikibase	master	+2 -2
Fix wrong assumption in statementview	mediawiki/extensions/Wikibase	master	+4 -1
More flexible options handling in referenceview tests	mediawiki/extensions/Wikibase	master	+10 -11
Drop not needed local variable in statementview	mediawiki/extensions/Wikibase	master	+2 -10
Use ReferenceChanger instead of ChangersFactory in statementview	mediawiki/extensions/Wikibase	master	+19 -20
Fix minor bug in referenceview.js	mediawiki/extensions/Wikibase	master	+11 -7
Drop not needed private property in statementview.js	mediawiki/extensions/Wikibase	master	+7 -14

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Open	None	T87316 [Story] Redesign statement section
Invalid	None	T87322 [Story] Section edit mode for statement groups
Resolved	Lydia_Pintscher	T87759 [Story] Allow simultaneous editing of mainsnak and references
Declined	• Jonas	T112652 [RFC] The expander should not be there when editing a statement and it's references. Just remove it. The reference section should not be collapsible.
Invalid	thiemowmde	T112653 [RFC] Possibly, from here it does not make sense to have editReferencesAlongWithStatement for backwards-compatibility
Resolved	adrianheine	T115972 [Bug] Add reference button on new statements does not work
Resolved	adrianheine	T116153 [Task] The referenceview must work with no statement GUID
Resolved	• Jonas	T117558 [Task] Reference section must switch to edit mode when statement switches to edit mode
Resolved	• Jonas	T117668 [Task] Fix references counter for new statements
Resolved	• Jonas	T117675 [Task] Display newly added references when leaving edit mode
Resolved	adrianheine	T117689 [Task] Introduce ViewController for managing edit mode in referenceview
Resolved	adrianheine	T117692 [Task] Introduce remove toolbar for when edit mode is not managed by referenceview
Resolved	• Jonas	T117700 [Task] Block statement saving on invalid (and empty?) reference
Resolved	• Jonas	T117701 [Task] Enable save button on reference change
Resolved	• Jonas	T117702 [Task] Remove referenceview edit mode handling
Resolved	• Jonas	T117963 [Task] When hitting cancel all pending (wb-reference-new) references should be thrown away
Resolved	• Jonas	T92249 [Task] Adjust browsertests for references
Resolved	• Jonas	T118161 [Bug] Remove button on references snak removes whole reference instead of only one snak
Resolved	• Jonas	T118185 [Bug] After removing reference statements save button is still disabled
		· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

JanZerebecki moved this task from Backlog to Doing on the Wikidata-Sprint-2015-08-18 board.Aug 18 2015, 1:26 PM

• Jonas updated the task description. (Show Details)Aug 20 2015, 9:07 AM

Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Aug 20 2015, 9:08 AM

thiemowmde updated the task description. (Show Details)Aug 20 2015, 11:00 AM

thiemowmde edited subscribers, added: • Jonas; removed: gerritbot.

Sjoerddebruin subscribed.Aug 24 2015, 10:41 AM

T108008: Impossible to add reference together with a new statement is related.

thiemowmde moved this task from Doing to Review on the Wikidata-Sprint-2015-08-18 board.Aug 25 2015, 10:01 AM

• Jonas moved this task from Review to Done on the Wikidata-Sprint-2015-08-18 board.Aug 31 2015, 10:13 AM

Lydia_Pintscher moved this task from in progress to consider for next sprint on the Wikidata board.Sep 2 2015, 8:34 AM

Change 224072 merged by jenkins-bot:
Include references in statementview.isInitialValue()

https://gerrit.wikimedia.org/r/224072

Diffusion mentioned this in rMEXT435ac967de90: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 2 2015, 3:00 PM

Addshore mentioned this in rEWBA6febf7507b83: Include references in statementview.isInitialValue().Sep 2 2015, 3:00 PM

Change 224076 abandoned by Thiemo Mättig (WMDE):
Add combined statementview-referenceview remove toolbar

https://gerrit.wikimedia.org/r/224076

Change 224074 merged by Thiemo Mättig (WMDE):
Add missing listview dependencies to toolbar controllers

https://gerrit.wikimedia.org/r/224074

Bene mentioned this in rEWBA1cc3327b9f43: Add missing listview dependencies to toolbar controllers.Sep 3 2015, 2:51 PM

thiemowmde mentioned this in rMEXT603afe035fde: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 3 2015, 2:51 PM

Change 223542 abandoned by Thiemo Mättig (WMDE):
Make referencesChanger optional in the referenceview widget

https://gerrit.wikimedia.org/r/223542

Lydia_Pintscher added a parent task: T87322: [Story] Section edit mode for statement groups.Sep 10 2015, 4:16 PM

Tobi_WMDE_SW updated the task description. (Show Details)Sep 15 2015, 1:23 PM

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-09-15.Sep 15 2015, 1:29 PM

thiemowmde updated the task description. (Show Details)Sep 15 2015, 1:31 PM

Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Sep 15 2015, 2:55 PM

Tobi_WMDE_SW mentioned this in T112653: [RFC] Possibly, from here it does not make sense to have editReferencesAlongWithStatement for backwards-compatibility.Sep 15 2015, 3:18 PM

Tobi_WMDE_SW closed subtask T112653: [RFC] Possibly, from here it does not make sense to have editReferencesAlongWithStatement for backwards-compatibility as Invalid.Sep 16 2015, 8:40 AM

• Jonas added a project: Story.Sep 25 2015, 2:30 PM

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-09-29.Sep 28 2015, 1:11 PM

Tobi_WMDE_SW removed thiemowmde as the assignee of this task.Sep 29 2015, 2:00 PM

• Jonas closed subtask T112652: [RFC] The expander should not be there when editing a statement and it's references. Just remove it. The reference section should not be collapsible. as Declined.Sep 29 2015, 3:16 PM

Change 190799 abandoned by Jonas Kress (WMDE):
[DNM] Edit References along with Statement

https://gerrit.wikimedia.org/r/190799

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-10-13.Oct 13 2015, 12:37 PM

adrianheine removed a project: Patch-For-Review.Oct 15 2015, 8:47 PM

[Task] Referenceview must *not* trigger any API request when clicking [remove]

Which remove button does this refer to?

[Task] The referenceview must bubble up "change" events to the referencelistview, then to the statementview

There is no referencelistview, there's just a listview of referenceview widgets in statementview.

[Task] Add new bool parameter "editReferencesAlongWithStatement" to referenceview to disable save+cancel

I suggest that we don't do this. Instead, we could a) use statementGuid as a flag (crude, but no so incorrect) or b) replace statementGuid and referencesChanger options with a simple saveReference ({Function|null}) option that acts as a flag (better, but a bit more work).

[Task] Reference views must switch back to non-edit mode when statementview's saving is done

That currently happens because the statementview recreates all it's child widgets on save.

In T87759#1737457, @adrianheine wrote:

[Task] Referenceview must *not* trigger any API request when clicking [remove]

Which remove button does this refer to?

When removing a reference the API request for removing should be sent when the save button of the statement is clicked.

That does not answer my question. Let me rephrase it: »For which [remove] button do we need a task of making sure it does not trigger an API call?« Remember that a Statement has multiple References which in turn have a SnakList which has multiple Snaks. There are multiple remove buttons within a statementview. I don't understand which one of these would be present in the case at hand but does currently trigger an API request.

In T87759#1737591, @Jonas wrote:

When removing a reference the API request for removing should be sent when the save button of the statement is clicked.

Actually, this is not true: There shouldn't be an API request for removing a reference, since the statement is saved as a whole. This implicitly removes the reference.

aude moved this task from Proposed to Doing on the Wikidata-Sprint-2015-10-13 board.Oct 21 2015, 10:05 AM

adrianheine updated the task description. (Show Details)Oct 21 2015, 11:58 AM

• Jonas assigned this task to adrianheine.Oct 21 2015, 12:23 PM

• Jonas removed adrianheine as the assignee of this task.Oct 21 2015, 12:25 PM

• Jonas assigned this task to adrianheine.

• Jonas moved this task from Doing to Backlog on the Wikidata-Sprint-2015-10-13 board.

• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2015-10-13 board.

• Jonas updated the task description. (Show Details)

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-11-03.Nov 3 2015, 12:43 PM

Tobi_WMDE_SW moved this task from Proposed to Doing on the Wikidata-Sprint-2015-11-03 board.

adrianheine edited projects, added MediaWiki-extensions-WikibaseView; removed MediaWiki-extensions-WikibaseRepository.Nov 3 2015, 12:52 PM

• Jonas removed adrianheine as the assignee of this task.Nov 3 2015, 5:26 PM