Page MenuHomePhabricator
Create Task
Maniphest T94006

Remove AjaxDispatcher use from FlaggedRevs
Closed, ResolvedPublic
Actions

Description

Still being used as of 2021:
https://github.com/wikimedia/mediawiki-extensions-FlaggedRevs/blob/4ff9aa6980/FlaggedRevs.php#L81

This has been deprecated for many years now.

Details

SubjectRepoBranchLines +/-
Remove AJAX interfacemediawiki/extensions/FlaggedRevsmaster+16 -52
Create and make use RESTful interface for the review endpointmediawiki/extensions/FlaggedRevsmaster+358 -50
Use new REST DiffHeader endpointmediawiki/extensions/FlaggedRevsmaster+10 -10
Create diffheader endpoint through a RESTful interfacemediawiki/extensions/FlaggedRevsmaster+1 K -847
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Mar 26 2015, 6:34 AM
Krinkle raised the priority of this task from to High.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Technical-Debt, FlaggedRevs.
Krinkle added subscribers: Aklapper, Reedy, Krenair, Legoktm.
Ricordisamoa subscribed.Jul 24 2015, 2:42 AM
Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.Jan 22 2016, 11:47 PM
Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Jul 13 2018, 11:10 PM
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).Jul 13 2018, 11:21 PM
Tgr mentioned this in T185664: Code stewardship review: FlaggedRevs.Jul 11 2020, 12:07 AM
Krinkle mentioned this in T42787: Remove legacy ajax interface.Feb 24 2021, 11:50 PM
Ladsgroup updated the task description. (Show Details)Mar 16 2021, 1:07 AM
Ladsgroup subscribed.Mar 16 2021, 1:15 AM
RhinosF1 subscribed.Mar 16 2021, 6:49 AM
gerritbot added a comment.May 18 2021, 2:16 PM

Change 692612 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/FlaggedRevs@master] Remove AjaxDispatcher use from FlaggedRevs

https://gerrit.wikimedia.org/r/692612

gerritbot added a project: Patch-For-Review.May 18 2021, 2:16 PM
gerritbot added a comment.May 19 2021, 1:50 PM

Change 692896 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/FlaggedRevs@master] WIP: use review endpoint through a RESTful interface

https://gerrit.wikimedia.org/r/692896

gerritbot added a comment.May 21 2021, 12:13 PM

Change 693408 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/extensions/FlaggedRevs@master] Use new REST DiffHeader endpoint

https://gerrit.wikimedia.org/r/693408

gerritbot added a comment.Sep 22 2021, 2:48 PM

Change 692612 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Create diffheader endpoint through a RESTful interface

https://gerrit.wikimedia.org/r/692612

gerritbot added a comment.Sep 23 2021, 4:07 PM

Change 693408 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Use new REST DiffHeader endpoint

https://gerrit.wikimedia.org/r/693408

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 23 2021, 5:00 PM
gerritbot added a comment.Sep 24 2021, 10:20 AM

Change 723478 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/FlaggedRevs@master] Remove AJAX interface

https://gerrit.wikimedia.org/r/723478

gerritbot added a comment.Oct 20 2021, 5:51 PM

Change 692896 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Create and make use RESTful interface for the review endpoint

https://gerrit.wikimedia.org/r/692896

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.6; 2021-10-26); removed MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Oct 20 2021, 6:00 PM
Vlad.shapik claimed this task.Oct 26 2021, 3:46 PM
• Pchelolo closed this task as Resolved.Nov 22 2021, 9:25 PM
gerritbot added a comment.Nov 22 2021, 9:43 PM

Change 723478 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Remove AJAX interface

https://gerrit.wikimedia.org/r/723478

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Nov 22 2021, 10:00 PM
Reedy closed subtask T203783: Rewrite ext.flaggedRevs.review.js to make use of action review as Declined.Nov 22 2021, 10:02 PM
Reedy mentioned this in T203783: Rewrite ext.flaggedRevs.review.js to make use of action review.
TheDJ closed subtask T203790: Replace AjaxBuildDiffHeaderItems with templates as Resolved.Nov 27 2021, 8:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits