Page MenuHomePhabricator

[Usability] Move the delete action outside of edit for link inspector and language inspector
Closed, ResolvedPublic1 Estimated Story Points

Assigned To
Authored By
Nirzar
May 6 2015, 12:29 AM
Referenced Files
F2961417: pasted_file
Nov 14 2015, 1:07 AM
F2961414: pasted_file
Nov 14 2015, 1:07 AM
F2961396: pasted_file
Nov 14 2015, 12:46 AM
F2961391: pasted_file
Nov 14 2015, 12:42 AM
F161007: link-to-inspect.png
May 6 2015, 12:29 AM
F161006: multiple-properties.png
May 6 2015, 12:29 AM

Description

The "remove" link button gets hidden behind auto suggest also, it's out of context in current place. We want to move it outside edit mode (inspector) and put it in context mode next to the link.

multiple-properties.png (1×2 px, 946 KB)

link-to-inspect.png (1×2 px, 975 KB)

Event Timeline

Nirzar raised the priority of this task from to Needs Triage.
Nirzar updated the task description. (Show Details)
Nirzar renamed this task from Move the delete action outside of edit for link inspector and language inspector to [Usability] Move the delete action outside of edit for link inspector and language inspector.Jun 2 2015, 9:06 PM

It seems odd that we have one action in the head and one in the body.

An editor at de.wp suggests the button should actually be an icon, a "stylized red cross" (I guess something like this).

I don't particularly like the one you linked to (maybe it makes more sense when it's smaller), but sure, I can ask.

@Elitre the problem with the red cross is, it might suggest that the text will be deleted in-fact it just removes a property of the text (link)
Also the unlink icon is pretty commonly used for removing links

here's better versions for it https://thenounproject.com/search/?q=unlink this icon in red would work too

Change 253055 had a related patch set uploaded (by DLynch):
Add ve.ui.AnnotationContextItem

https://gerrit.wikimedia.org/r/253055

pasted_file (142×425 px, 30 KB)

...and MediaWiki doesn't mix labeled and label-less icons seamlessly, it seems:

pasted_file (126×422 px, 8 KB)

Change 253055 merged by jenkins-bot:
Add ve.ui.AnnotationContextItem

https://gerrit.wikimedia.org/r/253055