I'm not sure if the right approach here is to remove the overflow-y: auto rule from mw-page-container

I think there are several unresolved issues left with this (e.g. input padding, search button hover, etc)

Now that the Vector/WVUI performance metric recording code has been merged, the next (and hopefully last) patch is the one in the synthetic performance repo that adds a test to collect these Vue search metrics:

The survey should now be off. I am going to make a follow up patch or patches that removes code related to this survey

This patch has been merged and should be deployed automatically within 30 minutes

The above patch is dependent on the integration patch and part of @phuedx 's patch "Instrument Vue.js-based search widget" . It's not ready for merge yet, but if anyone from the web team has bandwidth feel free to review :)

Blah Sorry for all the reassigns lol. Meant to assign to Jan as he said he wanted to take a look in standup today

Thanks for the review @alexhollender

This is dependent on the integration patch, but can probably be reviewed now if there is bandwidth

@alexhollender the style changes have been merged now. Can you take a look at https://wvui.netlify.app/ui/?path=/story/components-typeaheadsearch--typeahead-search and review?

Patch to be reviewed by @Jdrewniak: https://gerrit.wikimedia.org/r/c/wvui/+/637776/7

https://gerrit.wikimedia.org/r/c/wvui/+/638212 is ready for review. I'm hoping that will chip away a big chunk of this ticket

Final piece remaining on this depends on the integration bit (T264355) so I have moved this to blocked

Final piece remaining on this is adding config in vector and passing that to the top level component (e.g. App.vue). For that we will need the integration bit (T264355) so I have moved this to blocked

@alexhollender Should the input still expand upon focus if we configure thumbnails to NOT be shown?

In T244287#6579409, @phuedx wrote:

This now needs to be integrated with the wvui-typeahead-search component.

When we implement the sticky header, how important is it that we NOT make the sidebar sticky as well (if at all)? If we don't make the sidebar sticky, what should happen when a user scrolls past the sidebar and then clicks the sidebar button in the sticky header? For example in this scenario:

Now that the typeahead search component has been merged, the next patch up for review (to be reviewed by the Web team) is:

This has been merged now. Should we make a ticket for the debouncer work?

Putting this back into ready for dev until the network client ticket is resolved (I've assigned myself to that one). If anyone else wants to pick this up feel free to. If not, I will take it when the network client work has settled