Moving a page over the redirect leaves an abandoned row in the revision table
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Matanya
	Jul 17 2015, 3:59 AM

Description

when one moves a page some revision may gone away. exaple : https://en.wikipedia.org/wiki/WOLV

Details

	Subject	Repo	Branch	Lines +/-
	MovePage: Fix old, old bug with moving over redirects	mediawiki/core	master	+26 -18

Customize query in gerrit

Related Objects

Mentioned In: T102132: Entry in 'revision' table, but no entry in 'page' table (found in English Wikipedia -- rev_id: 611002002)
T154373: Create script for converting deletion log entries to "delete_redir"
T154372: Create script for retroactively generating old "delete_redir" log entries
T154370: Create script for moving orphaned revisions to the archive table
T151124: Orphaned redirect revisions appear when viewing contribs in mobile
T151003: Overriden redirects should not be moved to the archive table
T145991: Separate log action for deleting pages on move
T144279: Autoconfirmed user able to delete page [id.wikipedia]
Mentioned Here: T145991: Separate log action for deleting pages on move
T42624: Rollback shouldn't patrol without log entry

Event Timeline

Matanya created this task.Jul 17 2015, 3:59 AM

Matanya raised the priority of this task from to Unbreak Now!.

Matanya updated the task description. (Show Details)

Matanya subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2015, 3:59 AM

Matanya set Security to None.Jul 17 2015, 4:00 AM

Matanya added subscribers: Legoktm, Krinkle.

Matanya added a project: MediaWiki-General.Jul 17 2015, 4:03 AM

Could you be more specific? There's no obvious inconsistency in the revision history of the WOLV page.

I think the issue here is that if you move a page over a redirect, the old redirect is gone forever, rather than being moved to the archive table.

Matanya added a subscriber: • brooke.Jul 17 2015, 4:46 AM

Change 225284 had a related patch set uploaded (by Brion VIBBER):
Fix old, old bug with moving over redirects

https://gerrit.wikimedia.org/r/225284

gerritbot added a project: Patch-For-Review.Jul 17 2015, 5:11 AM

Ok, patch above *seems* to work but it's midnight and I had some tequila earlier, so please review carefully. ;)

Lowered priority since this bug has been around since 2004 and probably isn't that huge of a deal.

Jdforrester-WMF edited projects, added MediaWiki-Redirects, DBA; removed MediaWiki-General.Jul 19 2015, 11:15 PM

PleaseStand subscribed.Aug 17 2015, 11:58 AM

Removing assignment from some tasks I'm not actively working on. Volunteers welcome, I'm happy to help if pinged!

MGChecker subscribed.Jun 12 2016, 7:53 PM

Restricted Application added a subscriber: Luke081515. · View Herald TranscriptJun 12 2016, 7:53 PM

Bugreporter merged a task: T21871: Moving a page over a redirect causes a revision to vanish.Jul 29 2016, 5:39 PM

Bugreporter added subscribers: Mr.Z-man, Nemo_bis, Qgil and 3 others.

Krinkle unsubscribed.Jul 29 2016, 8:11 PM

@brion: I don't know if it is already included, but I think it would be useful to have an own log_action for this situation.

jcrespo edited projects, added MediaWiki-Logevents, MediaWiki-libs-Rdbms; removed DBA.Jul 30 2016, 11:10 AM

In T106119#2507269, @MGChecker wrote:

@brion: I don't know if it is already included, but I think it would be useful to have an own log_action for this situation.

Note this will produce a deletion log entry as well as a move log
entry. This may scare people.

I thought the implicit log action was intentional, similar to T42624: Rollback shouldn't patrol without log entry.

Qgil unsubscribed.Aug 8 2016, 8:22 AM

Change 225284 merged by jenkins-bot:
MovePage: Fix old, old bug with moving over redirects

https://gerrit.wikimedia.org/r/225284

Nemo_bis added a project: User-notice.Aug 17 2016, 5:26 AM

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 18 2016, 3:01 PM

Jdforrester-WMF closed this task as Resolved.Aug 19 2016, 7:31 PM

Jdforrester-WMF assigned this task to • brooke.

Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Aug 19 2016, 7:38 PM

Akeron subscribed.Aug 23 2016, 11:49 AM

RandomDSdevel awarded a token.Aug 23 2016, 5:24 PM

Johan moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Aug 24 2016, 10:04 PM

Tgr mentioned this in T144279: Autoconfirmed user able to delete page [id.wikipedia].Aug 30 2016, 4:53 PM

Johan moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Aug 31 2016, 5:27 AM

In T106119#2507269, @MGChecker wrote:

@brion: I don't know if it is already included, but I think it would be useful to have an own log_action for this situation.

Yeah that would be nice. Filed T145991.

GTrang mentioned this in T151003: Overriden redirects should not be moved to the archive table.Nov 17 2016, 11:17 PM

GTrang mentioned this in T151124: Orphaned redirect revisions appear when viewing contribs in mobile.Nov 19 2016, 8:05 PM

GTrang mentioned this in T154370: Create script for moving orphaned revisions to the archive table.Dec 31 2016, 5:55 PM

GTrang mentioned this in T154372: Create script for retroactively generating old "delete_redir" log entries.Dec 31 2016, 6:03 PM

GTrang mentioned this in T154373: Create script for converting deletion log entries to "delete_redir".Dec 31 2016, 6:08 PM

Liuxinyu970226 awarded a token.Dec 1 2017, 12:01 PM

Anomie merged a task: T102132: Entry in 'revision' table, but no entry in 'page' table (found in English Wikipedia -- rev_id: 611002002).Jul 19 2019, 1:24 PM

Anomie mentioned this in T102132: Entry in 'revision' table, but no entry in 'page' table (found in English Wikipedia -- rev_id: 611002002).

Anomie added subscribers: Halfak, Krinkle.

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptAug 13 2022, 1:54 PM