Page MenuHomePhabricator

[Story] Edit summary for unit changes
Closed, InvalidPublic

Description

[WE] I want to have a nice edit summary for unit changes where we have:

  • If the unit changes for a property then it should be reflected in the edit summary

Right now the summary looks like this:

(‎Changed claim: Quantity (P2): 51±1)

It should reflect the unit:

(‎Changed claim: Quantity (P2): 51±1 Meter)

Event Timeline

Jonas raised the priority of this task from to Needs Triage.
Jonas updated the task description. (Show Details)

@Jonas. Can you give more details please ? So someone adds a value with a unit and saves the edit. So you want to have a special edit summary if someone changes the saved data by modifying the unit only ?

Snipre: With what we have so far what's happening is the following:

A quantity value is stored without a unit - say 51. You then change it to have a unit: 51 km. The edit summary for this is "changed claim - some property (P42): 51". I don't think that's really useful as an automatic edit summary. But I fear we need to look at edit summaries as a whole again because there are probably more such cases.

@Lydia. From my point of view we should constraint the change of the unit with a change of the value (and vice versa) in ordert to reduce vandalism.

Snipre: With what we have so far what's happening is the following:
A quantity value is stored without a unit - say 51. You then change it to have a unit: 51 km. The edit summary for this is "changed claim - some property (P42): 51". I don't think that's really useful as an automatic edit summary. But I fear we need to look at edit summaries as a whole again because there are probably more such cases.

So a simple option would be to go for something like "changed claim - some property (P42): 51 km"? It might be nice to say "changed claim - some property (P42): 41 km -> 51 km", so that both the old and new options can be quickly seen in the edit summary.

@Lydia. From my point of view we should constraint the change of the unit with a change of the value (and vice versa) in order to reduce vandalism.

This would be a bad idea since it would stop people from easily correcting incorrect values, and it's kind of arbitrary. E.g., what would keep someone from changing "100km" to "10mm"? (unless there were more constraints applied, and that way lies the rabbit hole...)

Jonas renamed this task from Edit summary for unit changes to [Story] Edit summary for unit changes.Aug 17 2015, 4:06 PM
Jonas updated the task description. (Show Details)
Jonas set Security to None.
Jonas updated the task description. (Show Details)
Jonas updated the task description. (Show Details)
Lydia_Pintscher triaged this task as Normal priority.Aug 17 2015, 4:51 PM

@Jonas. Shoudn't we have something like 'from "" to meter' or '' from meter to km' ?

I think you can see the previous unit in the line beneath and in the diff likewise to a changing value. The one who implements it could decide whether to show more information ...

Jonas closed this task as Invalid.Feb 28 2018, 8:49 AM
Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptFeb 28 2018, 8:49 AM