Page MenuHomePhabricator
Create Task
Maniphest T110302

Update ConfirmEdit to use AuthManager
Closed, ResolvedPublic
Actions

Description

Should be a PreAuthenticationProvider.

Details

SubjectRepoBranchLines +/-
Add AuthManager support to SimpleCaptcha, QuestyCaptcha, FancyCaptcha, MathCaptchamediawiki/extensions/ConfirmEditmaster+1 K -228
Add AuthManager support for ReCaptcha, ReCaptchaNoCaptchamediawiki/extensions/ConfirmEditREL1_27+577 -63
Add AuthManager support for ReCaptcha, ReCaptchaNoCaptchamediawiki/extensions/ConfirmEditmaster+577 -63
Add AuthManager support to SimpleCaptcha, QuestyCaptcha, FancyCaptcha, MathCaptchamediawiki/extensions/ConfirmEditREL1_27+1 K -228
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• DeskanaT75616 Tracking: API/backend issues blocking Wikipedia app development
 ResolvedAnomieT32788 Allow triggering of user password reset email via the API
 OpenNoneT90925 General authentication improvements for MediaWiki
 ResolvedAnomieT48179 Allow a challenge stage during authentication
 OpenNoneT5709 Refactoring to make external authentication and identity systems easier
 ResolvedTgrT43201 UserLoadFromSession considered evil
 ResolvedAnomieT67493 Session is started by EditAction (problem for extensions using UserLoadFromSession hook)
 OpenFeatureNoneT55156 Provide option to force a login session to end within a certain time
 OpenNoneT89459 Modernize MediaWiki authentication system (AuthManager)
 OpenNoneT110291 Update all extensions to use AuthManager
 ResolvedTgrT134945 Update API clients for AuthManager
 Resolved• demonT135498 Release AuthManager with MediaWiki 1.27
 ResolvedTgrT138910 Backport AuthManager-related changes to 1.27
 ResolvedNoneT130340 [Reading Infrastructure 2015-16 Q4] Enable two-factor authentication via AuthManager on the Wikimedia cluster
 Resolved• Mattflaschen-WMFT68699 Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis
 ResolvedTgrT135504 Enable AuthManager in WMF production
 ResolvedAnomieT110282 Update extensions which are deployed on the Wikimedia cluster to use AuthManager
 ResolvedDbrantT135633 Add "remember me" support
 Resolved• MhollowayT124229 Update login and account creation for API changes
 ResolvedTgrT110302 Update ConfirmEdit to use AuthManager

Event Timeline

Tgr created this task.Aug 26 2015, 7:03 AM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: Reading-Infrastructure-Team-Old (Don't use), MediaWiki-Core-AuthManager, ConfirmEdit (CAPTCHA extension).
Tgr added subscribers: Aklapper, Tgr.
Restricted Application added a subscriber: Florian. · View Herald TranscriptAug 26 2015, 7:03 AM
Krenair subscribed.Aug 26 2015, 1:10 PM
bd808 moved this task from Backlog to AuthManager Backlog on the MediaWiki-Core-AuthManager board.Aug 26 2015, 5:32 PM
Liuxinyu970226 subscribed.Nov 16 2015, 8:52 AM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 16 2015, 8:52 AM
Liuxinyu970226 set Security to None.Nov 16 2015, 8:52 AM
Anomie subscribed.Mar 17 2016, 4:33 PM

Note ConfirmEdit currently really doesn't play nice with the AuthManager WIP code, because the new ApiAMCreateAccount (and probably ApiClientLogin too) isn't recognized by ConfirmEdit to do its parameters but still is going to hit its hooks on AbortNewAccount (and probably AbortLogin too).

• Mholloway subscribed.Mar 18 2016, 4:28 PM
• Mholloway added a parent task: T124229: Update login and account creation for API changes.Mar 18 2016, 4:30 PM
• Mholloway mentioned this in T124229: Update login and account creation for API changes.Mar 18 2016, 4:33 PM
gerritbot subscribed.Apr 26 2016, 8:57 AM

Change 285350 had a related patch set uploaded (by Gergő Tisza):
[WIP] Add AuthManager support

https://gerrit.wikimedia.org/r/285350

gerritbot added a project: Patch-For-Review.Apr 26 2016, 8:57 AM
Tgr added a comment.May 2 2016, 4:58 PM

ReCaptcha (both versions) does not seem to work with AuthManager's compatibility hacks; the others are OK.

Anomie added a comment.May 2 2016, 5:27 PM
In T110302#2257250, @Tgr wrote:

the others are OK.

Is that after you AuthManagerized the others in https://gerrit.wikimedia.org/r/285350?

Tgr added a comment.May 2 2016, 5:42 PM

AuthManager-enabled core + ReCaptcha does not work, with or without that patch. Non-AuthManager-enabled core + any captcha with the patch should work, although I only tested a few combinations.

Not a blocker for WMF deployment but it's bundled with the tarball so it needs to be done before the final 1.27 release. I have a half-baked patch for ReCaptcha but I figured it makes more sense to work on the WMF-deployed extensions first, since that blocks testing in production.

gerritbot added a comment.May 3 2016, 4:43 PM

Change 286682 had a related patch set uploaded (by Gergő Tisza):
[WIP] Add AuthManager support for ReCaptcha, ReCaptchaNoCaptcha

https://gerrit.wikimedia.org/r/286682

gerritbot added a comment.May 16 2016, 7:12 PM

Change 285350 merged by jenkins-bot:
Add AuthManager support to SimpleCaptcha, QuestyCaptcha, FancyCaptcha, MathCaptcha

https://gerrit.wikimedia.org/r/285350

gerritbot added a comment.May 16 2016, 7:12 PM

Change 286682 merged by jenkins-bot:
Add AuthManager support for ReCaptcha, ReCaptchaNoCaptcha

https://gerrit.wikimedia.org/r/286682

Anomie closed this task as Resolved.May 16 2016, 7:35 PM
Anomie assigned this task to Tgr.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)).May 16 2016, 8:00 PM
gerritbot added a comment.May 17 2016, 11:07 AM

Change 289167 had a related patch set uploaded (by Gergő Tisza):
Add AuthManager support to SimpleCaptcha, QuestyCaptcha, FancyCaptcha, MathCaptcha

https://gerrit.wikimedia.org/r/289167

gerritbot added a comment.May 17 2016, 11:20 AM

Change 289167 merged by jenkins-bot:
Add AuthManager support to SimpleCaptcha, QuestyCaptcha, FancyCaptcha, MathCaptcha

https://gerrit.wikimedia.org/r/289167

gerritbot added a comment.May 17 2016, 11:26 AM

Change 289172 had a related patch set uploaded (by Gergő Tisza):
Add AuthManager support for ReCaptcha, ReCaptchaNoCaptcha

https://gerrit.wikimedia.org/r/289172

gerritbot added a comment.May 17 2016, 11:42 AM

Change 289172 merged by jenkins-bot:
Add AuthManager support for ReCaptcha, ReCaptchaNoCaptcha

https://gerrit.wikimedia.org/r/289172

Liuxinyu970226 unsubscribed.May 19 2016, 5:06 AM
• Fjalapeno edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Reading-Infrastructure-Team-Old (Don't use).Jun 7 2017, 2:57 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits