Page MenuHomePhabricator
Create Task
Maniphest T113461

pywikibot.Link should support interwiki prefix be-x-old
Closed, ResolvedPublic
Actions

Description

After T11823,

$ python /shared/pywikipedia/core/pwb.py shell
Welcome to the Pywikibot interactive shell!
>>> import pywikibot as pyb
>>> pywikibot.Link(u"be-tarask:Страсбург", source=pywikibot.Site("en", "wikipedia"))
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/data/project/pywikibot/public_html/core/pywikibot/page.py", line 4749, in __repr__
    return "pywikibot.page.Link(%r, %r)" % (self.title, self.site)
  File "/data/project/pywikibot/public_html/core/pywikibot/page.py", line 4937, in title
    self.parse()
  File "/data/project/pywikibot/public_html/core/pywikibot/page.py", line 4831, in parse
    self._text, self._site, prefix, e))
SiteDefinitionError: be-tarask:Страсбург is not a local page on wikipedia:en, and the interwiki prefix be-tarask is not supported by PyWikiBot!:
Unknown URL 'https://be-x-old.wikipedia.org/wiki/$1'.
>>> pywikibot.Link(u"be-x-old:Страсбург", source=pywikibot.Site("en", "wikipedia"))
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/data/project/pywikibot/public_html/core/pywikibot/page.py", line 4749, in __repr__
    return "pywikibot.page.Link(%r, %r)" % (self.title, self.site)
  File "/data/project/pywikibot/public_html/core/pywikibot/page.py", line 4937, in title
    self.parse()
  File "/data/project/pywikibot/public_html/core/pywikibot/page.py", line 4831, in parse
    self._text, self._site, prefix, e))
SiteDefinitionError: be-x-old:Страсбург is not a local page on wikipedia:en, and the interwiki prefix be-x-old is not supported by PyWikiBot!:
Unknown URL 'https://be-x-old.wikipedia.org/wiki/$1'.

Expected: Instead of SiteDefinitionError, It should parse the link to be-tarask:Страсбург.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT102107 Enable Content Translation in Catalan Wikipedia for all logged-in users
 OpenNoneT116533 ContentTranslation issues that affect people who aren't editors or translators (tracking)
 OpenNoneT126916 ContentTranslation gray interlanguage links issues (tracking)
 OpenNoneT105577 use geolocation to show the gray interlanguage link in ContentTranslation
 OpenNoneT105578 Incorrect language code handling in ContentTranslation (tracking)
 OpenNoneT116466 Simple English Wikipedia issues with ContentTranslation (tracking)
 StalledNoneT110190 Rename "simple" wikis to "en-simple"
 StalledNoneT147164 Site identifier and domain prefix for nowiki should be changed
 InvalidNoneT127680 Rename Serbo-Croatian Wikipedia and Wiktionary from sh.wiki* to hbs.wiki*
 StalledNoneT124657 Rename cbk-zamwiki to cbkwiki
 StalledNoneT10217 Wikipedias with zh-* language codes waiting to be renamed (zh-min-nan -> nan, zh-yue -> yue, zh-classical -> lzh)
 StalledNoneT64717 Move oldwikisource on www.wikisource.org to mul.wikisource.org
 StalledNoneT41968 Bhojpuri wikipedia should start with 'bho' instead of 'bh' to avoid confusion with Bihari
 StalledFeatureNoneT36217 Rename emlwiki -> eglwiki
 StalledNoneT31186 Rename Võro Wikipedia, fiu-vro -> vro
 StalledFeatureNoneT28725 Renaming the Aramaic (arc) Wikipedia to the Syriac (syc) Wikipedia
 StalledFeatureNoneT27522 language code change for Samogitian: "bat-smg" to "sgs"
 StalledFeatureNoneT25216 Move the Nourmande Wikipedia from nrm to nrf
 StalledNoneT17988 Rename 'roa-rup' wikis to 'rup'
 StalledNoneT6793 Rename Alemannic Wikipedia from als.wikipedia to gsw.wikipedia
 OpenNoneT172035 Blockers for Wikimedia wiki domain renaming
 ResolvedNoneT113461 pywikibot.Link should support interwiki prefix be-x-old
 ResolvedLadsgroupT111853 The href of be-tarask: interlanguage link points to the be-x-old domain

Event Timeline

zhuyifei1999 created this task.Sep 23 2015, 10:54 AM
zhuyifei1999 raised the priority of this task from to Needs Triage.
zhuyifei1999 updated the task description. (Show Details)
zhuyifei1999 added a project: Pywikibot.
zhuyifei1999 added subscribers: zhuyifei1999, Ladsgroup, jayvdb.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptSep 23 2015, 10:54 AM
zhuyifei1999 added a subtask: T111853: The href of be-tarask: interlanguage link points to the be-x-old domain.Sep 23 2015, 11:04 AM
XZise subscribed.Sep 23 2015, 11:08 AM

The Link.parse method could in theory check the family's interwiki_replacements and replace them before getting the actual site associated with this link.

XZise added a comment.Sep 23 2015, 11:27 AM

Ah dang it that isn't actually the problem… the problem is that we don't parse be-x-old.wikipedia.org into the new site. When you use Python 3 you actually see the original traceback and it's actually written in the exception text: Unknown URL 'https://be-x-old.wikipedia.org/wiki/$1'.

The actual bug is that there is no hostname provided for obsolete sites. So it might be a duplicate of T74674: Unable to communicate with obsolete / non-existing wikis .

Krenair subscribed.Sep 23 2015, 11:44 AM
zhuyifei1999 added a comment.Sep 23 2015, 11:57 AM

Yeah, be-tarask in url works:

>>> pywikibot.Site(url="https://be-tarask.wikipedia.org/wiki/$1")
Site("be-tarask", "wikipedia")
zhuyifei1999 added a comment.Sep 23 2015, 12:00 PM

Why not add checks for obsolete/moved wikis in Family.from_url ?

XZise added a comment.Sep 23 2015, 12:05 PM

Because it compares the article paths and to do that it needs to query the wiki and that is not possible (hence T74674, because the hostname is not available). If that is possible, it might be possible to Family.from_url to work also for obsolete wikis.

Liuxinyu970226 set Security to None.Sep 27 2015, 12:35 AM
Liuxinyu970226 subscribed.
Liuxinyu970226 mentioned this in T25216: Move the Nourmande Wikipedia from nrm to nrf.Jun 12 2017, 4:23 PM
Dvorapa subscribed.Jan 17 2018, 11:44 PM

BTW be-tarask works in pywikibot.Site(), but not in interwiki link as such: pywikibot.Page(pywikibot.Site(), "be-tarask:page")
be-x-old doesn't work at all

Liuxinyu970226 added a parent task: T172035: Blockers for Wikimedia wiki domain renaming.Apr 18 2018, 4:28 AM
Liuxinyu970226 mentioned this in T172035: Blockers for Wikimedia wiki domain renaming.Apr 18 2018, 4:45 AM
Dvorapa added a comment.EditedAug 9 2018, 10:18 AM
Script terminated by exception:

ERROR: SiteDefinitionError: be-tarask:Баўгарыя is not a local page on wikipedia:cs, and the interwiki prefix be-tarask is not supported by Pywikibot!
Unknown URL 'https://be-x-old.wikipedia.org/wiki/$1'.
Traceback (most recent call last):
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/page.py", line 5609, in parse
    newsite = self._site.interwiki(prefix)
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/site.py", line 956, in interwiki
    return self._interwikimap[prefix].site
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/site.py", line 710, in __getitem__
    raise self._iw_sites[prefix].site
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/site.py", line 673, in site
    self._site = pywikibot.Site(url=self.url)
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/__init__.py", line 1238, in Site
    code, fam = _code_fam_from_url(url)
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/__init__.py", line 1195, in _code_fam_from_url
    raise SiteDefinitionError("Unknown URL '{0}'.".format(url))
pywikibot.exceptions.SiteDefinitionError: Unknown URL 'https://be-x-old.wikipedia.org/wiki/$1'.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "pwb.py", line 253, in <module>
    if not main():
  File "pwb.py", line 246, in main
    run_python_file(filename, [filename] + args, argvu, file_package)
  File "pwb.py", line 115, in run_python_file
    main_mod.__dict__)
  File "./neexistujici-kotvy.py", line 272, in <module>
    main()
  File "./neexistujici-kotvy.py", line 258, in main
    bot.run()  # guess what it does
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/bot.py", line 1505, in run
    self.treat(page)
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/bot.py", line 1733, in treat
    self.treat_page()
  File "./neexistujici-kotvy.py", line 162, in treat_page
    if testovana_stranka.isRedirectPage():
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/page.py", line 811, in isRedirectPage
    return self.site.page_isredirect(self)
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/page.py", line 218, in site
    return self._link.site
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/page.py", line 5705, in site
    self.parse()
  File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/page.py", line 5616, in parse
    .format(self._text, self._site, prefix, e))
pywikibot.exceptions.SiteDefinitionError: be-tarask:Баўгарыя is not a local page on wikipedia:cs, and the interwiki prefix be-tarask is not supported by Pywikibot!
Unknown URL 'https://be-x-old.wikipedia.org/wiki/$1'.
CRITICAL: Closing network session.

Every single time Pywikibot tries to parse [[be-tarask:something]]

Dalba triaged this task as High priority.Aug 9 2018, 10:46 AM
Aschroet subscribed.Dec 18 2018, 6:40 PM
Dvorapa mentioned this in T215298: Incubator interwiki makes page.py crash.Feb 5 2019, 5:02 PM
Dvorapa mentioned this in T234147: UserWarning: Site wikipedia:be-tarask instantiated using different code "be-x-old".Sep 29 2019, 10:51 AM
Ladsgroup closed subtask T111853: The href of be-tarask: interlanguage link points to the be-x-old domain as Resolved.Jun 5 2020, 11:05 AM
Dvorapa reopened subtask T111853: The href of be-tarask: interlanguage link points to the be-x-old domain as Open.Jun 5 2020, 12:19 PM
Ladsgroup closed subtask T111853: The href of be-tarask: interlanguage link points to the be-x-old domain as Resolved.Aug 3 2020, 8:10 AM
Xqt closed this task as Resolved.Aug 3 2020, 10:23 AM
Xqt claimed this task.
Xqt removed Xqt as the assignee of this task.
Xqt subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL