Convert DeleteAction.php/SpecialUndelete.php to use OOUI
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Sep 25 2015, 4:49 PM

Description

Before	After

Details

Subject	Repo	Branch	Lines +/-
Convert rev preview on special:undelete to OOUI	mediawiki/core	master	+11 -6
Convert rest of Special:Undelete to OOUI	mediawiki/core	master	+94 -68
Convert article delete to use OOUI	mediawiki/core	master	+116 -63
Convert Special:Undelete search form to use OOUI	mediawiki/core	master	+52 -24

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Open	None	T100161 Convert all of MediaWiki core to OOUI PHP (tracking)
Resolved	Esanders	T113758 Convert DeleteAction.php/SpecialUndelete.php to use OOUI
Duplicate	None	T171455 Dropdown widgets on Special:Delete only has partial OOUI styling

Event Timeline

Jdforrester-WMF created this task.Sep 25 2015, 4:49 PM

Jdforrester-WMF raised the priority of this task from to Medium.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added a project: UI-Standardization.

Jdforrester-WMF added subscribers: Legoktm, matmarex, Jdforrester-WMF and 3 others.

Volker_E moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.Jan 18 2016, 11:26 PM

Partial dupe of T117794?

Change 352863 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Convert article delete to use OOUI

https://gerrit.wikimedia.org/r/352863

gerritbot added a project: Patch-For-Review.May 9 2017, 5:25 PM

Change 352874 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Convert Special:Undelete search form to use OOUI

https://gerrit.wikimedia.org/r/352874

In T113758#3248579, @Esanders wrote:

Partial dupe of T117794?

Adjusted parentage to make this work.

Change 361026 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Convert rest of Special:Undelete to OOUI

https://gerrit.wikimedia.org/r/361026

Change 352874 merged by jenkins-bot:
[mediawiki/core@master] Convert Special:Undelete search form to use OOUI

https://gerrit.wikimedia.org/r/352874

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 12 2017, 4:00 PM

Change 352863 merged by jenkins-bot:
[mediawiki/core@master] Convert article delete to use OOUI

https://gerrit.wikimedia.org/r/352863

ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 12 2017, 5:00 PM

Change 361026 merged by jenkins-bot:
[mediawiki/core@master] Convert rest of Special:Undelete to OOUI

https://gerrit.wikimedia.org/r/361026

Let's consider RevisionDelete separately, it's an entirely different functionality (and we've done mostly everything else here, so it'd be nice not to block this task on that).

matmarex renamed this task from Convert DeleteAction.php/SpecialUndelete.php/SpecialRevisiondelete.php to use OOUI to Convert DeleteAction.php/SpecialUndelete.php to use OOUI.Jul 12 2017, 7:55 PM

matmarex removed a subtask: T117794: Convert Special:RevisionDelete to OOUI.

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)); removed MW-1.30-release-notes.Jul 12 2017, 8:00 PM

After the changes here:

The button and checkboxes at the bottom of Special:Undelete are unchanged. Is that in scope? (The same kind of button and checkboxes are shown e.g. on history pages, which are not OOUI yet, so we might want to leave that for later.)

In T113758#3432659, @matmarex wrote:

The button and checkboxes at the bottom of Special:Undelete are unchanged. Is that in scope? (The same kind of button and checkboxes are shown e.g. on history pages, which are not OOUI yet, so we might want to leave that for later.)

I was thinking of doing that with history pages, yes. They're all generated by HistoryListItemFactoryClassMaker.php or whatever, right?

Volker_E subscribed.Jul 12 2017, 8:37 PM

Looking at the code, it seems all of this is duplicated in
SpecialUndelete… I guess we might want to deal with that first.

Volker_E updated the task description. (Show Details)Jul 13 2017, 7:09 AM

matmarex updated the task description. (Show Details)Jul 13 2017, 5:34 PM

For future reference this has caused T171405. If you are working on more deletion or revdel OOUI-js conversion please do verify that all previous options still work. Thanks!

Screenshot from 2017-07-23 16-34-29.png (590×991 px, 33 KB)

In MonoBook (using the Apex theme) the delete button looks like a lightish red on a white background, is that enough contrast to meet AA/AAA?

@Legoktm Let's discuss this further in T171458: Create color sheet + WCAG evaluation of Apex

TheDJ added a subtask: T171455: Dropdown widgets on Special:Delete only has partial OOUI styling.Jul 24 2017, 3:10 PM

Trijnstel subscribed.Aug 12 2017, 1:43 PM

Shizhao mentioned this in T173997: Convert file delete to use OOUI.Aug 24 2017, 6:16 AM

Change 373928 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Convert rev preview on special:undelete to OOUI

https://gerrit.wikimedia.org/r/373928

Restricted Application added a subscriber: jeblad. · View Herald TranscriptAug 25 2017, 5:14 PM

gerritbot added a project: Patch-For-Review.Aug 25 2017, 5:14 PM

Change 373928 abandoned by Esanders:
Convert rev preview on special:undelete to OOUI

Reason:
Icb550a6ad8f90d7718441ec17a1026a2cfb9d754