Page MenuHomePhabricator
Create Task
Maniphest T125738

Cross-wiki notifications: Links for thanks notifications point to the local wiki
Closed, ResolvedPublic
Actions

Description

I went to https://test.wikipedia.org/ where I have cross-wiki notifications turned on, and found that I had received thanks from guwikiquote and bhwiki. However, they were links like this:

Whereas they should've been:

Details

SubjectRepoBranchLines +/-
Echo API returns absolute URLs in notification linksmediawiki/extensions/Echowmf/1.27.0-wmf.13+9 -0
Echo API returns absolute URLs in notification linksmediawiki/extensions/Echowmf/1.27.0-wmf.14+9 -0
Echo API returns absolute URLs in notification linksmediawiki/extensions/Echomaster+9 -0
Customize query in gerrit

Related Objects

Event Timeline

Krenair created this task.Feb 3 2016, 11:19 PM
Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair added projects: Notifications, Thanks.
Krenair subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 3 2016, 11:19 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
• Mattflaschen-WMF claimed this task.Feb 3 2016, 11:19 PM
• Mattflaschen-WMF edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
• Mattflaschen-WMF set Security to None.
Etonkovidova subscribed.EditedFeb 4 2016, 12:32 AM

I just checked it in beta - cross-wiki thanks worked correctly.

test.wikipedia.org and test2.wikipedia.org worked too.

• Mattflaschen-WMF removed • Mattflaschen-WMF as the assignee of this task.Feb 4 2016, 2:41 AM
Catrope moved this task from Untriaged to RFP (cross-wiki notifications) on the Collaboration-Team-Archive-2015-2016 board.Feb 18 2016, 6:42 PM
SBisson merged a task: T127415: Cross-wiki notification gets the wrong target.Feb 19 2016, 11:54 AM
SBisson added subscribers: Collaboration-Team-Triage, Trizek-WMF.
Matanya subscribed.Feb 20 2016, 7:16 PM

I can reproduce that between he.wiki and a thank on pl.wiki.

It might be related to the fact pl.wiki didn't get cross-wiki notifications yet.

hoo subscribed.Feb 20 2016, 7:19 PM
Trizek-WMF triaged this task as High priority.Feb 22 2016, 8:13 AM

Triaged as Hugh, due to the important number of feedback received.

Trizek-WMF added a comment.Feb 22 2016, 9:44 AM
In T125738#2048125, @Matanya wrote:

I can reproduce that between he.wiki and a thank on pl.wiki.

It might be related to the fact pl.wiki didn't get cross-wiki notifications yet.

Cross-wikis Notifications are not related to the wikis where the feature has been activated: that feature is like an inbox, where all notifications are gathered. To illustrate, I've experienced that bug on fr.wp with a thank from it.wp, and on Commons, with a thank from fr.wp.

Trizek-WMF mentioned this in T127697: Cross-wiki notifications: Links for reverts notifications point to the local wiki.Feb 22 2016, 12:52 PM
• Mattflaschen-WMF claimed this task.Feb 22 2016, 7:55 PM
Catrope merged a task: T127843: A link from a cross-wiki Thanks notification leads to the current wiki instead of the correct target remote wiki.Feb 23 2016, 4:46 PM
Catrope added subscribers: Mooeypoo, Amire80, • Elitre.
• Mattflaschen-WMF removed • Mattflaschen-WMF as the assignee of this task.Feb 23 2016, 4:50 PM
• Mattflaschen-WMF subscribed.
gerritbot subscribed.Feb 23 2016, 5:49 PM

Change 272775 had a related patch set uploaded (by Sbisson):
Echo API returns absolute URLs in notification links

https://gerrit.wikimedia.org/r/272775

gerritbot added a project: Patch-For-Review.Feb 23 2016, 5:49 PM
SBisson claimed this task.Feb 23 2016, 5:50 PM
SBisson moved this task from RFP (cross-wiki notifications) to Code Review Started on the Collaboration-Team-Archive-2015-2016 board.
SBisson moved this task from Code Review Started to Needs Review on the Collaboration-Team-Archive-2015-2016 board.
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Feb 23 2016, 5:58 PM
gerritbot added a comment.Feb 23 2016, 6:02 PM

Change 272775 merged by jenkins-bot:
Echo API returns absolute URLs in notification links

https://gerrit.wikimedia.org/r/272775

gerritbot added a comment.Feb 23 2016, 6:04 PM

Change 272780 had a related patch set uploaded (by Catrope):
Echo API returns absolute URLs in notification links

https://gerrit.wikimedia.org/r/272780

gerritbot added a comment.Feb 23 2016, 6:04 PM

Change 272781 had a related patch set uploaded (by Catrope):
Echo API returns absolute URLs in notification links

https://gerrit.wikimedia.org/r/272781

Quiddity merged a task: T127812: Cross-wiki notification opens on local wiki.Feb 23 2016, 8:58 PM
Quiddity added subscribers: Sjoerddebruin, JEumerus, Josve05a.
gerritbot added a comment.Feb 24 2016, 1:33 AM

Change 272780 merged by jenkins-bot:
Echo API returns absolute URLs in notification links

https://gerrit.wikimedia.org/r/272780

gerritbot added a comment.Feb 24 2016, 1:33 AM

Change 272781 merged by jenkins-bot:
Echo API returns absolute URLs in notification links

https://gerrit.wikimedia.org/r/272781

Etonkovidova added a comment.Feb 24 2016, 6:14 PM

Checked Mention and Thanks for cross wiki notifications on testwiki, fr.wiki, he.wiki, wikidata - seems to be fixed.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Feb 24 2016, 6:29 PM
• jmatazzoni closed this task as Resolved.Feb 25 2016, 12:52 AM
• jmatazzoni added a subscriber: SBisson.
Trizek-WMF awarded a token.Feb 25 2016, 11:03 AM
• Phabricator_maintenance added a project: Collaboration-Team-Triage.Aug 12 2016, 11:52 AM
• Phabricator_maintenance removed a subscriber: Collaboration-Team-Triage.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL