Page MenuHomePhabricator
Create Task
Maniphest T128638

Unable to mark translatable pages for translation, need to add &do=mark to the URL
Closed, ResolvedPublic
Actions

Description

Starting today, I noticed that Special:PageTranslation for some reason produces a button that simply says "Confirm" when requesting to mark a page for translation

PageTrans1.png (762×1 px, 44 KB)
. However, selecting confirm fails to mark the page for translation, and results in a blank screen
PageTrans2.png (762×1 px, 42 KB)
and no apparent action has been taken to update the page given new changes
PageTrans3.png (762×1 px, 74 KB)
.

I've attached some screenshots to document this. If anyone knows who to assign this to, help would be appreciated.

Edit: @Nemo_bis , I've added you here since you're active using this extension and might know who to reach out to better than I do.

Details

SubjectRepoBranchLines +/-
Fix regression in marking page for translationmediawiki/extensions/Translatewmf/1.27.0-wmf.15+1 -1
Fix regression in marking page for translationmediawiki/extensions/Translatemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

I_JethroBT created this task.Mar 2 2016, 8:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2016, 8:25 PM
I_JethroBT triaged this task as High priority.Mar 2 2016, 8:25 PM
I_JethroBT updated the task description. (Show Details)Mar 2 2016, 9:37 PM
I_JethroBT updated the task description. (Show Details)
I_JethroBT added a subscriber: Nemo_bis.
jeblad subscribed.Mar 3 2016, 1:50 AM
Nikerabbit subscribed.Mar 3 2016, 9:13 AM

Thank you reporting this issue.

You can use any of the following to work-arounds:

  1. Append &do=mark to the url
  2. Go via Special:PageTranslation
Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Mar 3 2016, 9:13 AM
Nikerabbit removed a project: MediaWiki-Special-pages.
Nikerabbit added a project: LE-CX8-Sprint 3.Mar 3 2016, 9:26 AM
Nemo_bis added a comment.EditedMar 3 2016, 9:28 AM

I just experienced this bug myself and I saw this report while uploading my screenshot (F3513165).

As Nikerabbit said, the URL now provided by the "banner" at the top of a modified translatable page is wrong, as the domark is missing: https://meta.wikimedia.org/w/index.php?title=Special:PageTranslation&target=Affiliate-selected+Board+seats%2F2016%2FNominations%2FChristophe+Henner

Nemo_bis renamed this task from PageTranslation failing to update pages when changes occur to PageTranslation failing to re-mark pages for translation.Mar 3 2016, 9:29 AM
• Elitre subscribed.Mar 3 2016, 11:06 AM
Shirayuki subscribed.Mar 3 2016, 11:19 AM
Nikerabbit renamed this task from PageTranslation failing to re-mark pages for translation to Unable to mark translatable pages for translation.Mar 3 2016, 3:34 PM
Trizek-WMF subscribed.Mar 3 2016, 3:40 PM
Nikerabbit merged a task: T128719: Unable mark for translation - Special:PageTranslation is blocked by "confirm" button.Mar 3 2016, 4:15 PM
Nikerabbit added subscribers: Ata, Base, Matanya and 3 others.
gerritbot subscribed.Mar 3 2016, 8:02 PM

Change 274793 had a related patch set uploaded (by Nikerabbit):
Fix regression in marking page for translation

https://gerrit.wikimedia.org/r/274793

gerritbot added a project: Patch-For-Review.Mar 3 2016, 8:02 PM
gerritbot added a comment.Mar 3 2016, 8:17 PM

Change 274793 merged by jenkins-bot:
Fix regression in marking page for translation

https://gerrit.wikimedia.org/r/274793

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).Mar 3 2016, 9:00 PM
Nikerabbit added a comment.Mar 3 2016, 9:24 PM

Patch is merged, but I am not going to stay up till 3 am for SWAT and there are no other SWAT windows this week, so the fix is not going to be deployed until next week unless someone wants to champion the patch in my stead.

Rillke subscribed.Mar 3 2016, 9:28 PM
Arrbee assigned this task to KartikMistry.Mar 4 2016, 8:08 AM
Arrbee edited projects, added LE-CX8-Sprint break; removed LE-CX8-Sprint 3.
Trizek-WMF mentioned this in T128865: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis.Mar 4 2016, 4:03 PM
Trizek-WMF added a parent task: T128865: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis.
Matiia subscribed.Mar 4 2016, 4:09 PM
Glaisher raised the priority of this task from High to Unbreak Now!.Mar 4 2016, 4:21 PM
Glaisher merged a task: T128858: Unable to mark new version of page for translation.
Glaisher added subscribers: Vogone, Stryn, Glaisher.

This is pretty UBN as it's preventing from marking new changes for translation. Is there any way to get it deployed before next week's SWAT?

Glaisher lowered the priority of this task from Unbreak Now! to High.Mar 4 2016, 4:24 PM

Ah, there's a workaround. OK, in that case.

Kbrown subscribed.Mar 4 2016, 7:59 PM
Nemo_bis renamed this task from Unable to mark translatable pages for translation to Unable to mark translatable pages for translation, need to add &do=mark to the URL.Mar 5 2016, 5:43 PM
Base added a comment.Mar 5 2016, 9:45 PM

Erm, devs break things and then say that they are too lazy to fix them?

siebrand subscribed.Mar 5 2016, 9:49 PM

That comment is uncalled for, @Base. Please remove it.

Nemo_bis added a comment.Mar 6 2016, 8:23 AM

Translate developers already fixed the bug.

Nemo_bis removed a parent task: T128865: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis.Mar 6 2016, 8:25 AM
gerritbot added a comment.Mar 7 2016, 7:20 AM

Change 275366 had a related patch set uploaded (by KartikMistry):
Fix regression in marking page for translation

https://gerrit.wikimedia.org/r/275366

• Elitre added a comment.Mar 7 2016, 9:02 AM

T129044 may be related.

Aklapper added a comment.Mar 7 2016, 11:14 AM

@Base: Please stick to criticizing ideas, not people. Thanks for keeping Phabricator a respectful place.

gerritbot added a comment.Mar 7 2016, 4:25 PM

Change 275366 merged by jenkins-bot:
Fix regression in marking page for translation

https://gerrit.wikimedia.org/r/275366

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Mar 7 2016, 5:00 PM
KartikMistry moved this task from Backlog to Done on the LE-CX8-Sprint break board.Mar 8 2016, 1:50 PM
Arrbee closed this task as Resolved.Mar 9 2016, 8:04 AM
Aklapper removed subscribers: siebrand, Kbrown, Glaisher and 19 others.May 16 2023, 12:56 PM
Aklapper removed a subscriber: MediaWiki-extensions-Translate.
Maintenance_bot removed projects: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), Patch-For-Review.May 16 2023, 1:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits