Page MenuHomePhabricator
Create Task
Maniphest T130316

Remove dependency from WikibaseView on StatementRankSerializer in WikibaseRepo
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Remove WikibaseView dependency on StatementRankSerializermediawiki/extensions/Wikibasemaster+22 -20
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAddshoreT173818 [Epic] Kill the Wikidata build step
 ResolvedAddshoreT181709 Cleanup Phabricator tickets once the build is dead
 InvalidNoneT108946 [Epic] Improve the development infrastructure
DeclinedNoneT74907 [Task] move git repositories that are dependencies of wikidata to gerrit
 ResolvedTobi_WMDE_SWT103697 Add Phabricator project tag for Wikibase-DataModel-Services
 ResolvedAddshoreT45855 [Task] UI messages in repo, JS is in lib
 DeclinedNoneT75863 [Task] Split wikibase.git
 OpenNoneT108296 [Epic] Remove WikibaseLib
 ResolvedJeroenDeDauwT108286 [Task] Move Wikibase Lib code that belongs in DataModel Services to this new component
 ResolvedJeroenDeDauwT108963 [Task] Use services from WikibaseDataModelServices added in 1.1.0 release
 ResolvedAddshoreT75020 [Task] Move JS and PHP view code to separate repo
 ResolvedLydia_PintscherT130316 Remove dependency from WikibaseView on StatementRankSerializer in WikibaseRepo
 InvalidNoneT75887 [Task] Find a home for shared utilities like reporters, sites, etc.
 OpenNoneT75875 Find a home for EntityChange and friends
 DeclinedNoneT76469 move formatters into own directory
 ResolvedthiemowmdeT76468 move parsers and validators into own directory
 ResolvedAddshoreT104187 Move services in DataModel to DataModel Services
 ResolvedJanZerebeckiT102629 Request Gerrit repository for WikibaseDataModelServices
 ResolvedJeroenDeDauwT93741 [RFC] Create place to put common Wikibase services
 ResolvedAddshoreT110344 Fix cohesion/CRP issue in Wikibase DataModel Services
 DeclinedNoneT108681 [RFC] Create a new Wikibase-Change-Services component
 OpenNoneT108835 [RFC] Find a new home for Wikibase Lib / Reporting

Event Timeline

adrianheine created this task.Mar 17 2016, 9:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2016, 9:50 PM
Bene subscribed.Mar 17 2016, 10:00 PM

From the class documentation:

@todo this could be moved to DataModelSerialization (in some form)

This is exactly what should be done here (+ new methods in the factories).

gerritbot subscribed.Mar 17 2016, 10:06 PM

Change 278092 had a related patch set uploaded (by Adrian Heine):
Remove WikibaseView dependency on StatementRankSerializer

https://gerrit.wikimedia.org/r/278092

gerritbot added a project: Patch-For-Review.Mar 17 2016, 10:06 PM
adrianheine added a comment.Mar 17 2016, 10:07 PM

That would work, too.

gerritbot added a comment.Mar 18 2016, 9:02 AM

Change 278092 merged by jenkins-bot:
Remove WikibaseView dependency on StatementRankSerializer

https://gerrit.wikimedia.org/r/278092

Lydia_Pintscher closed this task as Resolved.Apr 3 2016, 12:46 PM
Lydia_Pintscher claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL