In OATHAuthKey.php...

		// See if the user is using a scratch token
		if ( !$retval ) {
			$length = count( $this->scratchTokens );
			// Detect condition where all scratch tokens have been used
			if ( $length == 1 && "" === $this->scratchTokens[0] ) {
				$retval = false;
			} else {
				for ( $i = 0; $i < $length; $i++ ) {
					if ( $token === $this->scratchTokens[$i] ) {
						// If there is a scratch token, remove it from the scratch token list
						unset( $this->scratchTokens[$i] );
						$oathrepo = OATHAuthHooks::getOATHUserRepository();
						$user->setKey( $this );
						$oathrepo->persist( $user );
						// Only return true if we removed it from the database
						$retval = self::SCRATCH_TOKEN;
						break;
					}
				}
			}
		}

It should just need the notification stuff plumbing in (after being designed?) somewhere around there

Should there also be a way to generate a new set of recovery tokens, or is the "fix" for that to disable and then re-enable OATH?

From a user experience POV it would be nice to be able to list the tokens at any time as well. Google allows this on https://myaccount.google.com/security/signinoptions/two-step-verification and it has been handy in the past for me.

In T131788#2707987, @bd808 wrote:

Should there also be a way to generate a new set of recovery tokens, or is the "fix" for that to disable and then re-enable OATH?

Yeah. Having to disable and re-enable is a bad user experience for sure.

From a user experience POV it would be nice to be able to list the tokens at any time as well. Google allows this on https://myaccount.google.com/security/signinoptions/two-step-verification and it has been handy in the past for me.

@csteipp can maybe comment more, but I don't know if I agree with this. The backup codes are a shared secret between the server and user, and we should avoid communicating shared secrets as much as possible. It'd be better to only show the codes once, and if the user wants to see them again, just generate brand new codes.

In T131788#2708008, @Parent5446 wrote:

It'd be better to only show the codes once, and if the user wants to see them again, just generate brand new codes.

I'd be fine with that solution.

A better solution is for MW to just list out the remaining scratch codes left.

In T131788#4808465, @Leaderboard wrote:

A better solution is for MW to just list out the remaining scratch codes left.

I'm not sure how a list somewhere a user isn't going to probably look is a better solution than a notification that they are much more likely to see

T210075: Send notification when 2FA is disabled/T210963: Send an email when 2FA is disabled do some prep work integrating Notifications

Change 990132 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] Add notification when user is running out of recovery codes

https://gerrit.wikimedia.org/r/990132

This message makes more sense in the context of using a token, so ideally IMO it shouldn't be a notification but an interstitial shown after using up the third-to-last token. If a notification is much easier to add, that makes sense, but not sure that is the case?

Maybe both make sense?

An interstitial is dismissed and it’s gone.

A notification (depending on how you deal with it), can still be there for referencing.

They can result in emails (but looks like we might need to wire that in a little differently; the 2FA ones don’t show in the Notifications tab in preferences. I don’t know if this is because they’re marked system, and actually trigger emails anyway) or via Apps too.

They therefore can work without JS.

And they also result in the user getting some notification such as if they log in via apps (rather than needing to do a separate implementation of the interstitial because they reimplement the login screen).

And also, work for our use cases like Striker (combined with the email notifications), where you can use a recovery code on a “third party” site, so wouldn’t see an interstitial inside MW either…

Yeah good points.

Change #990132 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Add notification when user is running out of recovery codes

https://gerrit.wikimedia.org/r/990132

Change #1085919 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_43] Add notification when user is running out of recovery codes

https://gerrit.wikimedia.org/r/1085919

Change #1085923 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_42] Add notification when user is running out of recovery codes

https://gerrit.wikimedia.org/r/1085923

Change #1085924 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_41] Add notification when user is running out of recovery codes

https://gerrit.wikimedia.org/r/1085924

Change #1085925 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_39] Add notification when user is running out of recovery codes

https://gerrit.wikimedia.org/r/1085925

Change #1085925 abandoned by Reedy:

[mediawiki/extensions/OATHAuth@REL1_39] Add notification when user is running out of recovery codes

Reason:

nvm

https://gerrit.wikimedia.org/r/1085925

Change #1085923 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_42] Add notification when user is running out of recovery codes

https://gerrit.wikimedia.org/r/1085923

Change #1085919 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_43] Add notification when user is running out of recovery codes

https://gerrit.wikimedia.org/r/1085919

Change #1085924 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_41] Add notification when user is running out of recovery codes

https://gerrit.wikimedia.org/r/1085924