Page MenuHomePhabricator
Create Task
Maniphest T210963

Send an email when 2FA is disabled
Closed, ResolvedPublic
Actions

Description

If an account has a registered email address in their preferences and their 2FA is removed either via disableOATHAuthForUser.php or via othauth-disable-for-user, send the user an email informing them about that fact, who did it (if possible) and which reason was invoked. This should complement T210075: Send notification when 2FA is disabled. Thanks.

Details

SubjectRepoBranchLines +/-
Add missing oathauth-notifications-(dis|en)able-primary messagesmediawiki/extensions/OATHAuthREL1_40+18 -14
Add missing oathauth-notifications-(dis|en)able-primary messagesmediawiki/extensions/OATHAuthREL1_41+18 -14
Add missing oathauth-notifications-(dis|en)able-primary messagesmediawiki/extensions/OATHAuthREL1_39+18 -14
Add missing oathauth-notifications-(dis|en)able-primary messagesmediawiki/extensions/OATHAuthmaster+18 -14
Send a notification when 2FA is disabledmediawiki/extensions/OATHAuthmaster+184 -6
Send a notification when 2FA is disabledmediawiki/extensions/OATHAuthREL1_35+183 -6
Send a notification when 2FA is disabledmediawiki/extensions/OATHAuthREL1_36+183 -6
Send a notification when 2FA is disabledmediawiki/extensions/OATHAuthREL1_37+183 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

MarcoAurelio created this task.Dec 2 2018, 8:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2018, 8:31 PM
Framawiki added a project: Trust-and-Safety.Dec 2 2018, 9:34 PM
Framawiki added a parent task: T210075: Send notification when 2FA is disabled.
Framawiki subscribed.
Krenair subscribed.Dec 2 2018, 9:53 PM
jrbs moved this task from Backlog to Support on the Trust-and-Safety board.Dec 29 2018, 12:18 PM
• MR70 subscribed.Jan 3 2019, 12:25 PM
jrbs moved this task from Support to 2FA (backlog) on the Trust-and-Safety board.Aug 20 2019, 8:35 AM
Reedy moved this task from Backlog to User Experience on the MediaWiki-extensions-OATHAuth board.Oct 16 2019, 3:58 PM
gerritbot added a comment.Feb 16 2022, 9:15 AM

Change 763190 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/OATHAuth@master] Send a notification when 2FA is disabled

https://gerrit.wikimedia.org/r/763190

gerritbot added a project: Patch-For-Review.Feb 16 2022, 9:15 AM
Reedy closed this task as Resolved.Feb 17 2022, 2:15 PM
Reedy assigned this task to Legoktm.
gerritbot added a comment.Feb 17 2022, 2:17 PM

Change 763190 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Send a notification when 2FA is disabled

https://gerrit.wikimedia.org/r/763190

Reedy mentioned this in T301987: Notify user when 2FA has been enabled.Feb 17 2022, 2:17 PM
gerritbot added a comment.Feb 17 2022, 2:19 PM

Change 763299 had a related patch set uploaded (by Reedy; author: Legoktm):

[mediawiki/extensions/OATHAuth@REL1_37] Send a notification when 2FA is disabled

https://gerrit.wikimedia.org/r/763299

gerritbot added a comment.Feb 17 2022, 2:19 PM

Change 763300 had a related patch set uploaded (by Reedy; author: Legoktm):

[mediawiki/extensions/OATHAuth@REL1_36] Send a notification when 2FA is disabled

https://gerrit.wikimedia.org/r/763300

gerritbot added a comment.Feb 17 2022, 2:20 PM

Change 763301 had a related patch set uploaded (by Reedy; author: Legoktm):

[mediawiki/extensions/OATHAuth@REL1_35] Send a notification when 2FA is disabled

https://gerrit.wikimedia.org/r/763301

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 17 2022, 3:00 PM
Reedy mentioned this in T301992: Insert CheckUser row events during certain 2FA actions.Feb 17 2022, 3:03 PM
Reedy mentioned this in T131788: Users should be notified when only two recovery codes are left.Feb 17 2022, 3:23 PM
gerritbot added a comment.Feb 17 2022, 4:52 PM

Change 763299 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_37] Send a notification when 2FA is disabled

https://gerrit.wikimedia.org/r/763299

gerritbot added a comment.Feb 17 2022, 4:53 PM

Change 763300 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_36] Send a notification when 2FA is disabled

https://gerrit.wikimedia.org/r/763300

gerritbot added a comment.Feb 17 2022, 4:53 PM

Change 763301 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_35] Send a notification when 2FA is disabled

https://gerrit.wikimedia.org/r/763301

Krinkle mentioned this in T303404: ArgumentCountError: Too few arguments to function MediaWiki\Extension\OATHAuth\OATHUserRepository::remove(), 2 passed in /srv/mediawiki/php-1.38.0-wmf.25/extensions/WebAuthn/src/HTMLForm/WebAuthnDisableForm.php on line 114 and exactly 3 expected.Mar 9 2022, 4:47 PM
gerritbot added a comment.Apr 2 2022, 9:34 PM

Change 776327 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] Add missing oathauth-notifications-(dis|en)able-primary messages

https://gerrit.wikimedia.org/r/776327

Jdforrester-WMF mentioned this in T306184: OATHAuth's disableOATHAuthForUser.php script triggers a Notification that can't be sent as MW isn't initialised yet, so causes a production error.Apr 14 2022, 1:43 PM
gerritbot added a comment.Nov 10 2023, 1:25 AM

Change 776327 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Add missing oathauth-notifications-(dis|en)able-primary messages

https://gerrit.wikimedia.org/r/776327

Maintenance_bot removed a project: Patch-For-Review.Nov 10 2023, 1:31 AM
gerritbot added a comment.Nov 18 2023, 3:33 PM

Change 975368 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_41] Add missing oathauth-notifications-(dis|en)able-primary messages

https://gerrit.wikimedia.org/r/975368

gerritbot added a project: Patch-For-Review.Nov 18 2023, 3:33 PM

Change 975369 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_40] Add missing oathauth-notifications-(dis|en)able-primary messages

https://gerrit.wikimedia.org/r/975369

gerritbot added a comment.Nov 18 2023, 3:34 PM

Change 975370 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@REL1_39] Add missing oathauth-notifications-(dis|en)able-primary messages

https://gerrit.wikimedia.org/r/975370

gerritbot added a comment.Nov 18 2023, 3:54 PM

Change 975370 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_39] Add missing oathauth-notifications-(dis|en)able-primary messages

https://gerrit.wikimedia.org/r/975370

gerritbot added a comment.Nov 18 2023, 3:55 PM

Change 975368 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_41] Add missing oathauth-notifications-(dis|en)able-primary messages

https://gerrit.wikimedia.org/r/975368

gerritbot added a comment.Nov 18 2023, 3:55 PM

Change 975369 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_40] Add missing oathauth-notifications-(dis|en)able-primary messages

https://gerrit.wikimedia.org/r/975369

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2023, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits