Page MenuHomePhabricator
Create Task
Maniphest T132525

Remove automatic mark-as-read (of alerts) when you open the popup
Closed, ResolvedPublic
Actions

Description

Once T123018: Revise Sorting of Notifications on the Fly-Out Menus is done, we should remove the anti-feature of marking alerts read automatically when opening the popup.

Per 2016-05-09 meeting, do at same time

Details

SubjectRepoBranchLines +/-
Remove automatic mark-as-read-when-seenmediawiki/extensions/Echomaster+4 -22
Don't mark alerts as read when seenmediawiki/extensions/Echomaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Apr 12 2016, 10:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2016, 10:34 PM
Catrope added a subtask: T123018: Revise Sorting of Notifications on the Fly-Out Menus.Apr 12 2016, 10:34 PM
Poyekhali triaged this task as Medium priority.Apr 13 2016, 3:08 AM
Stevietheman subscribed.Apr 13 2016, 10:45 AM
• Mattflaschen-WMF renamed this task from Remove automatic mark-as-read to Remove automatic mark-as-read (of alerts) when you open the popup.Apr 13 2016, 2:07 PM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 19 2016, 1:01 AM
• jmatazzoni removed a subtask: T123018: Revise Sorting of Notifications on the Fly-Out Menus.Apr 27 2016, 6:06 PM
• jmatazzoni added a parent task: T123018: Revise Sorting of Notifications on the Fly-Out Menus.
MGChecker subscribed.May 1 2016, 6:58 PM
• Mattflaschen-WMF updated the task description. (Show Details)May 9 2016, 9:58 PM
• jmatazzoni mentioned this in T123018: Revise Sorting of Notifications on the Fly-Out Menus.May 12 2016, 12:05 AM
gerritbot subscribed.Jun 10 2016, 5:51 PM

Change 293761 had a related patch set uploaded (by Catrope):
Remove automatic mark-as-read-when-seen

https://gerrit.wikimedia.org/r/293761

gerritbot added a project: Patch-For-Review.Jun 10 2016, 5:51 PM
• jmatazzoni moved this task from Ready for Pickup to Code Review Started on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 13 2016, 5:33 PM
• jmatazzoni moved this task from Code Review Started to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.
Trizek-WMF added a project: User-notice.Jun 14 2016, 10:16 AM
Trizek-WMF subscribed.

To be deployed next week (week 24).

Trizek-WMF moved this task from To Triage to Announce in next Tech/News on the User-notice board.Jun 14 2016, 10:16 AM
gerritbot added a comment.Jun 14 2016, 12:52 PM

Change 294300 had a related patch set uploaded (by Sbisson):
Don't mark alerts as read when seen

https://gerrit.wikimedia.org/r/294300

gerritbot added a comment.Jun 14 2016, 3:34 PM

Change 294300 merged by jenkins-bot:
Don't mark alerts as read when seen

https://gerrit.wikimedia.org/r/294300

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-21_(1.28.0-wmf.7)).Jun 14 2016, 4:00 PM
SBisson moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 14 2016, 4:21 PM
Etonkovidova subscribed.Jun 14 2016, 9:02 PM

Checked ihn betalabs - Alerts red badge when clicked will change to 'seen' status; the alerts messages will not be changed to 'read' status:

Screen Shot 2016-06-14 at 1.57.48 PM.png (417×571 px, 73 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 14 2016, 9:21 PM
Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Jun 16 2016, 1:13 PM
IKhitron awarded a token.Jun 16 2016, 3:09 PM
• jmatazzoni closed this task as Resolved.Jun 16 2016, 10:32 PM
• jmatazzoni claimed this task.
gerritbot added a comment.Jun 21 2016, 11:27 AM

Change 293761 merged by jenkins-bot:
Remove automatic mark-as-read-when-seen

https://gerrit.wikimedia.org/r/293761

Johan moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Jun 23 2016, 12:23 PM
IKhitron subscribed.Jun 24 2016, 1:51 PM

But opening "view changes" does not mark notification as read either.

Johan moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Jun 30 2016, 9:56 AM
IKhitron added a comment.Jun 30 2016, 10:01 AM

Hello? Anyone? It's still a serious bug.

matej_suchanek subscribed.Jun 30 2016, 10:21 AM
In T132525#2417228, @IKhitron wrote:

Hello? Anyone? It's still a serious bug.

Notification is always marked as read after clicking on the primary link, ie. on the notification itself. Maybe create another task about it.

IKhitron added a comment.EditedJun 30 2016, 10:35 AM

Thanks, @matej_suchanek, I'll do that.

IKhitron mentioned this in T139122: Mark read revisions as read (alert popup).Jun 30 2016, 9:36 PM
Trizek-WMF mentioned this in T139147: Mark notifications as read/unread with blue dot does not work in some circumstances.Jul 1 2016, 2:10 PM
matej_suchanek removed a project: Patch-For-Review.Jul 28 2016, 8:28 PM
matej_suchanek unsubscribed.
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL