Page MenuHomePhabricator

Remove all PHP entry points from all Wikimedia-deployed extensions and skins
Closed, ResolvedPublic

Description

Now that all Wikimedia-deployed extensions and skins have been switched over to extension registration, and Wikimedia production has switched over to using them, we should remove the backwards-compatibility shims that very often imply support which doesn't exist for older versions of MediaWiki.

https://codesearch.wmcloud.org/deployed/?q=function_exists%5C(%20%27wfLoadExtension%27%20%5C)&i=nope&files=%5C.php%24&repos=

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/Wikibasemaster+5 -48
mediawiki/extensions/FundraisingEmailUnsubscribemaster+0 -38
mediawiki/extensions/DonationInterfacemaster+0 -39
mediawiki/extensions/Quizmaster+0 -60
mediawiki/extensions/GWToolsetmaster+1 -16
mediawiki/extensions/NewUserMessagemaster+0 -22
mediawiki/extensions/TranslationNotificationsmaster+0 -18
mediawiki/extensions/Wikidata.orgmaster+0 -15
mediawiki/extensions/Newslettermaster+0 -16
mediawiki/extensions/MultimediaViewermaster+11 -125
mediawiki/extensions/CentralAuthmaster+34 -286
mediawiki/extensions/OpenStackManagermaster+0 -28
mediawiki/extensions/VisualEditormaster+0 -32
mediawiki/extensions/CentralNoticemaster+0 -26
mediawiki/extensions/Mathmaster+0 -16
mediawiki/extensions/GuidedTourmaster+0 -26
mediawiki/extensions/WikibaseLexememaster+0 -16
mediawiki/extensions/DismissableSiteNoticemaster+0 -29
mediawiki/extensions/InputBoxmaster+0 -13
mediawiki/extensions/Poemmaster+0 -14
mediawiki/extensions/RelatedArticlesmaster+0 -15
mediawiki/extensions/TemplateDatamaster+0 -14
mediawiki/extensions/Thanksmaster+0 -38
mediawiki/extensions/LabeledSectionTransclusionmaster+0 -38
mediawiki/extensions/TemplateSandboxmaster+0 -36
mediawiki/extensions/TorBlockmaster+0 -15
mediawiki/extensions/Collectionmaster+3 -41
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

This proposal is selected for the Developer-Wishlist voting round and will be added to a MediaWiki page very soon. To the subscribers, or proposer of this task: please help modify the task description: add a brief summary (10-12 lines) of the problem that this proposal raises, topics discussed in the comments, and a proposed solution (if there is any yet). Remember to add a header with a title "Description," to your content. Please do so before February 5th, 12:00 pm UTC.

Change 668213 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Collection@master] Remove php entry point

https://gerrit.wikimedia.org/r/668213

Change 668214 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/LabeledSectionTransclusion@master] Remove php entry point

https://gerrit.wikimedia.org/r/668214

Change 668216 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/TorBlock@master] Remove php entry point

https://gerrit.wikimedia.org/r/668216

Change 668219 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Thanks@master] Remove php entry point

https://gerrit.wikimedia.org/r/668219

Change 668220 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/TemplateSandbox@master] Remove php entry point

https://gerrit.wikimedia.org/r/668220

Change 668213 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Remove php entry point

https://gerrit.wikimedia.org/r/668213

Change 668216 merged by jenkins-bot:
[mediawiki/extensions/TorBlock@master] Remove php entry point

https://gerrit.wikimedia.org/r/668216

Change 668220 merged by jenkins-bot:
[mediawiki/extensions/TemplateSandbox@master] Remove php entry point

https://gerrit.wikimedia.org/r/668220

Change 668214 merged by jenkins-bot:
[mediawiki/extensions/LabeledSectionTransclusion@master] Remove php entry point

https://gerrit.wikimedia.org/r/668214

Change 668219 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Remove php entry point

https://gerrit.wikimedia.org/r/668219

Change 669152 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/CentralNotice@master] Remove php entry point

https://gerrit.wikimedia.org/r/669152

Change 671294 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/RelatedArticles@master] Remove php entry point

https://gerrit.wikimedia.org/r/671294

Change 671297 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/TemplateData@master] Remove php entry point

https://gerrit.wikimedia.org/r/671297

Change 671300 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Poem@master] Remove php entry point

https://gerrit.wikimedia.org/r/671300

Change 671301 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/InputBox@master] Remove php entry point

https://gerrit.wikimedia.org/r/671301

Change 671302 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/WikibaseLexeme@master] Remove php entry point

https://gerrit.wikimedia.org/r/671302

Change 671303 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Math@master] Remove php entry point

https://gerrit.wikimedia.org/r/671303

Change 671534 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/DismissableSiteNotice@master] Remove php entry point

https://gerrit.wikimedia.org/r/671534

Change 671535 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GuidedTour@master] Remove php entry point

https://gerrit.wikimedia.org/r/671535

Change 671297 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Remove php entry point

https://gerrit.wikimedia.org/r/671297

Change 671294 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Remove php entry point

https://gerrit.wikimedia.org/r/671294

Change 671300 merged by jenkins-bot:
[mediawiki/extensions/Poem@master] Remove php entry point

https://gerrit.wikimedia.org/r/671300

Change 671301 merged by jenkins-bot:
[mediawiki/extensions/InputBox@master] Remove php entry point

https://gerrit.wikimedia.org/r/671301

Change 671302 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove php entry point

https://gerrit.wikimedia.org/r/671302

Change 671303 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Remove php entry point

https://gerrit.wikimedia.org/r/671303

Change 671534 merged by jenkins-bot:
[mediawiki/extensions/DismissableSiteNotice@master] Remove php entry point

https://gerrit.wikimedia.org/r/671534

Change 671535 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@master] Remove php entry point

https://gerrit.wikimedia.org/r/671535

Change 669152 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Remove php entry point

https://gerrit.wikimedia.org/r/669152

Change 703022 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] Remove the PHP entry point

https://gerrit.wikimedia.org/r/703022

Change 703022 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove the PHP entry point

https://gerrit.wikimedia.org/r/703022

Change 716534 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/skins/Mask@master] Remove php entry point

https://gerrit.wikimedia.org/r/716534

Change 743652 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/NewUserMessage@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743652

Change 743666 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GWToolset@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743666

Change 743667 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MultimediaViewer@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743667

Change 743668 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Newsletter@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743668

Change 743669 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Quiz@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743669

Change 743670 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/OpenStackManager@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743670

Change 743670 merged by jenkins-bot:

[mediawiki/extensions/OpenStackManager@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743670

Change 743671 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralAuth@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743671

Change 743678 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FundraisingEmailUnsubscribe@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743678

Change 743671 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743671

Change 743667 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743667

Change 743668 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743668

Change 743990 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikidata.org@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743990

Change 743990 merged by jenkins-bot:

[mediawiki/extensions/Wikidata.org@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743990

How to remove the php entry points from Wikibase? The files client/WikibaseClient.php and repo/Wikibase.php could be removed and some docs needs adjustment to not refer the files.
But the top level Wikibase.php is used by jenkins/CI as far as I know, how that works together with T258845?

Change 744775 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DonationInterface@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/744775

Change 743433 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TranslationNotifications@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743433

Change 743433 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743433

Change 743652 merged by jenkins-bot:

[mediawiki/extensions/NewUserMessage@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743652

Change 743666 merged by jenkins-bot:

[mediawiki/extensions/GWToolset@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743666

Change 743669 merged by jenkins-bot:

[mediawiki/extensions/Quiz@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743669

Change 744775 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/744775

Change 743678 merged by jenkins-bot:

[mediawiki/extensions/FundraisingEmailUnsubscribe@master] Remove PHP entry point

https://gerrit.wikimedia.org/r/743678

Change 813966 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Wikibase@master] Remove php entry points

https://gerrit.wikimedia.org/r/813966

Change 813966 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove php entry points

https://gerrit.wikimedia.org/r/813966

Pppery subscribed.

The code search at the top of the task returns no results. Assuming this was done and the task was never closed.