Page MenuHomePhabricator

Add repository field to EntityId
Closed, ResolvedPublic

Description

  • the string returned by getSerialization() should include the prefix.
  • equals() should consider the prefix.

New methods to add:

  • getRepoName() (or getRepoPrefix, or getOrigin, or...); returns "" for the local repo.
  • getLocalPart() (this might not even be needed, but nice to have)
  • isForeign() (to check and fail in some critical code pathes)

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
DuplicateNone
ResolvedNone
ResolvedNone
ResolvedNone
OpenNone
OpenNone
StalledNone
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
Resolveddaniel
ResolvedJakob_WMDE

Event Timeline

daniel moved this task from accepted to doing on the WMDE-TLA-Team board.

Done in https://github.com/wmde/WikibaseDataModel/pull/678, however blocked on follow up discussion
https://github.com/wmde/WikibaseDataModel/pull/681.

Pending: needs a release (6.2) of the WikibaseDataModel component.

WMDE-leszek added a subscriber: WMDE-leszek.

We've decided to go the way taken in https://github.com/wmde/WikibaseDataModel/pull/678. The approach could be changed if the better solution is proposed in the future.

WkikibaseDataModel 6.2 released https://github.com/wmde/WikibaseDataModel/releases/tag/6.2.0