Page MenuHomePhabricator
Create Task
Maniphest T145516

Add repository field to EntityId
Closed, ResolvedPublic
Actions

Description

  • the string returned by getSerialization() should include the prefix.
  • equals() should consider the prefix.

New methods to add:

  • getRepoName() (or getRepoPrefix, or getOrigin, or...); returns "" for the local repo.
  • getLocalPart() (this might not even be needed, but nice to have)
  • isForeign() (to check and fail in some critical code pathes)

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 ResolvedLydia_PintscherT146637 Wikidata 2016 Q4 goals
 ResolvedLydia_PintscherT150179 Wikidata 2017 Q1 goals
 ResolvedLydia_PintscherT76007 [Epic] add ability to link/refer to foreign items and properties (federation)
 ResolvedLydia_PintscherT149580 Allow access to entity data stored on "foreign" repositories (federation)
 ResolveddanielT133381 Add support for foreign entities to EntityId
 ResolvedJakob_WMDET145516 Add repository field to EntityId

Event Timeline

Jakob_WMDE created this task.Sep 13 2016, 2:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2016, 2:24 PM
Jakob_WMDE added a parent task: T133381: Add support for foreign entities to EntityId.Sep 13 2016, 2:25 PM
Addshore moved this task from incoming to ready to go on the Wikidata board.Sep 16 2016, 6:19 PM
daniel added a project: WMDE-TLA-Team.Sep 19 2016, 1:43 PM
daniel moved this task from proposed to accepted on the WMDE-TLA-Team board.Sep 19 2016, 1:46 PM
daniel moved this task from accepted to doing on the WMDE-TLA-Team board.
Jakob_WMDE moved this task from doing to done on the WMDE-TLA-Team board.Sep 26 2016, 9:31 AM
daniel subscribed.Sep 27 2016, 3:31 PM

Done in https://github.com/wmde/WikibaseDataModel/pull/678, however blocked on follow up discussion
https://github.com/wmde/WikibaseDataModel/pull/681.

Pending: needs a release (6.2) of the WikibaseDataModel component.

daniel added a project: Patch-For-Review.Sep 27 2016, 3:31 PM
daniel moved this task from done to needs review on the WMDE-TLA-Team board.
Lydia_Pintscher moved this task from ready to go to in progress on the Wikidata board.Oct 17 2016, 2:52 PM
WMDE-leszek moved this task from needs review to done on the WMDE-TLA-Team board.Oct 19 2016, 8:17 AM
WMDE-leszek subscribed.

We've decided to go the way taken in https://github.com/wmde/WikibaseDataModel/pull/678. The approach could be changed if the better solution is proposed in the future.

WkikibaseDataModel 6.2 released https://github.com/wmde/WikibaseDataModel/releases/tag/6.2.0

daniel closed this task as Resolved.Oct 31 2016, 4:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL