Page MenuHomePhabricator
Create Task
Maniphest T152139

Update Maintenance scripts in extensions to use $this->requireExtension()
Open, MediumPublic
Actions

Description

Maintenance scripts from extensions are special in that they can be run from the CLI without the extension ever being enabled, causing weird issues. We created $this->requireExtension('ExtensionName') for that (it goes in the constructor, and is checked after extensions are loaded). Only a few scripts have been updated to use it though.

Documentation: https://www.mediawiki.org/wiki/Manual:Writing_maintenance_scripts#Extensions

Example commit: rECRE62b0bc4fe579: Set extension dependency in maintenance scripts

Name of MediaWiki extensionAssignee to work on it
AbuseFilterPppery
AntiSpoofPppery
ArticleFeedbackv5@subins2000
Athena@subins2000
BlockAndNuke@subins2000
BlueSpiceExtendedSearch@subins2000 @Osnard
BlueSpiceExtensions@RazeSoldier
BlueSpiceFoundation@RazeSoldier
Cargo@IvanFon
CentralAuth@subins2000
CentralNotice@Georggi199
CheckUserPppery
Cognate@Zoranzoki21
CollapsibleVector@RazeSoldier
ConfirmEdit@divadsn
ContentTranslation@Zoranzoki21
Contributors@FilipGCI
CreditsSource@FilipGCI
DisableAccount@RazeSoldier
DonationInterface@Zoranzoki21
Echo@MtDu
EditAccount@Jayprakash12345
ExtensionDistributor@Jayprakash12345
Flow@Phantom42
GeoData@FilipGCI
GlobalBlocking@Jayprakash12345
GlobalCssJsAlready done. See https://pastebin.com/G1u5yy5W
GlobalUsage@Jayprakash12345
HitCounters@Jayprakash12345
LocalisationUpdate@Jayprakash12345
MassMessage@RazeSoldier
Math@IvanFon
MathSearch@Phantom42
Newsletter@Phantom42
OATHAuth@MtDu
OAuth@divadsn
ORES@Zoranzoki21
PagedTiffHandler@Zoranzoki21
PageImages@Zoranzoki21
Renameuser@Jayprakash12345
ReplaceText@Jayprakash12345
SecurePoll@Jayprakash12345
ShortUrl@RazeSoldier
SyntaxHighlight_GeSHi@Zoranzoki21
TitleKey@Jayprakash12345
TorBlock@divadsn
TranslationNotifications@Jayprakash12345
UniversalLanguageSelectorPer source of code it is already done.
UploadWizard@Zoranzoki21
UrlShortener@MtDu
VisualEditor@IvanFon
wikihiero@MaxSem
ProofreadPage@Jayprakash12345
BibManager@Jayprakash12345
SecureSessions@Jayprakash12345
PluggableSSO@Jayprakash12345
StopForumSpam@Jayprakash12345
WikibaseLexeme@Jayprakash12345
CongressLookup@Jayprakash12345
WikimediaMaintenance@Phantom42

Following Extensions are in awaiting, this can be done once they will Extension registration.

Name of MediaWiki extensionAssignee to work on it
GWToolset
WikiLexicalData
RevisionCommentSupplement
CirrusSearch
CommonMessages
OpenID
SemanticTasks
SimpleFarm
SphinxSearch
TimedMediaHandler
UserGroups
Wikibase

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/CirrusSearchmaster+20 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/WikimediaMaintenancemaster+46 -0
Call Maintenance::requireExtensionmediawiki/extensions/Translatemaster+20 -0
Call Maintenance::requireExtensionmediawiki/extensions/FlaggedRevsmaster+11 -0
Call Maintenance::requireExtensionmediawiki/extensions/BlueSpiceEchoConnectormaster+1 -0
Call Maintenance::requireExtensionmediawiki/extensions/BlueSpiceFoundationmaster+1 -0
Call Maintenance::requireExtensionmediawiki/extensions/BlueSpicePermissionManagermaster+1 -0
Call Maintenance::requireExtensionmediawiki/extensions/WikibaseQualityConstraintsmaster+1 -0
Call Maintenance::requireExtensionmediawiki/extensions/WikibaseLexememaster+3 -8
Call Maintenance::requireExtensionmediawiki/extensions/LDAPProvidermaster+5 -0
Call Maintenance::requireExtensionmediawiki/extensions/MediaWikiAuthmaster+1 -0
Call Maintenance::requireExtensionmediawiki/extensions/TEImaster+1 -0
Call Maintenance::requireExtensionmediawiki/extensions/GWToolsetmaster+2 -1
Call Maintenance::requireExtensionmediawiki/extensions/ORESmaster+3 -6
Call Maintenance::requireExtensionmediawiki/extensions/SecurePollmaster+19 -16
Call Maintenance::requireExtensionmediawiki/extensions/AdvancedMetamaster+1 -0
Call Maintenance::requireExtensionmediawiki/extensions/TimedMediaHandlermaster+4 -1
Call Maintenance::requireExtensionmediawiki/extensions/Flowmaster+2 -0
Call Maintenance::requireExtensionmediawiki/extensions/Kartographermaster+1 -0
Call Maintenance::requireExtensionmediawiki/extensions/CentralAuthmaster+5 -0
Call Maintenance::requireExtensionmediawiki/extensions/PageTriagemaster+5 -3
Call Maintenance::requireExtensionmediawiki/extensions/EntitySchemamaster+3 -8
Make requireExtension calls conditionalmediawiki/extensions/DonationInterfacemaster+18 -6
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/WikibaseLexememaster+2 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/CongressLookupmaster+18 -2
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/SecureSessionsmaster+7 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/PluggableSSOmaster+2 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/StopForumSpammaster+6 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/NSFileRepomaster+6 -0
Correct Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/ArticleFeedbackv5master+14 -7
Correct Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/BlueSpiceAvatarsmaster+1 -1
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/BlueSpiceSMWConnectormaster+11 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/ApprovedRevsmaster+4 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/PageTriagemaster+17 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/EducationProgrammaster+9 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/PropertySuggestermaster+1 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/CirrusSearchmaster+1 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/WikibaseQualityConstraintsmaster+1 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/GettingStartedmaster+3 -0
Use $this->requireExtension() in maintenance scriptsmediawiki/extensions/ReadingListsmaster+3 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/ReplaceTextmaster+2 -0
Update Maintenance scripts in extensions to use $this->requireExtension()mediawiki/extensions/ContentTranslationmaster+6 -0
Update Maintenance scripts in extensions to use $this->requireExtension()mediawiki/extensions/DonationInterfacemaster+7 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/EditAccountmaster+2 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/HitCountersmaster+6 -0
Update Maintenance scripts in extensions to use $this->requireExtension()mediawiki/extensions/UploadWizardmaster+2 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/BibManagermaster+4 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/ProofreadPagemaster+4 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/GlobalUsagemaster+2 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/GlobalBlockingmaster+2 -0
Update Maintenance scripts in extensions to use $this->requireExtension()mediawiki/extensions/ORESmaster+4 -0
Update maintenance script to use $this->requireExtension()mediawiki/extensions/DisableAccountmaster+2 -0
Update Maintenance scripts in extensions to use $this->requireExtension()mediawiki/extensions/SyntaxHighlight_GeSHimaster+4 -0
Update Maintenance scripts in extensions to use $this->requireExtension()mediawiki/extensions/PagedTiffHandlermaster+2 -0
Correct $this->requireExtension() for ExtensionDistributormediawiki/extensions/ExtensionDistributormaster+1 -1
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/PageImagesmaster+2 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/SecurePollmaster+2 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/Renameusermaster+4 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/LocalisationUpdatemaster+2 -0
Update maintenance scripts to use $this->requireExtension()mediawiki/extensions/CollapsibleVectormaster+1 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/TranslationNotificationsmaster+9 -0
Update maintenance scipts to use $this->requireExtensionmediawiki/extensions/TitleKeymaster+2 -0
Update maintenance scipts to use $this->requireExtension()mediawiki/extensions/ShortUrlmaster+1 -0
Update maintenance scipts to use $this->requireExtensionmediawiki/extensions/cldrmaster+1 -0
Update maintenance scipts to use $this->requireExtensionmediawiki/extensions/BlueSpiceExtensionsmaster+19 -1
Update maintenance scipts to use $this->requireExtensionmediawiki/extensions/BlueSpiceFoundationmaster+9 -5
Update maintenance script to use $this->requireExtension()mediawiki/extensions/MassMessagemaster+1 -0
Update Maintenance scripts to use requireExtension()mediawiki/extensions/BlueSpiceExtendedSearchmaster+3 -4
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/Cognatemaster+3 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/ExtensionDistributormaster+1 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/BlueSpiceExtendedSearchmaster+5 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/CentralNoticemaster+5 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/OAuthmaster+3 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/TorBlockmaster+1 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/ConfirmEditmaster+1 -0
Update Maintenance scripts to use requireExtension()mediawiki/extensions/CentralAuthmaster+18 -0
Update Maintenance scripts to use requireExtension()mediawiki/extensions/Athenamaster+17 -10
Update Maintenance scripts to use requireExtension()mediawiki/extensions/BlockAndNukemaster+1 -0
Update Maintenance scripts to use requireExtension()mediawiki/extensions/ArticleFeedbackv5master+6 -0
Updated Cargo maintenance scripts to use $this->requireExtension()mediawiki/extensions/Cargomaster+3 -6
Make maintainance scripts use `$this->requireExtension()`mediawiki/extensions/AntiSpoofmaster+12 -0
Updated VisualEditor maintenance scripts to use $this->requireExtension()mediawiki/extensions/VisualEditormaster+1 -0
Updated maintenance scripts to use $this->requireExtension()mediawiki/extensions/EditAccountmaster+1 -0
Make maintainance scripts use `$this->requireExtension()`mediawiki/extensions/CheckUsermaster+6 -0
Make maintenance scripts use $this->requireExtension()mediawiki/extensions/AbuseFiltermaster+8 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/Echomaster+17 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/Flowmaster+66 -0
Update maintenance scripts to use $this->requireExtensionmediawiki/extensions/MathSearchmaster+17 -0
Update maintenance script to use $this->requireExtensionmediawiki/extensions/Newslettermaster+1 -0
Update Maintenance script to use $this->requireExtension()mediawiki/extensions/Contributorsmaster+2 -1
Update Maintenance script to use $this->requireExtension()mediawiki/extensions/CreditsSourcemaster+1 -0
Update Maintenance script to use $this->requireExtension()mediawiki/extensions/GeoDatamaster+1 -0
Use requireExtension()mediawiki/extensions/wikihieromaster+1 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/OATHAuthmaster+1 -0
Update Maintenance scripts to use $this->requireExtension()mediawiki/extensions/UrlShortenermaster+1 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jayprakash12345 updated the task description. (Show Details)Feb 9 2018, 9:53 AM
Jayprakash12345 mentioned this in rEPSObbdeab77d57b: Use $this->requireExtension() in maintenance scripts.Feb 9 2018, 11:14 AM
RazeSoldier added a project: patch-welcome.Feb 9 2018, 12:01 PM
RazeSoldier added a comment.Feb 9 2018, 12:55 PM

I have a question. Maintenance::requireExtension() is used to load the extension. But how does it load the extension? Via extension.json?

RazeSoldier added a comment.Feb 9 2018, 1:01 PM

I saw this manual.

This will only work for extensions that use extension.json.

So should RevisionCommentSupplement extension be ruled out? This extension does not have extension.json.

TheDJ subscribed.Feb 9 2018, 1:04 PM
In T152139#3958135, @RazeSoldier wrote:

This will only work for extensions that use extension.json.

So should RevisionCommentSupplement extension be ruled out? This extension does not have extension.json.

Not necessarily, but it does mean that fixing it will be blocked, until the point that that extension is converted to make use of extension.json

TheDJ added a comment.Feb 9 2018, 1:05 PM
In T152139#3958111, @RazeSoldier wrote:

I have a question. Maintenance::requireExtension() is used to load the extension. But how does it load the extension? Via extension.json?

LocalSettings.php is responsible for loading extensions. The extension cannot force an extension to be loaded.

subins2000 unsubscribed.Feb 9 2018, 1:11 PM
RazeSoldier added a comment.Feb 9 2018, 1:15 PM

I understand why these extensions are placed at the end of the description.

gerritbot added a comment.Feb 9 2018, 1:33 PM

Change 409299 merged by jenkins-bot:
[mediawiki/extensions/StopForumSpam@master] Use $this->requireExtension() in maintenance scripts

https://gerrit.wikimedia.org/r/409299

gerritbot added a comment.Feb 9 2018, 1:35 PM

Change 409296 merged by jenkins-bot:
[mediawiki/extensions/PluggableSSO@master] Use $this->requireExtension() in maintenance scripts

https://gerrit.wikimedia.org/r/409296

gerritbot added a comment.Feb 9 2018, 1:35 PM

Change 409294 merged by jenkins-bot:
[mediawiki/extensions/SecureSessions@master] Use $this->requireExtension() in maintenance scripts

https://gerrit.wikimedia.org/r/409294

gerritbot added a comment.Feb 9 2018, 2:19 PM

Change 409303 merged by jenkins-bot:
[mediawiki/extensions/CongressLookup@master] Use $this->requireExtension() in maintenance scripts

https://gerrit.wikimedia.org/r/409303

gerritbot added a comment.Feb 10 2018, 8:47 AM

Change 409300 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use $this->requireExtension() in maintenance scripts

https://gerrit.wikimedia.org/r/409300

gerritbot added a comment.Mar 1 2018, 10:26 PM

Change 415757 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Make requireExtension calls conditional

https://gerrit.wikimedia.org/r/415757

gerritbot added a comment.Mar 1 2018, 10:52 PM

Change 415757 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Make requireExtension calls conditional

https://gerrit.wikimedia.org/r/415757

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Mar 6 2018, 12:01 PM
gerritbot added a comment.Apr 30 2018, 9:04 AM

Change 429750 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[mediawiki/extensions/CirrusSearch@master] Update maintenance scripts to use $this->requireExtension

https://gerrit.wikimedia.org/r/429750

Gopavasanth subscribed.Apr 30 2018, 12:41 PM

Currently, are all the extensions are done are extension remaining (or) to be done? As so far with the above main list.

Smalyshev updated the task description. (Show Details)Apr 30 2018, 7:38 PM
Smalyshev added a subscriber: subins2000.
Jayprakash12345 mentioned this in rEBSSMWCd0671388f01d: Final NoteDb migration updates.Jun 8 2018, 11:26 PM
Georggi199 mentioned this in rECOG41d37eab2088: Final NoteDb migration updates.Jun 9 2018, 12:00 AM
Georggi199 mentioned this in rEBSES23b40ba3ad57: Final NoteDb migration updates.Jun 9 2018, 1:30 AM
Jayprakash12345 mentioned this in rEWLE6a5468e55de2: Final NoteDb migration updates.Jun 9 2018, 12:15 PM
Umherirrender mentioned this in rERLSe7119f541d69: Final NoteDb migration updates.Jun 11 2018, 12:41 AM
Jayprakash12345 mentioned this in rEPSOc5e2fd3018a3: Final NoteDb migration updates.Jun 11 2018, 11:06 AM
nikitavbv updated the task description. (Show Details)Jun 15 2018, 7:33 PM
gerritbot added a comment.Jun 15 2018, 7:47 PM

Change 440563 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[mediawiki/extensions/WikimediaMaintenance@master] Update Maintenance scripts to use $this->requireExtension()

https://gerrit.wikimedia.org/r/440563

• Phabricator_maintenance moved this task from Doing to Backlog on the good first task board.Sep 24 2018, 9:57 AM
PFWOz subscribed.EditedNov 28 2018, 8:34 PM

Is it expected for this to break these extensions on 1.27 LTS? Since this line was added I've had to comment it out in TitleKey in order to run update.php without a "Call to undefined method RebuildTitleKeys::requireExtension()" error.

TheDJ added a comment.Nov 28 2018, 8:57 PM

@PFWOz yes. We always advise people to use extensions that are of the same branch version as core. So you shouldn't use a 1.32 version of an extension on an LTS 1.27 release of core. We provide no guarantees that this will work, and only after 1.27 we are keeping a limited set of information per extension that keeps track of compatibility (But because of how new that is and the enormous backlog, I wouldn't rely on this information yet to judge actual compatibility).

Same release branch of both extensions and core is your best bet.

PFWOz added a comment.Nov 28 2018, 9:13 PM

@TheDJ Thanks. I'll request backports of some significant fixes to the extension that were made after REL1_27 was cut. Should hopefully be possible since the only breaking change appears to be the use of requireExtension() in the maintenance script.

gerritbot added a comment.Aug 10 2019, 9:00 PM

Change 529552 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/AdvancedMeta@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529552

gerritbot added a comment.Aug 10 2019, 9:02 PM

Change 529553 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/CentralAuth@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529553

gerritbot added a comment.Aug 10 2019, 9:12 PM

Change 529555 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/EntitySchema@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529555

gerritbot added a comment.Aug 10 2019, 9:13 PM

Change 529556 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Flow@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529556

gerritbot added a comment.Aug 10 2019, 9:14 PM

Change 529557 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Kartographer@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529557

gerritbot added a comment.Aug 10 2019, 9:15 PM

Change 529558 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/LDAPProvider@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529558

gerritbot added a comment.Aug 10 2019, 9:17 PM

Change 529560 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ORES@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529560

gerritbot added a comment.Aug 10 2019, 9:19 PM

Change 529561 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/PageTriage@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529561

gerritbot added a comment.Aug 10 2019, 9:23 PM

Change 529563 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SecurePoll@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529563

gerritbot added a comment.Aug 10 2019, 9:25 PM

Change 529564 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/TEI@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529564

gerritbot added a comment.Aug 10 2019, 9:26 PM

Change 529565 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/TimedMediaHandler@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529565

gerritbot added a comment.Aug 10 2019, 9:29 PM

Change 529566 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/WikibaseLexeme@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529566

gerritbot added a comment.Aug 10 2019, 9:29 PM

Change 529567 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/WikibaseQualityConstraints@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529567

gerritbot added a comment.Aug 10 2019, 9:33 PM

Change 529568 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/FlaggedRevs@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529568

gerritbot added a comment.Aug 10 2019, 9:33 PM

Change 529555 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529555

gerritbot added a comment.Aug 10 2019, 9:36 PM

Change 529569 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Translate@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529569

gerritbot added a comment.Aug 10 2019, 9:39 PM

Change 529570 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/BlueSpiceEchoConnector@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529570

gerritbot added a comment.Aug 10 2019, 9:40 PM

Change 529571 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/BlueSpiceFoundation@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529571

gerritbot added a comment.Aug 10 2019, 9:41 PM

Change 529573 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/BlueSpicePermissionManager@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529573

gerritbot added a comment.Aug 10 2019, 9:42 PM

Change 529575 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GWToolset@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529575

gerritbot added a comment.Aug 10 2019, 9:43 PM

Change 529576 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/MediaWikiAuth@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529576

gerritbot added a comment.Aug 10 2019, 9:45 PM

Change 529557 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529557

gerritbot added a comment.Aug 10 2019, 9:45 PM

Change 529561 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529561

gerritbot added a comment.Aug 10 2019, 9:45 PM

Change 529553 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529553

gerritbot added a comment.Aug 10 2019, 9:46 PM

Change 529556 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529556

gerritbot added a comment.Aug 10 2019, 10:04 PM

Change 529565 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529565

gerritbot added a comment.Aug 10 2019, 10:04 PM

Change 529552 merged by jenkins-bot:
[mediawiki/extensions/AdvancedMeta@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529552

gerritbot added a comment.Aug 10 2019, 10:04 PM

Change 529563 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529563

gerritbot added a comment.Aug 10 2019, 10:04 PM

Change 529560 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529560

Umherirrender subscribed.Aug 10 2019, 10:15 PM

At the moment for all extensions the necessary patch sets exists

gerritbot added a comment.Aug 10 2019, 10:20 PM

Change 529575 merged by jenkins-bot:
[mediawiki/extensions/GWToolset@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529575

Umherirrender mentioned this in rEAME9bbab10b147c: Call Maintenance::requireExtension.Aug 10 2019, 10:21 PM
gerritbot added a comment.Aug 10 2019, 11:53 PM

Change 529566 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529566

gerritbot added a comment.Aug 10 2019, 11:53 PM

Change 529567 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529567

gerritbot added a comment.Aug 10 2019, 11:56 PM

Change 529564 merged by jenkins-bot:
[mediawiki/extensions/TEI@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529564

gerritbot added a comment.Aug 10 2019, 11:56 PM

Change 529576 merged by jenkins-bot:
[mediawiki/extensions/MediaWikiAuth@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529576

gerritbot added a comment.Aug 10 2019, 11:56 PM

Change 529558 merged by jenkins-bot:
[mediawiki/extensions/LDAPProvider@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529558

Umherirrender mentioned this in rEBQCcd7720129851: Call Maintenance::requireExtension.Aug 11 2019, 12:07 AM
Umherirrender mentioned this in rELDQ5c4546b8cb1f: Call Maintenance::requireExtension.Aug 11 2019, 12:11 AM
Umherirrender mentioned this in rEMWA2f6cc1b3afbc: Call Maintenance::requireExtension.Aug 11 2019, 12:30 AM
gerritbot added a comment.Aug 11 2019, 7:04 AM

Change 529573 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePermissionManager@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529573

Umherirrender mentioned this in rEBSJ20d8a984e4e0: Call Maintenance::requireExtension.Aug 11 2019, 7:07 AM
gerritbot added a comment.Aug 11 2019, 7:08 AM

Change 529571 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529571

gerritbot added a comment.Aug 11 2019, 7:09 AM

Change 529570 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceEchoConnector@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529570

Kizule updated the task description. (Show Details)Aug 11 2019, 1:14 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 5:01 PM
gerritbot added a comment.Aug 20 2019, 10:09 PM

Change 529568 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529568

gerritbot added a comment.Aug 21 2019, 7:17 AM

Change 529569 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Call Maintenance::requireExtension

https://gerrit.wikimedia.org/r/529569

Aklapper added a comment.Sep 10 2019, 7:35 AM

Remaining patches to improve:

Chtnnh subscribed.Feb 27 2020, 8:34 PM

@Aklapper Hello, I am a new contributor to wikimedia, can I help out with fixing this issue?

Thanks,
Chaitanya

Kizule added a comment.Feb 28 2020, 6:18 AM
In T152139#5924628, @Chtnnh wrote:

@Aklapper Hello, I am a new contributor to wikimedia, can I help out with fixing this issue?

Thanks,
Chaitanya

Hello @Chtnnh, sure. Everyone are welcome to contribute. If you need help, be free to ask.

Aklapper removed projects: good first task, MediaWiki-Maintenance-system.Feb 28 2020, 11:19 AM

@Chtnnh: Hi and welcome!

I am currently unsure what is the status of this task, and I miss a clear way to identify which extensions still require work.

I'm going to remove good first task as the list above is outdated, and due to T152139#2845279.

$:acko\> grep -R "extends Maintenance" | cut -d'/' -f1 | sort -n | uniq -c
      1 AbuseFilter
      1 AdvancedMeta
      1 AntiSpoof
      1 ApprovedRevs
      4 ArticleFeedbackv5
     10 Athena
      2 BibManager
      1 BlockAndNuke
      1 BlueSpiceAvatars
      1 BlueSpiceEchoConnector
      1 BlueSpiceExtendedSearch
      1 BlueSpiceExtendedStatistics
      6 BlueSpiceFoundation
      2 BlueSpiceSMWConnector
      1 BounceHandler
      3 Cargo
     19 CentralAuth
      1 CentralNotice
      2 CheckUser
     18 CirrusSearch
      1 cldr
      8 CodeReview
      4 Cognate
      1 CollapsibleVector
      1 CommonMessages
      3 ConfirmEdit
      4 ContentTranslation
      1 Contributors
      1 CreditsSource
      1 DisableAccount
      6 DonationInterface
      6 Echo
      1 EntitySchema
      1 ExtensionDistributor
      1 ExternalArticles
     11 FlaggedRevs
     16 Flow
      1 GeoData
      1 GlobalBlocking
      1 GlobalCssJs
      1 GlobalUsage
      1 GoogleLogin
      1 GrowthExperiments
      1 GWToolset
      1 HitCounters
      2 Jade
      2 JADE
      1 Kartographer
      1 LdapAuthentication
      5 LDAPProvider
      1 LocalisationUpdate
      1 LoginNotify
      1 MassMessage
      2 Math
     14 MathSearch
      1 MediaWikiAuth
      2 Newsletter
      3 NSFileRepo
      4 OATHAuth
      1 OAuth
      1 OpenID
      1 OpenStackManager
      1 OracleTextSearch
      7 ORES
      1 PageAssessments
      1 PagedTiffHandler
      1 PageImages
      8 PageTriage
      1 PhabTaskGraph
      1 PluggableSSO
      1 PropertySuggester
      4 ReadingLists
      2 Renameuser
      1 ReplaceText
      3 RevisionCommentSupplement
     10 SecurePoll
      1 SecureSessions
      1 ShortUrl
      1 SimpleFarm
      1 SpamBlacklist
      1 SphinxSearch
      1 StopForumSpam
      2 SyntaxHighlight_GeSHi
      1 TEI
      3 TimedMediaHandler
      1 TitleKey
      1 TorBlock
     27 Translate
      2 TranslationNotifications
      4 UniversalLanguageSelector
      1 UploadWizard
      2 UrlShortener
      1 UserGroups
      1 VisualEditor
     20 Wikibase
      1 WikibaseLexeme
      4 WikibaseQualityConstraints
      1 Wikidata.org
      1 wikihiero
      5 WikiLexicalData
     30 WikimediaMaintenance
Aklapper removed a project: Patch-For-Review.Feb 28 2020, 11:20 AM
Aklapper updated the task description. (Show Details)
Chtnnh added a comment.Feb 28 2020, 12:08 PM

@Aklapper I see. This is unfortunate. But can you explain how you are checking for which extensions still require this fix? This way anyone can check or contribute to the list above and interested contributors can come along and fix it.

What say?

TerraCodes unsubscribed.Mar 1 2020, 9:11 AM
gerritbot added a comment.Jul 14 2020, 6:50 PM

Change 440563 abandoned by Umherirrender:
[mediawiki/extensions/WikimediaMaintenance@master] Update Maintenance scripts to use $this->requireExtension()

Reason:
Cannot work as described in comment

https://gerrit.wikimedia.org/r/440563

gerritbot added a comment.Aug 24 2020, 12:31 PM

Change 429750 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Update maintenance scripts to use $this->requireExtension

https://gerrit.wikimedia.org/r/429750

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 24 2020, 1:00 PM
Umherirrender unsubscribed.Feb 27 2021, 9:50 PM
Umherirrender mentioned this in rEPS37ad5cee71ac: Use $this->requireExtension() in maintenance scripts.May 25 2023, 6:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits