Page MenuHomePhabricator
Create Task
Maniphest T153463

Use a dispatching property info lookup in Wikibase client
Closed, ResolvedPublic
Actions

Description

Given all preparatory work described in T151307, and in particular introducing the DispatchingPropertyInfoLookup class in T152103 we could now make property info related code in ClientStore/WikibaseStore work with foreign properties too.

Details

SubjectRepoBranchLines +/-
Use DispatchingPropertyInfoLookup in DirectSqlStoremediawiki/extensions/Wikibasemaster+49 -5
Add DispatchingPropertyInfoStoremediawiki/extensions/Wikibasemaster+236 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 ResolvedLydia_PintscherT146637 Wikidata 2016 Q4 goals
 ResolvedLydia_PintscherT150179 Wikidata 2017 Q1 goals
 ResolvedLydia_PintscherT76007 [Epic] add ability to link/refer to foreign items and properties (federation)
 ResolvedLydia_PintscherT149580 Allow access to entity data stored on "foreign" repositories (federation)
 ResolvedWMDE-leszekT155623 Allow optional use of data retrieval services from Client in Repo
 ResolvedWMDE-leszekT148141 Use dispatching services in Client
 ResolvedWMDE-leszekT153463 Use a dispatching property info lookup in Wikibase client

Event Timeline

WMDE-leszek created this task.Dec 16 2016, 3:26 PM
WMDE-leszek moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot subscribed.Dec 16 2016, 4:57 PM

Change 327760 had a related patch set uploaded (by WMDE-leszek):
Add DispatchingPropertyInfoStore

https://gerrit.wikimedia.org/r/327760

gerritbot added a project: Patch-For-Review.Dec 16 2016, 4:57 PM

Change 327761 had a related patch set uploaded (by WMDE-leszek):
Use DispatchingPropertyInfoStore in DirectSqlStore

https://gerrit.wikimedia.org/r/327761

WMDE-leszek moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Dec 16 2016, 4:58 PM
WMDE-leszek removed a project: Patch-For-Review.Dec 19 2016, 10:53 AM
WMDE-leszek updated the task description. (Show Details)

Some remarks I made initially does not seem valid, edited task description.

WMDE-leszek moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.Dec 19 2016, 10:53 AM
gerritbot added a comment.Dec 20 2016, 4:14 PM

Change 327760 abandoned by WMDE-leszek:
Add DispatchingPropertyInfoStore

Reason:
This was not the right approach. Ditching this in favour of the full split of PropertyInfoLookup and PropertyInfoStore interfaces: I0ba91dd66291d9bb77ae6ce5b16d295deae69c81

https://gerrit.wikimedia.org/r/327760

WMDE-leszek added a project: Patch-For-Review.Jan 2 2017, 10:50 AM
WMDE-leszek moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Jan 4 2017, 2:55 PM

Change 327761 merged by jenkins-bot:
Use DispatchingPropertyInfoLookup in DirectSqlStore

https://gerrit.wikimedia.org/r/327761

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Jan 4 2017, 2:57 PM
WMDE-leszek closed this task as Resolved.Jan 18 2017, 10:34 AM
WMDE-leszek removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL