Page MenuHomePhabricator

Allow optional use of data retrieval services from Client in Repo
Closed, ResolvedPublic

Description

In order to access entity data from foreign repositories Repo becomes in a way a Client to foreign repos.

Technically accessing foreign entity data would happen using services introduced in the Client component (T148141).

In order to reuse code we decided to make Repo optionally use the service factory from the Client component. If the service factory is provided Repo would use services from the factory instead of instantiating its own services.

This changes introduces optional Repo dependency on Client. This is not the cleanest structure and it is only intended as the first step to make Wikibase able to use data from foreign repositories.
In the long run the Repo/Client (and Lib) division should be thought again. As we now consider Repo to be Client in a way, the whole distinction between Repo and Client seems not clear and very arbitrary.

Patches for review:

Details

Related Gerrit Patches:

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
StalledNone
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedWMDE-leszek
ResolvedWMDE-leszek
ResolvedJakob_WMDE
ResolvedWMDE-leszek
ResolvedWMDE-leszek
DeclinedNone
ResolvedWMDE-leszek
ResolvedWMDE-leszek
ResolvedWMDE-leszek

Event Timeline

Change 332760 merged by jenkins-bot:
Add EntityDataRetrievalServiceFactory interface

https://gerrit.wikimedia.org/r/332760

Change 327549 had a related patch set uploaded (by WMDE-leszek):
Allow optional usage of Client's data retrieval services in the Repo component

https://gerrit.wikimedia.org/r/327549

Change 327549 merged by jenkins-bot:
Allow optional usage of Client's data retrieval services in the Repo component

https://gerrit.wikimedia.org/r/327549

thiemowmde closed this task as Resolved.Jan 31 2017, 1:10 PM
thiemowmde removed a project: Patch-For-Review.